From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E40A0C7619B for ; Mon, 17 Feb 2020 02:22:45 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B2B3B22522; Mon, 17 Feb 2020 02:22:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sourceforge.net header.i=@sourceforge.net header.b="mRkc06Sc"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sf.net header.i=@sf.net header.b="Mbk49ogb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B2B3B22522 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1j3W3Z-00007Y-BF; Mon, 17 Feb 2020 02:22:45 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1j3W3X-00007L-PE for linux-f2fs-devel@lists.sourceforge.net; Mon, 17 Feb 2020 02:22:43 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:To:Subject:Sender:Reply-To:Cc: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=OT1IE//8k6IX2zEVN6ZEOIn41bBHFmqmjPkvaeqPZ2c=; b=mRkc06ScUDLTNFQKw6lXqXdvk2 yzfGn1F3YcGxZo6bJ3yAP+6koAL+46C84J4g99TJyyHwVv+WJm8JppOpbncUIvkg4nEQa/7k2kXGG sbV1ioqsqwNtDQRQsBBWXmWDYjOij2Z8vJZP6sUz7BaVVS+kgpqFFnp+x0lTZmotu3cU=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Sender:Reply-To:Cc:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=OT1IE//8k6IX2zEVN6ZEOIn41bBHFmqmjPkvaeqPZ2c=; b=Mbk49ogbPzEmvaPL7Hvt8+8kMg 6pcbl2YbgpXK9Z//7XUxdRemIPjDlNMMu3h1vhm3g1bIx4wmwJ3ZlLrMG8A5XphgPCPv1iHkEu34K 26REX+c+0v1ste28Pj2nZYwWovd0r52Bak+OSLVU3YDHWB5uUe/wHd08GueIgFxD8k1Q=; Received: from szxga07-in.huawei.com ([45.249.212.35] helo=huawei.com) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1j3W3S-00ExKH-N6 for linux-f2fs-devel@lists.sourceforge.net; Mon, 17 Feb 2020 02:22:43 +0000 Received: from DGGEMS401-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 39052640039451A6E54E; Mon, 17 Feb 2020 10:22:28 +0800 (CST) Received: from [10.134.22.195] (10.134.22.195) by smtp.huawei.com (10.3.19.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 17 Feb 2020 10:22:23 +0800 To: Jaegeuk Kim , , References: <20200214185855.217360-1-jaegeuk@kernel.org> <20200214185855.217360-3-jaegeuk@kernel.org> From: Chao Yu Message-ID: <9c497f3e-3399-e4a6-f81c-6c4a1f35e5bb@huawei.com> Date: Mon, 17 Feb 2020 10:22:22 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20200214185855.217360-3-jaegeuk@kernel.org> Content-Language: en-US X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected X-Headers-End: 1j3W3S-00ExKH-N6 Subject: Re: [f2fs-dev] [PATCH 3/3] f2fs: skip migration only when BG_GC is called X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 2020/2/15 2:58, Jaegeuk Kim wrote: > FG_GC needs to move entire section more quickly. > > Signed-off-by: Jaegeuk Kim > --- > fs/f2fs/gc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c > index bbf4db3f6bb4..1676eebc8c8b 100644 > --- a/fs/f2fs/gc.c > +++ b/fs/f2fs/gc.c > @@ -1203,7 +1203,7 @@ static int do_garbage_collect(struct f2fs_sb_info *sbi, > > if (get_valid_blocks(sbi, segno, false) == 0) > goto freed; > - if (__is_large_section(sbi) && > + if (gc_type == BG_GC && __is_large_section(sbi) && > migrated >= sbi->migration_granularity) I knew migrating one large section is a more efficient way, but this can increase long-tail latency of f2fs_balance_fs() occasionally, especially in extreme fragmented space. Thanks, > goto skip; > if (!PageUptodate(sum_page) || unlikely(f2fs_cp_error(sbi))) > _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel