From: Damien Le Moal <Damien.LeMoal@wdc.com>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Jens Axboe <axboe@kernel.dk>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
Mike Snitzer <snitzer@redhat.com>,
"linux-f2fs-devel@lists.sourceforge.net"
<linux-f2fs-devel@lists.sourceforge.net>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"dm-devel@redhat.com" <dm-devel@redhat.com>,
Jaegeuk Kim <jaegeuk@kernel.org>, Christoph Hellwig <hch@lst.de>,
Bart Van Assche <bvanassche@acm.org>
Subject: Re: [f2fs-dev] [PATCH V6 3/4] sd_zbc: Fix report zones buffer allocation
Date: Fri, 12 Jul 2019 00:52:05 +0000 [thread overview]
Message-ID: <BYAPR04MB58168DD2A9F429D515E377A1E7F20@BYAPR04MB5816.namprd04.prod.outlook.com> (raw)
In-Reply-To: yq1wogo85c6.fsf@oracle.com
Martin,
On 2019/07/12 9:28, Martin K. Petersen wrote:
>
> Damien,
>
>> During disk scan and revalidation done with sd_revalidate(), the zones
>> of a zoned disk are checked using the helper function
>> blk_revalidate_disk_zones() if a configuration change is detected
>> (change in the number of zones or zone size). The function
>> blk_revalidate_disk_zones() issues report_zones calls that are very
>> large, that is, to obtain zone information for all zones of the disk
>> with a single command. The size of the report zones command buffer
>> necessary for such large request generally is lower than the disk
>> max_hw_sectors and KMALLOC_MAX_SIZE (4MB) and succeeds on boot (no
>> memory fragmentation), but often fail at run time (e.g. hot-plug
>> event). This causes the disk revalidation to fail and the disk
>> capacity to be changed to 0.
>
> Probably easiest to funnel this through block with the rest of the
> series.
Sounds good to me.
Jens,
Could you please consider this series for 5.3 ? We have been using it in tests
since 2-3 weeks ago (5.2-rc6) without any problems. All revalidation problems
disappeared and with no side effects detected.
Thank you.
> Acked-by: Martin K. Petersen <martin.petersen@oracle.com>
Thanks !
--
Damien Le Moal
Western Digital Research
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2019-07-12 1:07 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-01 5:09 [f2fs-dev] [PATCH V6 0/4] Fix zone revalidation memory allocation failures Damien Le Moal
2019-07-01 5:09 ` [f2fs-dev] [PATCH V6 1/4] block: Allow mapping of vmalloc-ed buffers Damien Le Moal
2019-07-01 6:16 ` Christoph Hellwig
2019-07-12 0:22 ` Martin K. Petersen
2019-07-01 5:09 ` [f2fs-dev] [PATCH V6 2/4] block: Kill gfp_t argument of blkdev_report_zones() Damien Le Moal
2019-07-01 6:17 ` Christoph Hellwig
2019-07-12 0:24 ` Martin K. Petersen
2019-07-01 5:09 ` [f2fs-dev] [PATCH V6 3/4] sd_zbc: Fix report zones buffer allocation Damien Le Moal
2019-07-01 6:17 ` Christoph Hellwig
2019-07-12 0:27 ` Martin K. Petersen
2019-07-12 0:52 ` Damien Le Moal [this message]
2019-07-01 5:09 ` [f2fs-dev] [PATCH V6 4/4] block: Limit zone array allocation size Damien Le Moal
2019-07-01 6:17 ` Christoph Hellwig
2019-07-12 0:28 ` Martin K. Petersen
2019-07-08 2:02 ` [f2fs-dev] [PATCH V6 0/4] Fix zone revalidation memory allocation failures Damien Le Moal
2019-07-12 2:05 ` Jens Axboe
2019-07-12 15:12 ` Jens Axboe
2019-07-12 22:33 ` Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR04MB58168DD2A9F429D515E377A1E7F20@BYAPR04MB5816.namprd04.prod.outlook.com \
--to=damien.lemoal@wdc.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=dm-devel@redhat.com \
--cc=hch@lst.de \
--cc=jaegeuk@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).