From: Damien Le Moal <Damien.LeMoal@wdc.com>
To: Bart Van Assche <bvanassche@acm.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
Jens Axboe <axboe@kernel.dk>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
"dm-devel@redhat.com" <dm-devel@redhat.com>,
Mike Snitzer <snitzer@redhat.com>,
"linux-f2fs-devel@lists.sourceforge.net"
<linux-f2fs-devel@lists.sourceforge.net>,
Jaegeuk Kim <jaegeuk@kernel.org>, Chao Yu <yuchao0@huawei.com>
Subject: Re: [f2fs-dev] [dm-devel] [PATCH 8/9] scsi: sd_zbc: Cleanup sd_zbc_alloc_report_buffer()
Date: Sat, 9 Nov 2019 02:54:58 +0000 [thread overview]
Message-ID: <BYAPR04MB5816C442BE08F9973C2CDF15E77A0@BYAPR04MB5816.namprd04.prod.outlook.com> (raw)
In-Reply-To: 6a1e0a08-d65c-b075-9bac-23519e9e91c3@acm.org
On 2019/11/09 4:06, Bart Van Assche wrote:
> On 11/7/19 5:57 PM, Damien Le Moal wrote:
>> - buf = vzalloc(bufsize);
>> - if (buf)
>> - *buflen = bufsize;
>> + while (bufsize >= SECTOR_SIZE) {
>> + buf = vzalloc(bufsize);
>> + if (buf) {
>> + *buflen = bufsize;
>> + return buf;
>> + }
>> + bufsize >>= 1;
>> + }
>
> Hi Damien,
>
> Has it been considered to pass the __GFP_NORETRY flag to this vzalloc()
> call?
Do you mean using
__vmalloc(bufsize,
GFP_KERNEL | __GFP_ZERO | __GFP_NORETRY, PAGE_KERNEL);
instead of vzalloc() ? (since we cannot pass GFP flags to vzalloc()...)
Note that this is called with GFP_NOIO set for the caller context in the
case of revalidate zones, and default to GFP_KERNEL for
blkdev_report_zones() unless the caller also tweaks the context memalloc
flags.
>
> Thanks,
>
> Bart.
>
--
Damien Le Moal
Western Digital Research
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2019-11-09 2:55 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-08 1:56 [f2fs-dev] [PATCH 0/9] Zoned block device enhancements and zone report rework Damien Le Moal
2019-11-08 1:56 ` [f2fs-dev] [PATCH 1/9] block: Enhance blk_revalidate_disk_zones() Damien Le Moal
2019-11-08 6:28 ` [f2fs-dev] [dm-devel] " Christoph Hellwig
2019-11-08 7:10 ` [f2fs-dev] " Hannes Reinecke
2019-11-08 1:56 ` [f2fs-dev] [PATCH 2/9] block: cleanup the !zoned case in blk_revalidate_disk_zones Damien Le Moal
2019-11-08 7:11 ` Hannes Reinecke
2019-11-08 18:50 ` Chaitanya Kulkarni
2019-11-08 1:56 ` [f2fs-dev] [PATCH 3/9] block: Simplify report zones execution Damien Le Moal
2019-11-08 7:12 ` Hannes Reinecke
2019-11-08 1:56 ` [f2fs-dev] [PATCH 4/9] block: Remove partition support for zoned block devices Damien Le Moal
2019-11-08 6:30 ` [f2fs-dev] [dm-devel] " Christoph Hellwig
2019-11-08 7:17 ` [f2fs-dev] " Hannes Reinecke
2019-11-08 7:28 ` Damien Le Moal
2019-11-08 1:56 ` [f2fs-dev] [PATCH 5/9] null_blk: clean up the block device operations Damien Le Moal
2019-11-08 7:17 ` Hannes Reinecke
2019-11-08 18:47 ` Chaitanya Kulkarni
2019-11-08 1:56 ` [f2fs-dev] [PATCH 6/9] null_blk: clean up report zones Damien Le Moal
2019-11-08 7:18 ` Hannes Reinecke
2019-11-08 18:47 ` Chaitanya Kulkarni
2019-11-08 1:57 ` [f2fs-dev] [PATCH 7/9] null_blk: Add zone_nr_conv to features Damien Le Moal
2019-11-08 7:18 ` Hannes Reinecke
2019-11-08 18:48 ` Chaitanya Kulkarni
2019-11-08 1:57 ` [f2fs-dev] [PATCH 8/9] scsi: sd_zbc: Cleanup sd_zbc_alloc_report_buffer() Damien Le Moal
2019-11-08 6:31 ` [f2fs-dev] [dm-devel] " Christoph Hellwig
2019-11-08 7:20 ` [f2fs-dev] " Hannes Reinecke
2019-11-08 19:06 ` [f2fs-dev] [dm-devel] " Bart Van Assche
2019-11-09 2:54 ` Damien Le Moal [this message]
2019-11-09 3:02 ` Bart Van Assche
2019-11-08 1:57 ` [f2fs-dev] [PATCH 9/9] block: rework zone reporting Damien Le Moal
2019-11-08 7:23 ` Hannes Reinecke
2019-11-08 15:16 ` Mike Snitzer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR04MB5816C442BE08F9973C2CDF15E77A0@BYAPR04MB5816.namprd04.prod.outlook.com \
--to=damien.lemoal@wdc.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=dm-devel@redhat.com \
--cc=jaegeuk@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=snitzer@redhat.com \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).