From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D9AAC433DF for ; Thu, 21 May 2020 09:22:45 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 329D32072C for ; Thu, 21 May 2020 09:22:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sourceforge.net header.i=@sourceforge.net header.b="iA5vElEm"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sf.net header.i=@sf.net header.b="kq7jsLsE"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Cr+vYd5d" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 329D32072C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1jbhPX-0003rr-MR; Thu, 21 May 2020 09:22:43 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jbhPW-0003rk-KX for linux-f2fs-devel@lists.sourceforge.net; Thu, 21 May 2020 09:22:42 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Type:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Sender:Reply-To:Content-Transfer-Encoding :Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=FIbEyFSF9lKlh/sPieDWc1oRqrvi4vGBjOrvNTlDQgI=; b=iA5vElEmXzgO8qi05HC6SjhHVE 6IPoOODCdRiwZVCB87xtlaAqVX6oHrNPyERXJADpZxNdDyb/3CQJ9DngKVCI3S5RhehZae86h7db0 uIjyAwZ4WStPg04I0zx/clQEIlMFSK97csk6znotYEKn/eRDQ38DSrrK22VoBKHaODLQ=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Type:Cc:To:Subject:Message-ID:Date:From:In-Reply-To:References: MIME-Version:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=FIbEyFSF9lKlh/sPieDWc1oRqrvi4vGBjOrvNTlDQgI=; b=kq7jsLsE/i2TAJUjGfeu99MCh+ PrBnGCcf3YjCrjl4XD4PTRckPtfyDMguJsFhLiP8s8Qdlfj06sqLa1NpxFnyX7j1R9rrL+eIvZIWh xDNynMM71R534IZIn2q2JWneOCgtzCG3mRyYWeg3O+4vNutJfPPkzSx33a4cD2xpv0UE=; Received: from mail-lf1-f68.google.com ([209.85.167.68]) by sfi-mx-4.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.92.2) id 1jbhPQ-003g2V-Aj for linux-f2fs-devel@lists.sourceforge.net; Thu, 21 May 2020 09:22:42 +0000 Received: by mail-lf1-f68.google.com with SMTP id z22so4099804lfd.0 for ; Thu, 21 May 2020 02:22:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=FIbEyFSF9lKlh/sPieDWc1oRqrvi4vGBjOrvNTlDQgI=; b=Cr+vYd5dIpgIP1m+dtPF8wLQuyM7qoaALMgtSirDDMRRIgqxpytD0hrSF2zko/x5mk l/G2FXraKn8PMsmRDq4Un6jQXt2HJ4hL78VRPU+qdLES1+ToQVDFdGiGtpaOGLK7F2zM 6MKEL1a7yiV4ickufkf1ggX7LbmfPLokTuBN2TG1x20EISryRLnvWvNBgcl/y8m7/sVI MO9cnUWS6iHrtzbq50+WiROYQCTdiEG/ExnjIv1i160UasocMEWgmgikQ3pbvdWCeIhi xdBAwAYfUkhH3wWYCwg1eVm4WzkttSXEgcgDwM0Fh/LeRJSCjz+QgsRbYOOK7ojMzFLX xICg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FIbEyFSF9lKlh/sPieDWc1oRqrvi4vGBjOrvNTlDQgI=; b=qKZGVN81lfUfLzWdstgrYOZrZRkIJzxy1nVwaKKI8Z5oivhe0l2JMlKgn8r36h+27o yZ6zqFHzGVTIzx+fRYMwOKUW3bK7/8fdJ6WLbrPJcv/tbgFH4cDrFD+/cksEniJmW52i 1Y7j3DNAqmYzhAwWz62o9VDCd9BINBS2JJe9lOUMJt2/MFTiDcfrM5DjMUznIgnAcc08 bTHcZmW8QbMWmfJpYphkgNhlerwzdt84txptzMvfuve5cro8fNyKNDb2i/ShIDUx5WCa 4KBpgvTm8WTZtPLkxfkZmDy/qzcQWvFlIuJszZM2P+ptjxmQSEkAvfEVgmTJ5+7FXfF5 ubkA== X-Gm-Message-State: AOAM533oE9Ph3texJFEoY1X97ZqI5kvvXA1sd5GZxcePB2lA/VYFbn/Z FvKa4lACxYBZ41YHrHdma281UoXfyl/aLSYVTWaG/g== X-Google-Smtp-Source: ABdhPJxo0iMvxRymbhbSSmZbSlzo/jmqeHEAf6W0prqay+f+/zEUegDczxDDUgR2FE8lvoDDugzyWov/NH6f84fYzgY= X-Received: by 2002:a19:641b:: with SMTP id y27mr372964lfb.74.1590052942272; Thu, 21 May 2020 02:22:22 -0700 (PDT) MIME-Version: 1.0 References: <20200501135806.4eebf0b92f84ab60bba3e1e7@linux-foundation.org> <20200519075213.GF32497@dhcp22.suse.cz> <20200519084535.GG32497@dhcp22.suse.cz> <20200520190906.GA558281@chrisdown.name> In-Reply-To: <20200520190906.GA558281@chrisdown.name> From: Naresh Kamboju Date: Thu, 21 May 2020 14:52:08 +0530 Message-ID: To: Chris Down X-Headers-End: 1jbhPQ-003g2V-Aj Subject: Re: [f2fs-dev] mm: mkfs.ext4 invoked oom-killer on i386 - pagecache_get_page X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: lkft-triage@lists.linaro.org, Michal Hocko , linux-mm , Yafang Shao , Andreas Dilger , Cgroups , Andrea Arcangeli , Anders Roxell , Hugh Dickins , Matthew Wilcox , Linux-Next Mailing List , linux-ext4 , Arnd Bergmann , linux-block , Jaegeuk Kim , Theodore Ts'o , open list , "Linux F2FS DEV, Mailing List" , Johannes Weiner , Andrew Morton , Roman Gushchin Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On Thu, 21 May 2020 at 00:39, Chris Down wrote: > > Hi Naresh, > > Naresh Kamboju writes: > >As a part of investigation on this issue LKFT teammate Anders Roxell > >git bisected the problem and found bad commit(s) which caused this problem. > > > >The following two patches have been reverted on next-20200519 and retested the > >reproducible steps and confirmed the test case mkfs -t ext4 got PASS. > >( invoked oom-killer is gone now) > > > >Revert "mm, memcg: avoid stale protection values when cgroup is above > >protection" > > This reverts commit 23a53e1c02006120f89383270d46cbd040a70bc6. > > > >Revert "mm, memcg: decouple e{low,min} state mutations from protection > >checks" > > This reverts commit 7b88906ab7399b58bb088c28befe50bcce076d82. > > Thanks Anders and Naresh for tracking this down and reverting. > > I'll take a look tomorrow. I don't see anything immediately obviously wrong in > either of those commits from a (very) cursory glance, but they should only be > taking effect if protections are set. > > Since you have i386 hardware available, and I don't, could you please apply > only "avoid stale protection" again and check if it only happens with that > commit, or requires both? That would help narrow down the suspects. Not both. The bad commit is "mm, memcg: decouple e{low,min} state mutations from protection checks" > > Do you use any memcg protections in these tests? I see three MEMCG configs and please find the kernel config link for more details. CONFIG_MEMCG=y CONFIG_MEMCG_SWAP=y CONFIG_MEMCG_KMEM=y kernel config link, https://builds.tuxbuild.com/8lg6WQibcwtQRRtIa0bcFA/kernel.config - Naresh _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel