From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0E5CC35242 for ; Fri, 14 Feb 2020 21:47:59 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 69AA42168B for ; Fri, 14 Feb 2020 21:47:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=lists.sourceforge.net header.i=@lists.sourceforge.net header.b="AEczqdmZ"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sourceforge.net header.i=@sourceforge.net header.b="C7RBxq9G"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sf.net header.i=@sf.net header.b="KKIC6Tc6"; dkim=neutral (0-bit key) header.d=google.com header.i=@google.com header.b="UghfVcGD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 69AA42168B Authentication-Results: mail.kernel.org; dmarc=pass (p=none dis=none) header.from=lists.sourceforge.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type:Cc: Reply-To:From:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Subject:To:Message-ID:Date:In-Reply-To:References: MIME-Version:Sender:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Ov6UcUhA4hNXavBnT1PD1ideBg++x568zl627MCympY=; b=AEczqdmZEg6z9wuS4kGU3YrF/D dl1U8omxFJqsd7llAAqhO9wL3mF5sAeqd7+bfH4CzapJKK2dLQJLjzTOhvGn/ZQ1MfbsU9HPLiiD9 l+Hpfp/wSmwBD5bgqfmz4j3SY/i4xnDd6AFhsAiIArfTL5x5SIdf/sTkF22+Oa0D3G8s=; Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1j2ioY-0003af-8d; Fri, 14 Feb 2020 21:47:58 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1j2ioW-0003aY-Kr for linux-f2fs-devel@lists.sourceforge.net; Fri, 14 Feb 2020 21:47:56 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Type:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Sender:Reply-To:Content-Transfer-Encoding :Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ULvgOcWtqQoiiZTQEcdkHo/hzvR0mDvJVo9JBCmHaro=; b=C7RBxq9GI2PZAkkXej4GLf00Ks oWHx4a28G1DB20xr+EgdKHIhvE3cfdQYROBZbMj7Kz9YyhtzSCxAxJHVJffvmqRPoeY2fbnBi9q99 c/ayFebBTxB788uGj7RiilGRcPQQjje1KGpSHGf1iOa1zotOV41YFYQM13jhMYkdxVl8=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Type:Cc:To:Subject:Message-ID:Date:From:In-Reply-To:References: MIME-Version:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=ULvgOcWtqQoiiZTQEcdkHo/hzvR0mDvJVo9JBCmHaro=; b=KKIC6Tc6Fqe5hXhWdIiHuJcONI 73vZspakYhmEhQedNZud/6R0oqDTI0jQParGuLVKKU+YrZ4L8vp+LxTtvYDfWXu55fFwN4EZkCUHq s73VIprVfhqhqDLoZjBuyN+qtVmzA4H/guXIH4HJM0L09OdbaQsn56S97c/4etZuDIKI=; Received: from mail-lj1-f193.google.com ([209.85.208.193]) by sfi-mx-3.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.92.2) id 1j2ioV-004Kg7-Er for linux-f2fs-devel@lists.sourceforge.net; Fri, 14 Feb 2020 21:47:56 +0000 Received: by mail-lj1-f193.google.com with SMTP id h23so12297548ljc.8 for ; Fri, 14 Feb 2020 13:47:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ULvgOcWtqQoiiZTQEcdkHo/hzvR0mDvJVo9JBCmHaro=; b=UghfVcGD99QDVJvEji3DwtzpIp/PGb7GJofQVdGg87wpeWgj5k1fmihFbyHJDkzhXm S1NEmhmLvIIspUxPsjqWYv+g8q0cgFqkqJsqk6YpKTd6xRAfC/+pRYqVa+LT/zHudhSe ezPpARw61nPYCHiuMSRuvAH2pkTlrESq7Y0NpQrB9ACMChfUqXxp93LrOIYT2VYUQCJo gmb8qcWUBCD71s/4fRxFDy4T3zhcDp/8yu4ZXGH549/K9U19OlbHknT8fxAAk5duXcIa zBQ+s0+fPCvaocHwCtDCGP4wFwcvFTeDl1IPB9yATUIb5hn70+tb0HH0Q6XBRHaUjClO 2Vvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ULvgOcWtqQoiiZTQEcdkHo/hzvR0mDvJVo9JBCmHaro=; b=ZEuiBS70uXpnIqJSuVg0ejiMMK4qV/+ldU8dSzO/Ntjcwth3EHhnp0/0DYEnvAW6wI jE3GjKbfv0RdImptWmayVyD9ArOobMjlsA9l3tIzaYGGJuqmys6l+ZQiobuX3XtVLv3b WgMeULMX0+eHL99JOwIF521krIsBfn6DKGigYbkZFngiZBnqyih+L1AsoE8YLVMqEUhQ e6maiY/VBZGjXmtI7Lz7flMSpgQrKWLovNnBLCPzT/q3/0UnZU49cnrDFUzMY1f9BM0I cdzNlt3v6vV2Hdppga6Avks5pH9ewqLZJdz/QG3lK+lb255cDqZhzHWvI/ED2aryA9KI fKHQ== X-Gm-Message-State: APjAAAXnVJObkkFbLasKtlD/1Lo36Jmqtl7v0mz8SjsH9J2CM5Dm7e7w hXccfiEk34U1GW0Z7FUN3gOXkZnjyugzFuwepFjLBw== X-Google-Smtp-Source: APXvYqwOnenDJydesgZENHJdVpOerGyyRYO7zjT1GE3p1T0WHWXpqjZg+ov2CAwduAn/RxPssJiAJvJqDMAmNkptrfI= X-Received: by 2002:a2e:85cd:: with SMTP id h13mr3415670ljj.191.1581716868386; Fri, 14 Feb 2020 13:47:48 -0800 (PST) MIME-Version: 1.0 References: <20200208013552.241832-1-drosen@google.com> <20200208013552.241832-2-drosen@google.com> <20200212033800.GC870@sol.localdomain> In-Reply-To: <20200212033800.GC870@sol.localdomain> Date: Fri, 14 Feb 2020 13:47:37 -0800 Message-ID: To: Eric Biggers , Gabriel Krisman Bertazi X-Headers-End: 1j2ioV-004Kg7-Er Subject: Re: [f2fs-dev] [PATCH v7 1/8] unicode: Add utf8_casefold_iter X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Daniel Rosenberg via Linux-f2fs-devel Reply-To: Daniel Rosenberg Cc: Theodore Ts'o , Jonathan Corbet , Richard Weinberger , Andreas Dilger , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-fscrypt@vger.kernel.org, linux-mtd@lists.infradead.org, Alexander Viro , linux-fsdevel@vger.kernel.org, Jaegeuk Kim , linux-ext4@vger.kernel.org, kernel-team@android.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On Tue, Feb 11, 2020 at 7:38 PM Eric Biggers wrote: > > Indirect function calls are expensive these days for various reasons, including > Spectre mitigations and CFI. Are you sure it's okay from a performance > perspective to make an indirect call for every byte of the pathname? > > > +typedef int (*utf8_itr_actor_t)(struct utf8_itr_context *, int byte, int pos); > > The byte argument probably should be 'u8', to avoid confusion about whether it's > a byte or a Unicode codepoint. > > - Eric Gabriel, what do you think here? I could change it to either exposing the things necessary to do the hashing in libfs, or instead of the general purpose iterator, just have a hash function inside of unicode that will compute the hash given a seed value. -Daniel _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel