From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94EACC3A59F for ; Fri, 30 Aug 2019 02:02:35 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 582C221897; Fri, 30 Aug 2019 02:02:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sourceforge.net header.i=@sourceforge.net header.b="fJ3RcsE6"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sf.net header.i=@sf.net header.b="W4U5/bfm"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SUiSI+Km" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 582C221897 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1i3WFG-0001bx-Qn; Fri, 30 Aug 2019 02:02:34 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1i3WFF-0001bX-FO; Fri, 30 Aug 2019 02:02:33 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Type:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Sender:Reply-To:Content-Transfer-Encoding :Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=oLvzfsj88KL7STQQplyqqS42g24w/uMRduFS4XzvSOo=; b=fJ3RcsE65hFVciRBlXfCHhVxfX chykThCpwHqCSZIEKUWnbfMRN2SFgXQaD5yis80OJvJushsk0eberbRfIoduqrxhZB/94lnucMfvm p9SK8bxcJFwi+9V08EeYvvAwZnDGx7njT9IkN42mOJzZvl3pifXAy38rgiZYgxL3g5sk=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Type:Cc:To:Subject:Message-ID:Date:From:In-Reply-To:References: MIME-Version:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=oLvzfsj88KL7STQQplyqqS42g24w/uMRduFS4XzvSOo=; b=W4U5/bfmamBoFWdPvK7TWp5q7X WDRefdqjOkmcxoYD3PQF1dbiQOnhRNhB2rEtJoBglqdD1/DNBYcCx9n9ORGZkm/pMn9dMD9vWCV7t mcPTDoEUEPY9kMNI9Ev2iiWTwELXNwQkl+uoLWXIVKLahvjLol/p1+zbRsA5EaNFol2k=; Received: from mail-io1-f65.google.com ([209.85.166.65]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.90_1) id 1i3WFD-008gGZ-TC; Fri, 30 Aug 2019 02:02:33 +0000 Received: by mail-io1-f65.google.com with SMTP id t3so10866955ioj.12; Thu, 29 Aug 2019 19:02:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=oLvzfsj88KL7STQQplyqqS42g24w/uMRduFS4XzvSOo=; b=SUiSI+Km3m50gBNp/Vf1kQ5Znt7t2xjJr9IjLemKNMiLxz2yhpZsbK/DLZC4L9urNb gDxuG7f7XtiecI937GfbQdq+jdln7Z3Fb+8kZnJxwlPpeYQImuMwhjHoDEP857mW1lVb NZHRIybWwFHnsioflZzUdQfkXgsEf/TexqY+05N8IO8NvnMnQftjfJ9hFazxqlx7VQO+ BZ2rZ7/dbzo90ZAvtO0lvvso+7mGgwA9kdlEC7uFLAulP9R+MYUVIvG8IxPGPXul5/em IvII12CYogidxhoNLSBGFsf9ZguQCTMWCWKe+z44xwiHPHukomi7gttk607Xpy0ogB0G kuPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=oLvzfsj88KL7STQQplyqqS42g24w/uMRduFS4XzvSOo=; b=FSwt/93zvwkLhHKScWt3pR3pCqXl5d8HZoG30/XoMJM/UJGXiTwi92jXiUFcFM4neT ehylAgGaALFvME9G6Sq0bFVN2dLcUPJufhEc3tB7BsqQ7VeurVcfAT2MjodHuKyYesIH Ck8p2qOy/Di/Q4rHXliSZ+i1lKdXB+LOXORrB7XNIj49VJ1Ex5edFT+IjaickJUc1i4g O18Y7mvuFTDIAgTirBX5dQH5mhq9caOYdBk+dteqhT/iLdPwCeWo5/En8EqbM0J4TtF6 TgM8Zssy9ViKAJLSIaYq5Ncwyk/q+Zeyzvveib25UMxYoy50oqBlqlubAxV/b1NIpPOj dEiQ== X-Gm-Message-State: APjAAAXhUbWC1rQ1SGzxDzGqqBge9kR2Un0mFMwf+/xfQtHsSQdScNWS bntc4qJOBXeEqWDw8v0+5uiAV28A5PIDJh+kFho= X-Google-Smtp-Source: APXvYqzBsNh7crucvVXKqn/eA6ggQob01fCf1ZKTT3BSHFJDqk3FlwYnF1wm6BwegRm/uQfEg9JQEGStTj+fA+RuGsU= X-Received: by 2002:a5d:8599:: with SMTP id f25mr9602181ioj.265.1567130545941; Thu, 29 Aug 2019 19:02:25 -0700 (PDT) MIME-Version: 1.0 References: <20190829041132.26677-1-deepa.kernel@gmail.com> In-Reply-To: From: Deepa Dinamani Date: Thu, 29 Aug 2019 19:02:13 -0700 Message-ID: To: Mike Marshall X-Headers-End: 1i3WFD-008gGZ-TC Subject: Re: [f2fs-dev] [GIT PULL] vfs: Add support for timestamp limits X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Latchesar Ionkov , Martin Brandenburg , jfs-discussion@lists.sourceforge.net, Dave Kleikamp , al@alarsen.net, Bob Copeland , Adrian Hunter , Andreas Dilger , mikulas@artax.karlin.mff.cuni.cz, stoph Hellwig , nico@fluxnic.net, linux-cifs@vger.kernel.org, "Yan, Zheng" , Sage Weil , "Darrick J. Wong" , y2038 Mailman List , Richard Weinberger , Steve French , Anton Vorontsov , linux@armlinux.org.uk, codalist@coda.cs.cmu.edu, Christoph Hellwig , coda@cs.cmu.edu, V9FS Developers , Ilya Dryomov , Ext4 Developers List , salah.triki@gmail.com, asmadeus@codewreck.org, devel@lists.orangefs.org, Evgeniy Dushistov , Kees Cook , Arnd Bergmann , Eric Van Hensbergen , Jan Kara , reiserfs-devel@vger.kernel.org, Tejun Heo , Alexander Viro , aivazian.tigran@gmail.com, phillip@squashfs.org.uk, David Sterba , Jaegeuk Kim , ceph-devel , trond.myklebust@hammerspace.com, OGAWA Hirofumi , Andreas Dilger , Jan Harkes , Linux NFS Mailing List , Tony Luck , Theodore Ts'o , luisbg@kernel.org, Artem Bityutskiy , linux-ntfs-dev@lists.sourceforge.net, Greg KH , linux-karma-devel@lists.sourceforge.net, jlayton@kernel.org, Linux Kernel Mailing List , "Linux F2FS DEV, Mailing List" , linux-xfs@vger.kernel.org, Colin Cross , Linux FS-devel Mailing List , linux-mtd , David Woodhouse , Anna Schumaker , Joel Becker Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On Thu, Aug 29, 2019 at 6:20 PM Mike Marshall wrote: > > Hi Deepa... > > I installed this patch series on top of Linux 5.3-rc6 and ran xfstests > on orangefs and got a regression... generic/258 failed > with: "Timestamp wrapped"... > > # cat results/generic/258.out.bad > QA output created by 258 > Creating file with timestamp of Jan 1, 1960 > Testing for negative seconds since epoch > Timestamp wrapped: 0 > Timestamp wrapped > (see /home/hubcap/xfstests-dev/results//generic/258.full for details) Note that patch [16/20] https://lkml.org/lkml/2019/8/18/193 assumes that orangefs does not support negative timestamps. And, the reason was pointed out in the commit text: ---------------------- Assume the limits as unsigned according to the below commit 98e8eef557a9 ("changed PVFS_time from int64_t to uint64_t") in https://github.com/waltligon/orangefs Author: Neill Miller Date: Thu Sep 2 15:00:38 2004 +0000 -------------------- So the timestamp being wrapped to 0 in this case is correct behavior according to my patchset. The generic/258 assumes that the timestamps can be negative. If this is not true then it should not be run for this fs. But, if you think the timestamp should support negative timestamps for orangefs, I'd be happy to change it. > Just to double check, I compiled Linux 5.3-rc6 without the timestamp series, > and 258 passed... then added the patch series back and the failure returned... > > Also.... when I was using "git am" to apply the patch series, the ceph patch > failed, so I "git skipped" it... My series applies cleanly against linux-next as of yesterday. -Deepa _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel