From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5644C4338F for ; Fri, 20 Aug 2021 15:23:55 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6683661242 for ; Fri, 20 Aug 2021 15:23:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6683661242 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1mH6N8-0006bO-Tw; Fri, 20 Aug 2021 15:23:54 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mH6N7-0006b6-La for linux-f2fs-devel@lists.sourceforge.net; Fri, 20 Aug 2021 15:23:53 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Type:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Sender:Reply-To:Content-Transfer-Encoding :Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=LmlIpUuRl+AQl6NHORx2uksaHk6e1Bkml3gkzzdbETU=; b=c8o275CUAp+5kCIdaHg7pWpHTs ZEkAYHnXzxPjl0hXa7AKi/KmdNeISOvsFAPHbraVnNxkPoT1Uotag02JhfPoLU5EfnSGxo5UlAurZ hbr+p0nfzvBbcHp1lE3xD0IBkTWXBrCpTHDNBhWcUnxNEwt7QIp7cBmeE5yhGDXEAeMo=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Type:Cc:To:Subject:Message-ID:Date:From:In-Reply-To:References: MIME-Version:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=LmlIpUuRl+AQl6NHORx2uksaHk6e1Bkml3gkzzdbETU=; b=eaAP8eUzDsEvlo+qPEsaWjPzKr GGWUyCdcNe+INIU0ljMw3n1I5C2zgjYTJulJiUyJo84mb5CFH2LOs42LHJAQzUy1pelFT5XV7Ts3M r5wC40CFvz8YGGvR9P7WWZVumSyg2crA+HXudyXzmW3AIlmEVx3WNyrUjb2V96jfXUWw=; Received: from mail-lf1-f51.google.com ([209.85.167.51]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.92.3) id 1mH6Me-00Csry-3Q for linux-f2fs-devel@lists.sourceforge.net; Fri, 20 Aug 2021 15:23:53 +0000 Received: by mail-lf1-f51.google.com with SMTP id i9so21314891lfg.10 for ; Fri, 20 Aug 2021 08:23:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=LmlIpUuRl+AQl6NHORx2uksaHk6e1Bkml3gkzzdbETU=; b=lfsgunIBPvh1N2HMfHLuTu6bb4D3MC64EfdWNwsp5/I6e9+sfnYHnIciUn9iZmjfE0 RpMGbkMBlb41YT2k/VuMPHP5HH0vI1ft3AxZAqjXqSV2D48lo2PyvBqf1WE8groFrbSz piCHKr+s5jQ3BOWinXhcxtVn97Y2iAAcvrQ+yyehKq2a2l3LGlvs/TU3UNUT3xIayr0A upenWwnnUkAajCqzvvSGk9T7fSjgoGzVxrO0LYkz2bj/FByEg0EKheI4pi9b07cRPfpH SnvrUc9FNOeQ6o8yxGKnMLHduaRcnUfRnEr9uicYa2qgy2arR6dkRInN0Y84ycx9HbD7 Hczg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=LmlIpUuRl+AQl6NHORx2uksaHk6e1Bkml3gkzzdbETU=; b=dZboNhB2XkGpUwlSNGsZ2L4Wyu+L5Kmeqf0x5RsGnxzWIbqw+SMot3RC0y1Za/9CS0 15G/euzu4ba6HXz4CL8+EcBdochXpAQiViz+AM6IWGQ7+8M0pwxncKdHb5++9lZr4BD3 W0yLPzU6Wv80TkWPcNebldXN0vJxJ802timqsqnw1wWkgM03dqUyIsqXkuf+63W5xVXc un4vc4qB7Qa29GODGHFERmW6JxOvoQmAWgy4Rw4hiy4h/PNo4VakSHcGqr4iK28lVXOL gFDJ5h9EBiWl+UTAVNHY3+VrAzxHnUAo1eNRULVFYXZncqlzG4UrwlMn3qa6P8HfOQX1 ydZw== X-Gm-Message-State: AOAM532287MhXPAavqrbhKtxFwTQg2gWbo0AbObz2EcsUY3iHv8nb3gi yoqBn3aMPsPKGrbuVX3nG1RNc6E7mLfEwACZv48= X-Google-Smtp-Source: ABdhPJyw8/e5A74C67qJGcTsZiZKzpB1smdk0k5v/GkqQliEF2YXs0kwLwrudgjmcfMsEXbeJCSQEaghgLDo4wm0808= X-Received: by 2002:ac2:4573:: with SMTP id k19mr14978867lfm.622.1629472996150; Fri, 20 Aug 2021 08:23:16 -0700 (PDT) MIME-Version: 1.0 References: <20210820035229.216975-1-daeho43@gmail.com> <20210820035229.216975-2-daeho43@gmail.com> <48725f58-1a48-73f3-80cf-a0c5efc3b470@kernel.org> In-Reply-To: <48725f58-1a48-73f3-80cf-a0c5efc3b470@kernel.org> From: Daeho Jeong Date: Fri, 20 Aug 2021 08:23:05 -0700 Message-ID: To: Chao Yu X-Headers-End: 1mH6Me-00Csry-3Q Subject: Re: [f2fs-dev] [PATCH v4 2/2] f2fs: introduce periodic iostat io latency traces X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daeho Jeong , kernel-team@android.com, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On Fri, Aug 20, 2021 at 3:50 AM Chao Yu wrote: > > On 2021/8/20 11:52, Daeho Jeong wrote: > > +void iostat_update_and_unbind_ctx(struct bio *bio, int rw) > > +{ > > + struct bio_iostat_ctx *iostat_ctx = bio->bi_private; > > + int sync_type = bio->bi_opf & REQ_SYNC ? 0 : 1; > > int sync_type = bio->bi_opf & REQ_SYNC ? 1 : 0; > > Right? This means just type, not boolean number. So, I set type 0 is sync and type 1 is async. > > > int f2fs_init_iostat(struct f2fs_sb_info *sbi) > > { > > /* init iostat info */ > > spin_lock_init(&sbi->iostat_lock); > > + spin_lock_init(&sbi->iostat_lat_lock); > > sbi->iostat_enable = false; > > sbi->iostat_period_ms = DEFAULT_IOSTAT_PERIOD_MS; > > + sbi->iostat_io_lat = f2fs_kzalloc(sbi, sizeof(struct iostat_lat_info), > > + GFP_KERNEL); > > + if (!sbi->iostat_io_lat) > > + return -ENOMEM; > > What do you think of just embedding iostat_io_lat structure into f2fs_sb_info > structure? it's minor thing though. > I also wanted to do that, but if we embed this type, we need to define that structure in f2fs.h file. Is it okay with you? > Thanks, _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel