linux-f2fs-devel.lists.sourceforge.net archive mirror
 help / color / mirror / Atom feed
From: Ju Hyung Park <qkrwngud825@gmail.com>
To: Chao Yu <yuchao0@huawei.com>
Cc: linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH 2/2] mkfs.f2fs: add VM disk files to hot data types
Date: Wed, 14 Aug 2019 18:22:18 +0900	[thread overview]
Message-ID: <CAD14+f1cTyUrj0a-vFaubR+309YUXQeSVNmOqDj9jjjbduEW3w@mail.gmail.com> (raw)
In-Reply-To: <5761733a-ae6a-2bab-4a68-7f91823e775d@huawei.com>

Hi Chao,

You're right and Android will never use those types.

But then again, what's the point of separating the list?
I haven't encountered an Android user or an OEM that wants to
customize this list by passing an argument to mkfs.f2fs.

If an OEM want to customize this list, directly modifying the code for
mkfs.f2fs sounds better anyways.

Thanks.

On Wed, Aug 14, 2019 at 10:51 AM Chao Yu <yuchao0@huawei.com> wrote:
>
> On 2019/8/13 6:52, Park Ju Hyung wrote:
> > Similar to .db files, these are randomly updated extremely frequently.
>
> It looks android doesn't need this, how about adding them under "#ifndef
> WITH_ANDROID"?
>
> Thanks,
>
> >
> > Signed-off-by: Park Ju Hyung <qkrwngud825@gmail.com>
> > ---
> >  mkfs/f2fs_format.c | 5 +++++
> >  1 file changed, 5 insertions(+)
> >
> > diff --git a/mkfs/f2fs_format.c b/mkfs/f2fs_format.c
> > index 37d82c3..1c08e3e 100644
> > --- a/mkfs/f2fs_format.c
> > +++ b/mkfs/f2fs_format.c
> > @@ -94,6 +94,11 @@ const char *media_ext_lists[] = {
> >
> >  const char *hot_ext_lists[] = {
> >       "db",
> > +
> > +     /* Virtual machines */
> > +     "vmdk", // VMware or VirtualBox
> > +     "vdi", // VirtualBox
> > +     "qcow2", // QEMU
> >       NULL
> >  };
> >
> >


_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

  reply	other threads:[~2019-08-14  9:22 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-12 22:52 [f2fs-dev] [PATCH 1/2] mkfs.f2fs: add "zip" to cold data types Park Ju Hyung
2019-08-12 22:52 ` [f2fs-dev] [PATCH 2/2] mkfs.f2fs: add VM disk files to hot " Park Ju Hyung
2019-08-14  1:51   ` Chao Yu
2019-08-14  9:22     ` Ju Hyung Park [this message]
2019-08-15  6:23       ` Chao Yu
2019-08-14  1:47 ` [f2fs-dev] [PATCH 1/2] mkfs.f2fs: add "zip" to cold " Chao Yu
2019-08-14  1:53   ` Chao Yu
2019-08-14  9:20   ` Ju Hyung Park
2019-08-14  9:47     ` Chao Yu
2019-08-14 14:10       ` Ju Hyung Park
2019-08-15  3:04         ` Chao Yu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAD14+f1cTyUrj0a-vFaubR+309YUXQeSVNmOqDj9jjjbduEW3w@mail.gmail.com \
    --to=qkrwngud825@gmail.com \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=yuchao0@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).