From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HK_RANDOM_FROM,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 436E8C32753 for ; Wed, 14 Aug 2019 09:22:38 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 15654204EC; Wed, 14 Aug 2019 09:22:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sourceforge.net header.i=@sourceforge.net header.b="A9CgjURp"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sf.net header.i=@sf.net header.b="amH4RaQM"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OUJ8PNsr" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 15654204EC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1hxpUL-0003l5-NW; Wed, 14 Aug 2019 09:22:37 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1hxpUK-0003kw-78 for linux-f2fs-devel@lists.sourceforge.net; Wed, 14 Aug 2019 09:22:36 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Type:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Sender:Reply-To:Content-Transfer-Encoding :Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=SAr1vcmf8/odyrGaz5y9j+yYPNLhagxFitwrgIM924E=; b=A9CgjURpk6U1D1Jd/7/ZNIz0MS fvo7YA2hhRsNSppfUFc5K4cXbJRgFb+kj2i5mL4MmhYZxAWSYl7hNvkPN7EnZrpQozeHDofR1aM33 3v0N9iivb7+oLU7u/gMGRp8+kkvCJGzNAue9ANissDe4XoRb4iUrS1p2aLkSlc3W+Bio=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Type:Cc:To:Subject:Message-ID:Date:From:In-Reply-To:References: MIME-Version:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=SAr1vcmf8/odyrGaz5y9j+yYPNLhagxFitwrgIM924E=; b=amH4RaQM8wlcyXy5YH1sGVEYDR wjXe326freh1SgovncN2327KhjJi3S9UKNEaNS8ohIq+3Dov+eoiA7LTmip3Y1/iu73Chr+qAjAxY 8GeaI7SGGNfxlKjuCGbJONC2p4uo+Bw/ury5pKCsWNI5rJVbN5qJ3ayw6rLhZM/ZVX8E=; Received: from mail-ua1-f65.google.com ([209.85.222.65]) by sfi-mx-4.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.90_1) id 1hxpUI-003KLg-VZ for linux-f2fs-devel@lists.sourceforge.net; Wed, 14 Aug 2019 09:22:36 +0000 Received: by mail-ua1-f65.google.com with SMTP id o2so517935uae.10 for ; Wed, 14 Aug 2019 02:22:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=SAr1vcmf8/odyrGaz5y9j+yYPNLhagxFitwrgIM924E=; b=OUJ8PNsrF2CyfDJGFlbj8zuXyBbvYp+8I+5kcWwq5eYEEifrEbHaGlztfNLR6KD+db c5KmXVzBFX2BsK9aLZt/bFSyBfJ1rEvQ/qb29P0NsncQCgNkDlXTeH4HUCo0UV998AHG dH4U1wNqgd5io8X3HDOTAFEsxs93obVEeNAbgVL/qAgyRHhDr6BVIMEl47UbdrtvqZx5 yodTRUmpCyTzUSDncoyVYZDXoPYlRhU8CywIqYHeToZOmdR7Az0fA5/tDqxOt9tBwfD3 +eAyZHFs2GeJl2Og8HCQnA7xVkIEEdcw25H2dnvbsACe6d/aot8vPZreu3LzOeo1y+qe 6yeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=SAr1vcmf8/odyrGaz5y9j+yYPNLhagxFitwrgIM924E=; b=gZgjyIRmHFZpJQl9vw792TZCtgjKo1HFYUf61hIzULRDs2cLFllGuxv67mkZpdxS6s ynVWYFXwBJJfZFBXVUklDz+W0DOuVVEHYp6nmYrioaEcK2UqvqmLT9i+X+gHKaYpOCU7 aDkNjbS+sMiBxF3euL9U2+SuWgD93SF/uVmiKW3vsnrPHIop4jqUy43PU0Y1kEr+zW92 VHcNbr0GnIJkD8jXdiTm3FQZ4YzkfV8+1ad+qxaKn1bk642jvtnsU6ZnVKHQ1wDfkieT sYuQrJR1GkivYG+vVyC5EIHJ0j2T6MlRw6PIVsKPiWZli/EI4LjIF2ybMmN74J5NkY9e bsfw== X-Gm-Message-State: APjAAAXd4t3At6L6zu80knbGLHBgR+DT28Dx/CbQlt+ckIoLN3urHza6 0vQ03VbgXO8bh38rlLRzbnvtd9OSqLLyF3DbzYg= X-Google-Smtp-Source: APXvYqwwD7Wde2I/B4TfdbFD276/X/5k/rT0dSj3vimz3P2EgzOL3gQewi2gMprXmYqzBxtgKlfbswmvvsWqvoJI9Tg= X-Received: by 2002:ab0:3359:: with SMTP id h25mr1103908uap.132.1565774548883; Wed, 14 Aug 2019 02:22:28 -0700 (PDT) MIME-Version: 1.0 References: <20190812225211.1737-1-qkrwngud825@gmail.com> <20190812225211.1737-2-qkrwngud825@gmail.com> <5761733a-ae6a-2bab-4a68-7f91823e775d@huawei.com> In-Reply-To: <5761733a-ae6a-2bab-4a68-7f91823e775d@huawei.com> From: Ju Hyung Park Date: Wed, 14 Aug 2019 18:22:18 +0900 Message-ID: To: Chao Yu X-Headers-End: 1hxpUI-003KLg-VZ Subject: Re: [f2fs-dev] [PATCH 2/2] mkfs.f2fs: add VM disk files to hot data types X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net Hi Chao, You're right and Android will never use those types. But then again, what's the point of separating the list? I haven't encountered an Android user or an OEM that wants to customize this list by passing an argument to mkfs.f2fs. If an OEM want to customize this list, directly modifying the code for mkfs.f2fs sounds better anyways. Thanks. On Wed, Aug 14, 2019 at 10:51 AM Chao Yu wrote: > > On 2019/8/13 6:52, Park Ju Hyung wrote: > > Similar to .db files, these are randomly updated extremely frequently. > > It looks android doesn't need this, how about adding them under "#ifndef > WITH_ANDROID"? > > Thanks, > > > > > Signed-off-by: Park Ju Hyung > > --- > > mkfs/f2fs_format.c | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/mkfs/f2fs_format.c b/mkfs/f2fs_format.c > > index 37d82c3..1c08e3e 100644 > > --- a/mkfs/f2fs_format.c > > +++ b/mkfs/f2fs_format.c > > @@ -94,6 +94,11 @@ const char *media_ext_lists[] = { > > > > const char *hot_ext_lists[] = { > > "db", > > + > > + /* Virtual machines */ > > + "vmdk", // VMware or VirtualBox > > + "vdi", // VirtualBox > > + "qcow2", // QEMU > > NULL > > }; > > > > _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel