From: Yafang Shao <laoar.shao@gmail.com>
To: Naresh Kamboju <naresh.kamboju@linaro.org>
Cc: lkft-triage@lists.linaro.org, Michal Hocko <mhocko@kernel.org>,
linux-mm <linux-mm@kvack.org>,
Andreas Dilger <adilger.kernel@dilger.ca>,
Cgroups <cgroups@vger.kernel.org>,
Andrea Arcangeli <aarcange@redhat.com>,
Anders Roxell <anders.roxell@linaro.org>,
Hugh Dickins <hughd@google.com>,
Matthew Wilcox <willy@infradead.org>,
Linux-Next Mailing List <linux-next@vger.kernel.org>,
linux-ext4 <linux-ext4@vger.kernel.org>,
Arnd Bergmann <arnd@arndb.de>,
linux-block <linux-block@vger.kernel.org>,
Jaegeuk Kim <jaegeuk@kernel.org>, Theodore Ts'o <tytso@mit.edu>,
Chris Down <chris@chrisdown.name>,
open list <linux-kernel@vger.kernel.org>,
"Linux F2FS DEV,
Mailing List" <linux-f2fs-devel@lists.sourceforge.net>,
Johannes Weiner <hannes@cmpxchg.org>,
Andrew Morton <akpm@linux-foundation.org>,
Roman Gushchin <guro@fb.com>
Subject: Re: [f2fs-dev] mm: mkfs.ext4 invoked oom-killer on i386 - pagecache_get_page
Date: Thu, 21 May 2020 10:39:25 +0800 [thread overview]
Message-ID: <CALOAHbDMrHkNHTxeBWP22iTjJd+HfqfFhAfmC_m0jsVkhu5vEA@mail.gmail.com> (raw)
In-Reply-To: <CA+G9fYsXnwyGetj-vztAKPt8=jXrkY8QWe74u5EEA3XPW7aikQ@mail.gmail.com>
On Thu, May 21, 2020 at 2:00 AM Naresh Kamboju
<naresh.kamboju@linaro.org> wrote:
>
> On Wed, 20 May 2020 at 17:26, Naresh Kamboju <naresh.kamboju@linaro.org> wrote:
> >
> >
> > This issue is specific on 32-bit architectures i386 and arm on linux-next tree.
> > As per the test results history this problem started happening from
> > Bad : next-20200430
> > Good : next-20200429
> >
> > steps to reproduce:
> > dd if=/dev/disk/by-id/ata-SanDisk_SSD_PLUS_120GB_190504A00573
> > of=/dev/null bs=1M count=2048
> > or
> > mkfs -t ext4 /dev/disk/by-id/ata-SanDisk_SSD_PLUS_120GB_190804A00BE5
> >
> >
> > Problem:
> > [ 38.802375] dd invoked oom-killer: gfp_mask=0x100cc0(GFP_USER),
> > order=0, oom_score_adj=0
>
> As a part of investigation on this issue LKFT teammate Anders Roxell
> git bisected the problem and found bad commit(s) which caused this problem.
>
> The following two patches have been reverted on next-20200519 and retested the
> reproducible steps and confirmed the test case mkfs -t ext4 got PASS.
> ( invoked oom-killer is gone now)
>
> Revert "mm, memcg: avoid stale protection values when cgroup is above
> protection"
> This reverts commit 23a53e1c02006120f89383270d46cbd040a70bc6.
>
> Revert "mm, memcg: decouple e{low,min} state mutations from protection
> checks"
> This reverts commit 7b88906ab7399b58bb088c28befe50bcce076d82.
>
My guess is that we made the same mistake in commit "mm, memcg:
decouple e{low,min} state mutations from protection
checks" that it read a stale memcg protection in
mem_cgroup_below_low() and mem_cgroup_below_min().
Bellow is a possble fix,
diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h
index 7a2c56fc..6591b71 100644
--- a/include/linux/memcontrol.h
+++ b/include/linux/memcontrol.h
@@ -391,20 +391,28 @@ static inline unsigned long
mem_cgroup_protection(struct mem_cgroup *root,
void mem_cgroup_calculate_protection(struct mem_cgroup *root,
struct mem_cgroup *memcg);
-static inline bool mem_cgroup_below_low(struct mem_cgroup *memcg)
+static inline bool mem_cgroup_below_low(struct mem_cgroup *root,
+ struct mem_cgroup *memcg)
{
if (mem_cgroup_disabled())
return false;
+ if (root == memcg)
+ return false;
+
return READ_ONCE(memcg->memory.elow) >=
page_counter_read(&memcg->memory);
}
-static inline bool mem_cgroup_below_min(struct mem_cgroup *memcg)
+static inline bool mem_cgroup_below_min(struct mem_cgroup *root,
+ struct mem_cgroup *memcg)
{
if (mem_cgroup_disabled())
return false;
+ if (root == memcg)
+ return false;
+
return READ_ONCE(memcg->memory.emin) >=
page_counter_read(&memcg->memory);
}
@@ -896,12 +904,14 @@ static inline void
mem_cgroup_calculate_protection(struct mem_cgroup *root,
{
}
-static inline bool mem_cgroup_below_low(struct mem_cgroup *memcg)
+static inline bool mem_cgroup_below_low(struct mem_cgroup *root,
+ struct mem_cgroup *memcg)
{
return false;
}
-static inline bool mem_cgroup_below_min(struct mem_cgroup *memcg)
+static inline bool mem_cgroup_below_min(struct mem_cgroup *root,
+ struct mem_cgroup *memcg)
{
return false;
}
diff --git a/mm/vmscan.c b/mm/vmscan.c
index c71660e..fdcdd88 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -2637,13 +2637,13 @@ static void shrink_node_memcgs(pg_data_t
*pgdat, struct scan_control *sc)
mem_cgroup_calculate_protection(target_memcg, memcg);
- if (mem_cgroup_below_min(memcg)) {
+ if (mem_cgroup_below_min(target_memcg, memcg)) {
/*
* Hard protection.
* If there is no reclaimable memory, OOM.
*/
continue;
- } else if (mem_cgroup_below_low(memcg)) {
+ } else if (mem_cgroup_below_low(target_memcg, memcg)) {
/*
* Soft protection.
* Respect the protection only as long as
> i386 test log shows mkfs -t ext4 pass
> https://lkft.validation.linaro.org/scheduler/job/1443405#L1200
>
> ref:
> https://lore.kernel.org/linux-mm/cover.1588092152.git.chris@chrisdown.name/
> https://lore.kernel.org/linux-mm/CA+G9fYvzLm7n1BE7AJXd8_49fOgPgWWTiQ7sXkVre_zoERjQKg@mail.gmail.com/T/#t
>
> --
> Linaro LKFT
> https://lkft.linaro.org
--
Thanks
Yafang
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2020-05-21 2:40 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-01 12:38 [f2fs-dev] mm: mkfs.ext4 invoked oom-killer on i386 - pagecache_get_page Naresh Kamboju
2020-05-01 20:58 ` Andrew Morton
2020-05-18 14:10 ` Naresh Kamboju
2020-05-19 7:52 ` Michal Hocko
2020-05-19 8:11 ` Arnd Bergmann
2020-05-19 8:45 ` Michal Hocko
2020-05-20 11:56 ` Naresh Kamboju
2020-05-20 17:59 ` Naresh Kamboju
2020-05-20 19:09 ` Chris Down
2020-05-21 9:22 ` Naresh Kamboju
2020-05-21 9:35 ` Arnd Bergmann
2020-05-21 9:55 ` Michal Hocko
2020-05-21 10:41 ` Naresh Kamboju
2020-05-21 10:58 ` Michal Hocko
2020-05-21 12:24 ` Hugh Dickins via Linux-f2fs-devel
2020-05-21 12:44 ` Michal Hocko
2020-05-21 19:17 ` Johannes Weiner
2020-05-21 20:06 ` Hugh Dickins via Linux-f2fs-devel
2020-05-21 21:58 ` Johannes Weiner
2020-05-21 23:35 ` Hugh Dickins via Linux-f2fs-devel
2020-05-28 14:59 ` Michal Hocko
2020-05-21 16:34 ` Michal Hocko
2020-05-21 19:00 ` Naresh Kamboju
2020-05-21 20:53 ` Naresh Kamboju
2020-05-28 15:03 ` Michal Hocko
2020-05-28 16:17 ` Naresh Kamboju
2020-05-28 16:41 ` Chris Down
2020-05-29 1:50 ` Yafang Shao
2020-05-29 1:56 ` Chris Down
2020-05-29 9:49 ` Michal Hocko
2020-06-11 9:55 ` Michal Hocko
2020-06-12 9:43 ` Naresh Kamboju
2020-06-12 12:09 ` Michal Hocko
2020-06-17 13:37 ` Naresh Kamboju
2020-06-17 13:57 ` Chris Down
2020-06-17 14:11 ` Michal Hocko
2020-06-17 15:53 ` Naresh Kamboju
2020-06-17 16:06 ` Michal Hocko
2020-06-17 20:13 ` Naresh Kamboju
2020-06-17 21:09 ` Chris Down
2020-06-18 1:43 ` Yafang Shao
2020-06-18 12:37 ` Chris Down
2020-06-18 12:41 ` Michal Hocko
2020-06-18 12:49 ` Chris Down
2020-06-18 14:59 ` Yafang Shao
2020-06-17 13:59 ` Michal Hocko
2020-06-17 14:08 ` Chris Down
2020-05-21 2:39 ` Yafang Shao [this message]
2020-05-21 8:58 ` Naresh Kamboju
2020-05-21 9:47 ` Yafang Shao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALOAHbDMrHkNHTxeBWP22iTjJd+HfqfFhAfmC_m0jsVkhu5vEA@mail.gmail.com \
--to=laoar.shao@gmail.com \
--cc=aarcange@redhat.com \
--cc=adilger.kernel@dilger.ca \
--cc=akpm@linux-foundation.org \
--cc=anders.roxell@linaro.org \
--cc=arnd@arndb.de \
--cc=cgroups@vger.kernel.org \
--cc=chris@chrisdown.name \
--cc=guro@fb.com \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=jaegeuk@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-next@vger.kernel.org \
--cc=lkft-triage@lists.linaro.org \
--cc=mhocko@kernel.org \
--cc=naresh.kamboju@linaro.org \
--cc=tytso@mit.edu \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).