From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 72CD9C76196 for ; Mon, 3 Apr 2023 17:02:01 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1pjNZ9-0005NC-Bn; Mon, 03 Apr 2023 17:01:59 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pjNZ8-0005N6-2c for linux-f2fs-devel@lists.sourceforge.net; Mon, 03 Apr 2023 17:01:58 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=/ml6DhA7MFIPfvbgzqwP5Zsbrsi7VVqPGk1OC+ZejbA=; b=h2wrc/5JnwD6b1/eBn0srq8dMy nMKB686EXUjMycPCArJFowaqJNe/z1tbuIsu/gLdVp2Knw8KWLLugHRdYa38YpOxrOV5JB6CZoQY/ d0nJoEcT8QU16p400/UxGC4Zpz8ipH1akoZity6exHrgsZUl/ZTbX88ipGsEUVGV+/8A=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=/ml6DhA7MFIPfvbgzqwP5Zsbrsi7VVqPGk1OC+ZejbA=; b=Mfdr3IKhrJ56yh/ehfhys5/XAC ntiGU1f/VP5NS10jkjFPylqlYKgMY8BL7B9Wep+fqwYzkM5TWVkAJuxylOXiXhm/x4IOQdwj8AWjl E2PvKxF9P+Aksvh05pYXabp7TvcvU0YRxe4j1QNF2xF/fVvD1A5RSIqFlCGhrEVSbFzc=; Received: from dfw.source.kernel.org ([139.178.84.217]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1pjNZ7-00Dv2v-2n for linux-f2fs-devel@lists.sourceforge.net; Mon, 03 Apr 2023 17:01:58 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id AD98E621FD; Mon, 3 Apr 2023 17:01:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F0BF2C433EF; Mon, 3 Apr 2023 17:01:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680541311; bh=uXrZJiH0Mtmp4FJT/dtY3hRjJPCArV5RlY1AapJidO4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GstMxDwBfLTP7CnUqQWzbmyCUD9N6dcIxML3Sg6jEvhiAWT9YVSneVEYe/x3D0W7O K0VEo4bibHaIHld938XOz5I5HsH9d6V+Q9GEwcvQnEYmTJeEUbMNtAx3SfQ2eh/NeB iE2fohoHYwlK6tk3uacoXObGvS+EPvefR6RYJoqfHZAWd4I4Lp9y9BY28haCMvRAIF vzrbXT5LPo2esg/IyE6RC1Z+fx5824Ln59xpb/pFxpx3G7J8fssie8Q/K1zR+KEc92 W68QNlW7VuL/7ZuujaHJ+0Zhu1Co0MaVDqLX+iE2cDwJxSiubNAZ5Zb0QZcgXtPj6b gwqmm+DytPBUQ== Date: Mon, 3 Apr 2023 10:01:49 -0700 From: Jaegeuk Kim To: Chao Yu Message-ID: References: <20230321001251epcms2p4c1fd48495643dbfca2cf82a433490bb8@epcms2p4> <48f18a16-c6d8-3df4-55c5-11546e7dde35@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <48f18a16-c6d8-3df4-55c5-11546e7dde35@kernel.org> X-Headers-End: 1pjNZ7-00Dv2v-2n Subject: Re: [f2fs-dev] [PATCH v2] f2fs: Fix system crash due to lack of free space in LFS X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "linux-kernel@vger.kernel.org" , "linux-f2fs-devel@lists.sourceforge.net" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 04/01, Chao Yu wrote: > On 2023/3/21 8:12, Yonggil Song wrote: > > When f2fs tries to checkpoint during foreground gc in LFS mode, system > > crash occurs due to lack of free space if the amount of dirty node and > > dentry pages generated by data migration exceeds free space. > > The reproduction sequence is as follows. > > > > - 20GiB capacity block device (null_blk) > > - format and mount with LFS mode > > - create a file and write 20,000MiB > > - 4k random write on full range of the file > > > > RIP: 0010:new_curseg+0x48a/0x510 [f2fs] > > Code: 55 e7 f5 89 c0 48 0f af c3 48 8b 5d c0 48 c1 e8 20 83 c0 01 89 43 6c 48 83 c4 28 5b 41 5c 41 5d 41 5e 41 5f 5d c3 cc cc cc cc <0f> 0b f0 41 80 4f 48 04 45 85 f6 0f 84 ba fd ff ff e9 ef fe ff ff > > RSP: 0018:ffff977bc397b218 EFLAGS: 00010246 > > RAX: 00000000000027b9 RBX: 0000000000000000 RCX: 00000000000027c0 > > RDX: 0000000000000000 RSI: 00000000000027b9 RDI: ffff8c25ab4e74f8 > > RBP: ffff977bc397b268 R08: 00000000000027b9 R09: ffff8c29e4a34b40 > > R10: 0000000000000001 R11: ffff977bc397b0d8 R12: 0000000000000000 > > R13: ffff8c25b4dd81a0 R14: 0000000000000000 R15: ffff8c2f667f9000 > > FS: 0000000000000000(0000) GS:ffff8c344ec80000(0000) knlGS:0000000000000000 > > CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > > CR2: 000000c00055d000 CR3: 0000000e30810003 CR4: 00000000003706e0 > > DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 > > DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 > > Call Trace: > > > > allocate_segment_by_default+0x9c/0x110 [f2fs] > > f2fs_allocate_data_block+0x243/0xa30 [f2fs] > > ? __mod_lruvec_page_state+0xa0/0x150 > > do_write_page+0x80/0x160 [f2fs] > > f2fs_do_write_node_page+0x32/0x50 [f2fs] > > __write_node_page+0x339/0x730 [f2fs] > > f2fs_sync_node_pages+0x5a6/0x780 [f2fs] > > block_operations+0x257/0x340 [f2fs] > > f2fs_write_checkpoint+0x102/0x1050 [f2fs] > > f2fs_gc+0x27c/0x630 [f2fs] > > ? folio_mark_dirty+0x36/0x70 > > f2fs_balance_fs+0x16f/0x180 [f2fs] > > > > This patch adds checking whether free sections are enough before checkpoint > > during gc. > > > > Signed-off-by: Yonggil Song > > --- > > fs/f2fs/gc.c | 10 ++++++++-- > > fs/f2fs/gc.h | 2 ++ > > fs/f2fs/segment.h | 27 ++++++++++++++++++++++----- > > 3 files changed, 32 insertions(+), 7 deletions(-) > > > > diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c > > index 4546e01b2ee0..dd563866d3c9 100644 > > --- a/fs/f2fs/gc.c > > +++ b/fs/f2fs/gc.c > > @@ -1773,6 +1773,7 @@ int f2fs_gc(struct f2fs_sb_info *sbi, struct f2fs_gc_control *gc_control) > > .iroot = RADIX_TREE_INIT(gc_list.iroot, GFP_NOFS), > > }; > > unsigned int skipped_round = 0, round = 0; > > + unsigned int need_lower = 0, need_upper = 0; > > trace_f2fs_gc_begin(sbi->sb, gc_type, gc_control->no_bg_gc, > > gc_control->nr_free_secs, > > @@ -1858,8 +1859,13 @@ int f2fs_gc(struct f2fs_sb_info *sbi, struct f2fs_gc_control *gc_control) > > } > > } > > - /* Write checkpoint to reclaim prefree segments */ > > - if (free_sections(sbi) < NR_CURSEG_PERSIST_TYPE && > > + ret = get_need_secs(sbi, &need_lower, &need_upper); > > Can we avoid calling has_curseg_enough_space() for this case? Why? :P > > Maybe we can add one parameter curseg_no_space for get_need_secs() to get > result of has_curseg_enough_space()? > > static inline void get_need_secs(struct f2fs_sb_info *sbi, > unsigned int *lower, unsigned int *upper, > bool *curseg_no_space); > { > ... > *lower = node_secs + dent_secs; > *upper = *lower + (node_blocks ? 1 : 0) + (dent_blocks ? 1 : 0); > > if (curseg_no_space) > *curseg_no_space = > !has_curseg_enough_space(sbi, node_blocks, dent_blocks); > } > > Then we can use get_need_secs(, , NULL) in f2fs_gc(), > and use get_need_secs(, , &curseg_no_space) in has_not_enough_free_secs()? > > Thoughts? > > Thanks, > > > + > > + /* > > + * Write checkpoint to reclaim prefree segments. > > + * We need more three extra sections for writer's data/node/dentry. > > + */ > > + if (free_sections(sbi) <= need_upper + NR_GC_CHECKPOINT_SECS && > > prefree_segments(sbi)) { > > ret = f2fs_write_checkpoint(sbi, &cpc); > > if (ret) > > diff --git a/fs/f2fs/gc.h b/fs/f2fs/gc.h > > index 19b956c2d697..e81d22bf3772 100644 > > --- a/fs/f2fs/gc.h > > +++ b/fs/f2fs/gc.h > > @@ -30,6 +30,8 @@ > > /* Search max. number of dirty segments to select a victim segment */ > > #define DEF_MAX_VICTIM_SEARCH 4096 /* covers 8GB */ > > +#define NR_GC_CHECKPOINT_SECS (3) /* data/node/dentry sections */ > > + > > struct f2fs_gc_kthread { > > struct task_struct *f2fs_gc_task; > > wait_queue_head_t gc_wait_queue_head; > > diff --git a/fs/f2fs/segment.h b/fs/f2fs/segment.h > > index be8f2d7d007b..52a6d1ed4f24 100644 > > --- a/fs/f2fs/segment.h > > +++ b/fs/f2fs/segment.h > > @@ -605,8 +605,12 @@ static inline bool has_curseg_enough_space(struct f2fs_sb_info *sbi, > > return true; > > } > > -static inline bool has_not_enough_free_secs(struct f2fs_sb_info *sbi, > > - int freed, int needed) > > +/* > > + * calculate needed sections for dirty node/dentry > > + * and call has_curseg_enough_space > > + */ > > +static inline bool get_need_secs(struct f2fs_sb_info *sbi, > > + unsigned int *lower, unsigned int *upper) > > { > > unsigned int total_node_blocks = get_pages(sbi, F2FS_DIRTY_NODES) + > > get_pages(sbi, F2FS_DIRTY_DENTS) + > > @@ -616,20 +620,33 @@ static inline bool has_not_enough_free_secs(struct f2fs_sb_info *sbi, > > unsigned int dent_secs = total_dent_blocks / CAP_BLKS_PER_SEC(sbi); > > unsigned int node_blocks = total_node_blocks % CAP_BLKS_PER_SEC(sbi); > > unsigned int dent_blocks = total_dent_blocks % CAP_BLKS_PER_SEC(sbi); > > + > > + *lower = node_secs + dent_secs; > > + *upper = *lower + (node_blocks ? 1 : 0) + (dent_blocks ? 1 : 0); > > + > > + return !has_curseg_enough_space(sbi, node_blocks, dent_blocks); > > +} > > + > > +static inline bool has_not_enough_free_secs(struct f2fs_sb_info *sbi, > > + int freed, int needed) > > +{ > > unsigned int free, need_lower, need_upper; > > + bool curseg_enough; > > if (unlikely(is_sbi_flag_set(sbi, SBI_POR_DOING))) > > return false; > > + curseg_enough = get_need_secs(sbi, &need_lower, &need_upper); > > + > > free = free_sections(sbi) + freed; > > - need_lower = node_secs + dent_secs + reserved_sections(sbi) + needed; > > - need_upper = need_lower + (node_blocks ? 1 : 0) + (dent_blocks ? 1 : 0); > > + need_lower += (needed + reserved_sections(sbi)); > > + need_upper += (needed + reserved_sections(sbi)); > > if (free > need_upper) > > return false; > > else if (free <= need_lower) > > return true; > > - return !has_curseg_enough_space(sbi, node_blocks, dent_blocks); > > + return curseg_enough; > > } > > static inline bool f2fs_is_checkpoint_ready(struct f2fs_sb_info *sbi) _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel