From: Chao Yu <chao@kernel.org>
To: Jaegeuk Kim <jaegeuk@kernel.org>,
linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net, kernel-team@android.com
Subject: Re: [f2fs-dev] [PATCH] f2fs: remove redundant check in f2fs_force_buffered_io
Date: Tue, 5 May 2020 09:58:50 +0800 [thread overview]
Message-ID: <b18c4be5-b56d-6b6e-3f99-d2fe05d330eb@kernel.org> (raw)
In-Reply-To: <20200504143538.159967-1-jaegeuk@kernel.org>
On 2020-5-4 22:35, Jaegeuk Kim wrote:
> From: Daeho Jeong <daehojeong@google.com>
>
> We already checked whether the file is compressed or not in
> f2fs_post_read_required(). So removed f2fs_compressed_file()
> in f2fs_force_buffered_io().
Agreed, since I have sent similar patch before:
https://lkml.org/lkml/2020/3/24/1819
Just want to know what's the change of backport concern now.
Thanks,
>
> Signed-off-by: Daeho Jeong <daehojeong@google.com>
> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
> ---
> fs/f2fs/f2fs.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
> index 6b7b963641696..01a00fc808361 100644
> --- a/fs/f2fs/f2fs.h
> +++ b/fs/f2fs/f2fs.h
> @@ -4064,8 +4064,6 @@ static inline bool f2fs_force_buffered_io(struct inode *inode,
> return true;
> if (f2fs_is_multi_device(sbi))
> return true;
> - if (f2fs_compressed_file(inode))
> - return true;
> /*
> * for blkzoned device, fallback direct IO to buffered IO, so
> * all IOs can be serialized by log-structured write.
>
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2020-05-05 1:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-04 14:35 [f2fs-dev] [PATCH] f2fs: remove redundant check in f2fs_force_buffered_io Jaegeuk Kim
2020-05-05 1:58 ` Chao Yu [this message]
2020-05-05 3:23 ` Jaegeuk Kim
2020-05-06 6:48 ` Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b18c4be5-b56d-6b6e-3f99-d2fe05d330eb@kernel.org \
--to=chao@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=kernel-team@android.com \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).