Re: [f2fs-dev] [PATCH v2] f2fs: correct statistic of APP_DIRECT_IO/APP_DIRECT_READ_IO

Re: [f2fs-dev] [PATCH v2] f2fs: correct statistic of APP_DIRECT_IO/APP_DIRECT_READ_IO

[Chao Yu]

On 2020/8/31 9:58, Jack Qiu wrote:
> Miss to update APP_DIRECT_IO/APP_DIRECT_READ_IO when receiving async DIO.
> For example: fio -filename=/data/test.0 -bs=1m -ioengine=libaio -direct=1
> 		-name=fill -size=10m -numjobs=1 -iodepth=32 -rw=write
> 
> Signed-off-by: Jack Qiu <jack.qiu@huawei.com>

Reviewed-by: Chao Yu <yuchao0@huawei.com>

Thanks,


_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

[f2fs-dev] [PATCH v2] f2fs: correct statistic of APP_DIRECT_IO/APP_DIRECT_READ_IO

[Jack Qiu]

Miss to update APP_DIRECT_IO/APP_DIRECT_READ_IO when receiving async DIO.
For example: fio -filename=/data/test.0 -bs=1m -ioengine=libaio -direct=1
		-name=fill -size=10m -numjobs=1 -iodepth=32 -rw=write

Signed-off-by: Jack Qiu <jack.qiu@huawei.com>
---
 fs/f2fs/data.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
index a19e2a7891f3..239645433e0e 100644
--- a/fs/f2fs/data.c
+++ b/fs/f2fs/data.c
@@ -3671,12 +3671,18 @@ static ssize_t f2fs_direct_IO(struct kiocb *iocb, struct iov_iter *iter)
 									err);
 			if (!do_opu)
 				set_inode_flag(inode, FI_UPDATE_WRITE);
+		} else if (err == -EIOCBQUEUED) {
+			f2fs_update_iostat(F2FS_I_SB(inode), APP_DIRECT_IO,
+						count - iov_iter_count(iter));
 		} else if (err < 0) {
 			f2fs_write_failed(mapping, offset + count);
 		}
 	} else {
 		if (err > 0)
 			f2fs_update_iostat(sbi, APP_DIRECT_READ_IO, err);
+		else if (err == -EIOCBQUEUED)
+			f2fs_update_iostat(F2FS_I_SB(inode), APP_DIRECT_READ_IO,
+						count - iov_iter_count(iter));
 	}

 out:
--
2.17.1



_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel