From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A77BC0650F for ; Tue, 6 Aug 2019 01:42:27 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CF1F920C01; Tue, 6 Aug 2019 01:42:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sourceforge.net header.i=@sourceforge.net header.b="iqbASl1T"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sf.net header.i=@sf.net header.b="Ya9mIIiT" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CF1F920C01 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1huoUc-0000aI-Ep; Tue, 06 Aug 2019 01:42:26 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1huoUb-0000aB-CF for linux-f2fs-devel@lists.sourceforge.net; Tue, 06 Aug 2019 01:42:25 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:CC:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=WTaBuDVqnmY3BEPCPi2XyfBJHhOyKESztRJP15rIGoU=; b=iqbASl1TyRXKf6AWitQGXiK7rz lQVnbXGXIn/8zweE9h7qBiwC/sQx47rkgxx0WUHHP+Pc930Vq1V1a7XbAGCQBMexx+nW9leDKdd+B zSUMNozBgd2RwYxW9vv3wNkB4OcWk9tx7jsfSfJGsmb9Rn9mR9SD9Q+WJWSCJnrLL7RA=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:From:References:CC:To:Subject:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=WTaBuDVqnmY3BEPCPi2XyfBJHhOyKESztRJP15rIGoU=; b=Ya9mIIiTf9+upg8FtR8hwFJ66h fFtReZEVrAYSAMx/JHuZkyjMQc8WuZr3NUCqEoXMrXftSSYsINbUvujJBKUC4+/WNjlyFFs6ffloF F1UTcO3RBA3JGkHs3YDZGqitq8m8/kx1ciQGou6YUA+zxlRbKFYC0WJNvvkaGqOfCeE8=; Received: from szxga07-in.huawei.com ([45.249.212.35] helo=huawei.com) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) id 1huoUZ-00CMe5-OF for linux-f2fs-devel@lists.sourceforge.net; Tue, 06 Aug 2019 01:42:25 +0000 Received: from DGGEMS403-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id C005B14AC473876108DB; Tue, 6 Aug 2019 09:42:16 +0800 (CST) Received: from [10.134.22.195] (10.134.22.195) by smtp.huawei.com (10.3.19.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 6 Aug 2019 09:42:13 +0800 To: Jaegeuk Kim References: <20181002020223.76087-1-jaegeuk@kernel.org> <20190806004742.GD98101@jaegeuk-macbookpro.roam.corp.google.com> From: Chao Yu Message-ID: Date: Tue, 6 Aug 2019 09:42:43 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190806004742.GD98101@jaegeuk-macbookpro.roam.corp.google.com> Content-Language: en-US X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected X-Headers-End: 1huoUZ-00CMe5-OF Subject: Re: [f2fs-dev] [PATCH] fsck.f2fs: don't allocate new blocks on unclean shutdown X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 2019/8/6 8:47, Jaegeuk Kim wrote: > On 08/05, Chao Yu wrote: >> Hi Jaegeuk, >> >> On 2018/10/2 10:02, Jaegeuk Kim wrote: >>> + if (!is_set_ckpt_flags(cp, CP_UMOUNT_FLAG)) { >>> + c.alloc_failed = 1; >>> + return -EINVAL; >>> + } >> >> When I test por_fsstress case w/ quota feature enabled, I suffer below error >> during repair: >> >> Info: superblock features = f8 : extra_attr project_quota inode_checksum >> flexible_inline_xattr quota_ino >> Info: superblock encrypt level = 0, salt = 00000000000000000000000000000000 >> Info: total FS sectors = 2097152 (8192 MB) >> Info: CKPT version = 452b7568 >> Info: checkpoint state = 846 : quota_need_fsck crc compacted_summary >> orphan_inodes sudden-power-off >> [fsck_chk_quota_files:1784] Fixing Quota file ([ 0] ino [0x4]) >> [ERROR] quotaio_tree.c:83:write_blk:: Cannot write block (7188): Inappropriate >> ioctl for device >> [ERROR] quotaio_tree.c:110:get_free_dqblk:: Cannot allocate new quota block (out >> of disk space). >> >> I found new_data_block() will reject block allocation on an unclean umounted >> image, result in quota file repair failure. >> >> With current implementation, I think we should mount that image again for >> recovery, then umount and run fsck on it again to repair quota file. > > Yes. > >> >> However, user didn't be noticed that how to fix this... I know there is no such >> report tho, I think we'd better fix this case in fsck, any thoughts? let >> allocation skip fsynced datas? > > Actually, that was my TODO, but I had no time to fix it, but had to stop it to > avoid further corruption. Copied, maybe I can help to fix it. It looks it will be easy to skip fsyned datas during block allocation than porting recovery flow from kernel to tools. Thanks, > >> >> Thanks, > . > _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel