From: Chao Yu <yuchao0@huawei.com>
To: Jaegeuk Kim <jaegeuk@kernel.org>,
<linux-f2fs-devel@lists.sourceforge.net>
Subject: Re: [f2fs-dev] [PATCH] fsck.f2fs: don't allocate new blocks on unclean shutdown
Date: Mon, 5 Aug 2019 17:13:47 +0800 [thread overview]
Message-ID: <bece1226-ae59-d9be-a5b0-be836ba04e69@huawei.com> (raw)
In-Reply-To: <20181002020223.76087-1-jaegeuk@kernel.org>
Hi Jaegeuk,
On 2018/10/2 10:02, Jaegeuk Kim wrote:
> + if (!is_set_ckpt_flags(cp, CP_UMOUNT_FLAG)) {
> + c.alloc_failed = 1;
> + return -EINVAL;
> + }
When I test por_fsstress case w/ quota feature enabled, I suffer below error
during repair:
Info: superblock features = f8 : extra_attr project_quota inode_checksum
flexible_inline_xattr quota_ino
Info: superblock encrypt level = 0, salt = 00000000000000000000000000000000
Info: total FS sectors = 2097152 (8192 MB)
Info: CKPT version = 452b7568
Info: checkpoint state = 846 : quota_need_fsck crc compacted_summary
orphan_inodes sudden-power-off
[fsck_chk_quota_files:1784] Fixing Quota file ([ 0] ino [0x4])
[ERROR] quotaio_tree.c:83:write_blk:: Cannot write block (7188): Inappropriate
ioctl for device
[ERROR] quotaio_tree.c:110:get_free_dqblk:: Cannot allocate new quota block (out
of disk space).
I found new_data_block() will reject block allocation on an unclean umounted
image, result in quota file repair failure.
With current implementation, I think we should mount that image again for
recovery, then umount and run fsck on it again to repair quota file.
However, user didn't be noticed that how to fix this... I know there is no such
report tho, I think we'd better fix this case in fsck, any thoughts? let
allocation skip fsynced datas?
Thanks,
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2019-08-05 9:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-02 2:02 [PATCH] fsck.f2fs: don't allocate new blocks on unclean shutdown Jaegeuk Kim
2019-08-05 9:13 ` Chao Yu [this message]
2019-08-06 0:47 ` [f2fs-dev] " Jaegeuk Kim
2019-08-06 1:42 ` Chao Yu
2019-08-06 2:12 ` Jaegeuk Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bece1226-ae59-d9be-a5b0-be836ba04e69@huawei.com \
--to=yuchao0@huawei.com \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).