From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51E13C433E2 for ; Fri, 17 Jul 2020 02:47:21 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2351B20838; Fri, 17 Jul 2020 02:47:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sourceforge.net header.i=@sourceforge.net header.b="VLInkEcq"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sf.net header.i=@sf.net header.b="L+FB+MnZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2351B20838 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=bugzilla.kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1jwGPA-0006Bv-Og; Fri, 17 Jul 2020 02:47:20 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jwGP9-0006Bn-EN for linux-f2fs-devel@lists.sourceforge.net; Fri, 17 Jul 2020 02:47:19 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=MIME-Version:Content-Transfer-Encoding:Content-Type :References:In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=iudcMh9Avj4OdY3Nb8+oUD+VXJiF9JuvZUyrKO6ORog=; b=VLInkEcq9DqDT1a4fgCL4q7PMi MDc956z7om9OOloj4LS/LktzqGIm49qvoQBZ2v+H5Y0EgLlD7zrY+okHDxYQJuRAjrIUOLFJJaGiO HW6AqhTjFdDTvJQo9zIHy+sLU3mA5hEzHDK/JpvqTS413UDSOh+iuNjCXe0kz/50A46g=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=MIME-Version:Content-Transfer-Encoding:Content-Type:References: In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=iudcMh9Avj4OdY3Nb8+oUD+VXJiF9JuvZUyrKO6ORog=; b=L+FB+MnZrwnZCubbR/fI8l4P9+ H7afJNNtWKuIvWrw/LcVmzrs+IFP+DgMge6keGekOGxV5VNVSzBN6ErHaa4FPdvJI2M8pJSfrk+jo gW4wuqpAZ8rejS2KtLEOwJuKxHlS1GWs/2oUIIwXtBAQ0sIVefWvKkC2/g//fUFt1vmc=; Received: from mail.kernel.org ([198.145.29.99]) by sfi-mx-4.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1jwGP7-006oCq-IC for linux-f2fs-devel@lists.sourceforge.net; Fri, 17 Jul 2020 02:47:19 +0000 From: bugzilla-daemon@bugzilla.kernel.org To: linux-f2fs-devel@lists.sourceforge.net Date: Fri, 17 Jul 2020 02:47:12 +0000 X-Bugzilla-Reason: None X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: AssignedTo filesystem_f2fs@kernel-bugs.kernel.org X-Bugzilla-Product: File System X-Bugzilla-Component: f2fs X-Bugzilla-Version: 2.5 X-Bugzilla-Keywords: X-Bugzilla-Severity: high X-Bugzilla-Who: Zhiguo.Niu@unisoc.com X-Bugzilla-Status: ASSIGNED X-Bugzilla-Resolution: X-Bugzilla-Priority: P1 X-Bugzilla-Assigned-To: filesystem_f2fs@kernel-bugs.kernel.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: X-Bugzilla-URL: https://bugzilla.kernel.org/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-Headers-End: 1jwGP7-006oCq-IC Subject: [f2fs-dev] [Bug 208565] There may be dead lock for cp_rwsem during checkpoint X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net https://bugzilla.kernel.org/show_bug.cgi?id=208565 --- Comment #5 from Zhiguo.Niu (Zhiguo.Niu@unisoc.com) --- (In reply to Jaegeuk Kim from comment #1) > Thank you for the report. > > I think this is valid point that we need to fix. > I'm testing a RFC patch like this. Thanks. > > --- a/fs/f2fs/node.c > +++ b/fs/f2fs/node.c > @@ -1926,8 +1926,12 @@ int f2fs_sync_node_pages(struct f2fs_sb_info *sbi, > goto continue_unlock; > } > > - /* flush inline_data, if it's async context. */ > - if (do_balance && is_inline_node(page)) { > + /* flush inline_data/inode, if it's async context. */ > + if (!do_balance) > + goto write_node; > + > + /* flush inline_data */ > + if (is_inline_node(page)) { > clear_inline_node(page); > unlock_page(page); > flush_inline_data(sbi, ino_of_node(page)); > @@ -1940,7 +1944,7 @@ int f2fs_sync_node_pages(struct f2fs_sb_info *sbi, > if (flush_dirty_inode(page)) > goto lock_node; > } > - > +write_node: > f2fs_wait_on_page_writeback(page, NODE, true, true); > > if (!clear_page_dirty_for_io(page)) Hi Jaegeuk Kim for comment 1, can you help provide a full diff for this patch, I can not apply it directly because of the following error: > fatal: patch fragment without header at line 3: @@ -1926,8 +1926,12 @@ int > f2fs_sync_node_pages(struct f2fs_sb_info *sbi, or Should I merge it by Manually? thanks a lot~ -- You are receiving this mail because: You are watching the assignee of the bug. _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel