From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A191C433E1 for ; Sat, 25 Jul 2020 01:24:53 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8BC4C2067D; Sat, 25 Jul 2020 01:24:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sourceforge.net header.i=@sourceforge.net header.b="VYzSj9gc"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sf.net header.i=@sf.net header.b="llTCicry" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8BC4C2067D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1jz8vk-0005H1-0V; Sat, 25 Jul 2020 01:24:52 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jz8vj-0005Gu-2D for linux-f2fs-devel@lists.sourceforge.net; Sat, 25 Jul 2020 01:24:51 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:To:Subject:Sender:Reply-To:Cc: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=GKTiIpdMKQVzuDzQClcnNXxOcoc1fsWBrlfVDQNzKT4=; b=VYzSj9gcDy9DcV86H6m/Jx9HsZ 7ZzjLNSs5iKwVQ+Y19ufhwxIfZXvXXJXAnw4FdCvIWWV3RV4dMd30ToTBAyYtcjuHNpElCyAAtMPw 7qPyTbIE9jJRYKvpH8oiJyX2UmeNCDo79J48ouogAV9AtVDrPTJyQ6nPKOhWliWvL49c=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Sender:Reply-To:Cc:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=GKTiIpdMKQVzuDzQClcnNXxOcoc1fsWBrlfVDQNzKT4=; b=llTCicryuuTgxFDG4u55A0w4+c b6Z9ivo1KIZyqZrjfwUZpV2Oghh7K7A+OLAvVTFhkvX3o8Rcv+FU9L0Hjhpnjh0+Sty2NXwXAvlF1 v2R7WAAOXTgEw1Tlo8GlRCJ+b1ig88CBDjROGeL3zrXKWcyPmyMSAtnq/+2oASu8mbMQ=; Received: from szxga04-in.huawei.com ([45.249.212.190] helo=huawei.com) by sfi-mx-3.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1jz8vh-00GTnF-Ji for linux-f2fs-devel@lists.sourceforge.net; Sat, 25 Jul 2020 01:24:50 +0000 Received: from DGGEMS413-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 494E489B49F5EB2E533F for ; Sat, 25 Jul 2020 09:24:42 +0800 (CST) Received: from [10.164.122.247] (10.164.122.247) by smtp.huawei.com (10.3.19.213) with Microsoft SMTP Server (TLS) id 14.3.487.0; Sat, 25 Jul 2020 09:24:33 +0800 To: Jack Qiu , References: <20200725014952.19036-1-jack.qiu@huawei.com> From: Chao Yu Message-ID: Date: Sat, 25 Jul 2020 09:24:33 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20200725014952.19036-1-jack.qiu@huawei.com> Content-Language: en-US X-Originating-IP: [10.164.122.247] X-CFilter-Loop: Reflected X-Headers-End: 1jz8vh-00GTnF-Ji Subject: Re: [f2fs-dev] [PATCH] f2fs: use kfree() to free sbi->gc_thread allocated by f2fs_kmalloc X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net Hello, Let's check and do conversion for all possible cases rather than do one by one. On 2020/7/25 9:49, Jack Qiu wrote: > Use kfree() instead of kvfree() to free sbi->gc_thread allocated > by f2fs_kmalloc(). Because the memory is allocated with kmalloc > inside f2fs_kmalloc(). > > Signed-off-by: Jack Qiu > --- > fs/f2fs/gc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c > index 5b95d5a146eb..696ceeedc76d 100644 > --- a/fs/f2fs/gc.c > +++ b/fs/f2fs/gc.c > @@ -147,7 +147,7 @@ int f2fs_start_gc_thread(struct f2fs_sb_info *sbi) > "f2fs_gc-%u:%u", MAJOR(dev), MINOR(dev)); > if (IS_ERR(gc_th->f2fs_gc_task)) { > err = PTR_ERR(gc_th->f2fs_gc_task); > - kvfree(gc_th); > + kfree(gc_th); > sbi->gc_thread = NULL; > } > out: > @@ -160,7 +160,7 @@ void f2fs_stop_gc_thread(struct f2fs_sb_info *sbi) > if (!gc_th) > return; > kthread_stop(gc_th->f2fs_gc_task); > - kvfree(gc_th); > + kfree(gc_th); > sbi->gc_thread = NULL; > } > > -- > 2.17.1 > > > > _______________________________________________ > Linux-f2fs-devel mailing list > Linux-f2fs-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel > . > _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel