Linux-f2fs-devel Archive on lore.kernel.org
 help / color / Atom feed
* Re: [f2fs-dev] [PATCH] f2fs: compress: Avoid memory leak on cc->cpages
@ 2020-07-20 11:31 Markus Elfring
  2020-07-20 12:38 ` Chao Yu
  0 siblings, 1 reply; 3+ messages in thread
From: Markus Elfring @ 2020-07-20 11:31 UTC (permalink / raw)
  To: Chao Yu, linux-f2fs-devel; +Cc: Jaegeuk Kim, linux-kernel

> Memory allocated for storing compressed pages' poitner should be
> released after f2fs_write_compressed_pages(), otherwise it will
> cause memory leak issue.

* Would an imperative wording be more appropriate (without a typo)
  for the change description?

* Will the tag “Fixes” become helpful for the commit message?

Regards,
Markus


_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [f2fs-dev] [PATCH] f2fs: compress: Avoid memory leak on cc->cpages
  2020-07-20 11:31 [f2fs-dev] [PATCH] f2fs: compress: Avoid memory leak on cc->cpages Markus Elfring
@ 2020-07-20 12:38 ` Chao Yu
  2020-07-20 12:49   ` Markus Elfring
  0 siblings, 1 reply; 3+ messages in thread
From: Chao Yu @ 2020-07-20 12:38 UTC (permalink / raw)
  To: Markus Elfring, linux-f2fs-devel; +Cc: Jaegeuk Kim, linux-kernel

On 2020/7/20 19:31, Markus Elfring wrote:
>> Memory allocated for storing compressed pages' poitner should be
>> released after f2fs_write_compressed_pages(), otherwise it will
>> cause memory leak issue.
> 
> * Would an imperative wording be more appropriate (without a typo)
>    for the change description?
> 
> * Will the tag “Fixes” become helpful for the commit message?

It looks this is replied from patch-robot? since I found all comments
you replied are almost the same.

And what's funny is that the reply starts being caught by another patch-bot
from Greg...

https://lkml.org/lkml/2020/6/28/157

> 
> Regards,
> Markus
> .
> 


_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [f2fs-dev] [PATCH] f2fs: compress: Avoid memory leak on cc->cpages
  2020-07-20 12:38 ` Chao Yu
@ 2020-07-20 12:49   ` Markus Elfring
  0 siblings, 0 replies; 3+ messages in thread
From: Markus Elfring @ 2020-07-20 12:49 UTC (permalink / raw)
  To: Chao Yu, linux-f2fs-devel; +Cc: Jaegeuk Kim, linux-kernel

>>> Memory allocated for storing compressed pages' poitner should be
>>> released after f2fs_write_compressed_pages(), otherwise it will
>>> cause memory leak issue.
>>
>> * Would an imperative wording be more appropriate (without a typo)
>>   for the change description?
>>
>> * Will the tag “Fixes” become helpful for the commit message?
>
> It looks this is replied from patch-robot? since I found all comments
> you replied are almost the same.

I dare to repeat such suggestions because several patches contain
improvable details (not only in the affected source code).

Regards,
Markus


_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-20 11:31 [f2fs-dev] [PATCH] f2fs: compress: Avoid memory leak on cc->cpages Markus Elfring
2020-07-20 12:38 ` Chao Yu
2020-07-20 12:49   ` Markus Elfring

Linux-f2fs-devel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-f2fs-devel/0 linux-f2fs-devel/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-f2fs-devel linux-f2fs-devel/ https://lore.kernel.org/linux-f2fs-devel \
		linux-f2fs-devel@lists.sourceforge.net
	public-inbox-index linux-f2fs-devel

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/net.sourceforge.lists.linux-f2fs-devel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git