From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DF0AC76188 for ; Tue, 23 Jul 2019 07:08:43 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2E90A2238C for ; Tue, 23 Jul 2019 07:08:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sourceforge.net header.i=@sourceforge.net header.b="avNBcn18"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sf.net header.i=@sf.net header.b="Iu/PRfd0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2E90A2238C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1hpoug-0000U1-Jb; Tue, 23 Jul 2019 07:08:42 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1hpoug-0000TV-6M for linux-f2fs-devel@lists.sourceforge.net; Tue, 23 Jul 2019 07:08:42 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:CC:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=RAY+2NLyLsqLHjyQNoweXgQy1XXtCG4cnSLKmDKMccE=; b=avNBcn182HYalFup0Fa67AsdFy BaNoK2mgT7utc/o9NS/hcR7LgIp5FLI0YV2tvlPJgrQ1N7c7BD09HkIR9/q0u5CSMLcTm8GC+og32 AA1p9++O85SVXZCzOclnJXSNmWdCSgrsm5eDU4tIysEjOulUWjkOixKJArG8PZZES9m4=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:From:References:CC:To:Subject:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=RAY+2NLyLsqLHjyQNoweXgQy1XXtCG4cnSLKmDKMccE=; b=Iu/PRfd0oB501z/JLdWjroxbh0 JSPjMkLqG5IGiwmoOaF8j4CA0elxUAX2cFygBjvpxkd5OcmjfBxMrmP6DeAMkNdsV1DBoHIhjdB/T J5GoZ+Pezrrn5O+GrGAtrD7oJNWsNqKB3Nyl2sdGKOFh4JiHSO1F4j9Hye0zEB4cCpy4=; Received: from szxga04-in.huawei.com ([45.249.212.190] helo=huawei.com) by sfi-mx-4.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) id 1hpoue-00BkdP-GH for linux-f2fs-devel@lists.sourceforge.net; Tue, 23 Jul 2019 07:08:42 +0000 Received: from DGGEMS413-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id DEDB7EC9961CF990575B; Tue, 23 Jul 2019 15:08:32 +0800 (CST) Received: from [10.134.22.195] (10.134.22.195) by smtp.huawei.com (10.3.19.213) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 23 Jul 2019 15:08:28 +0800 To: Jaegeuk Kim References: <20190719073903.9138-1-yuchao0@huawei.com> <20190723023640.GC60778@jaegeuk-macbookpro.roam.corp.google.com> From: Chao Yu Message-ID: Date: Tue, 23 Jul 2019 15:08:28 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190723023640.GC60778@jaegeuk-macbookpro.roam.corp.google.com> Content-Language: en-US X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected X-Headers-End: 1hpoue-00BkdP-GH Subject: Re: [f2fs-dev] [PATCH v2] f2fs: separate NOCoW and pinfile semantics X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 2019/7/23 10:36, Jaegeuk Kim wrote: > On 07/19, Chao Yu wrote: >> Pinning a file is heavy, because skipping pinned files make GC >> running with heavy load or no effect. > > Pinned file is a part of NOCOW files, so I don't think we can simply drop it > for backward compatibility. Yes, But what I concerned is that pin file is too heavy, so in order to satisfy below demand, how about introducing pin_file_2 flag to triggering IPU only during flush/writeback. > >> >> So that this patch propose to separate nocow and pinfile semantics: >> - NOCoW flag can only be set on regular file. >> - NOCoW file will only trigger IPU at common writeback/flush. >> - NOCow file will do OPU during GC. >> >> For the demand of 1) avoid fragment of file's physical block and >> 2) userspace don't care about file's specific physical address, >> tagging file as NOCoW will be cheaper than pinned one. ^^^ Thanks, >> >> Signed-off-by: Chao Yu >> --- >> v2: >> - rebase code to fix compile error. >> fs/f2fs/data.c | 3 ++- >> fs/f2fs/f2fs.h | 1 + >> fs/f2fs/file.c | 22 +++++++++++++++++++--- >> 3 files changed, 22 insertions(+), 4 deletions(-) >> >> diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c >> index a2a28bb269bf..15fb8954c363 100644 >> --- a/fs/f2fs/data.c >> +++ b/fs/f2fs/data.c >> @@ -1884,7 +1884,8 @@ static inline bool check_inplace_update_policy(struct inode *inode, >> >> bool f2fs_should_update_inplace(struct inode *inode, struct f2fs_io_info *fio) >> { >> - if (f2fs_is_pinned_file(inode)) >> + if (f2fs_is_pinned_file(inode) || >> + F2FS_I(inode)->i_flags & F2FS_NOCOW_FL) >> return true; >> >> /* if this is cold file, we should overwrite to avoid fragmentation */ >> diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h >> index 596ab3e1dd7b..f6c5a3d2e659 100644 >> --- a/fs/f2fs/f2fs.h >> +++ b/fs/f2fs/f2fs.h >> @@ -2374,6 +2374,7 @@ static inline void f2fs_change_bit(unsigned int nr, char *addr) >> #define F2FS_NOATIME_FL 0x00000080 /* do not update atime */ >> #define F2FS_INDEX_FL 0x00001000 /* hash-indexed directory */ >> #define F2FS_DIRSYNC_FL 0x00010000 /* dirsync behaviour (directories only) */ >> +#define F2FS_NOCOW_FL 0x00800000 /* Do not cow file */ >> #define F2FS_PROJINHERIT_FL 0x20000000 /* Create with parents projid */ >> >> /* Flags that should be inherited by new inodes from their parent. */ >> diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c >> index 7ca545874060..ae0fec54cac6 100644 >> --- a/fs/f2fs/file.c >> +++ b/fs/f2fs/file.c >> @@ -1692,6 +1692,7 @@ static const struct { >> { F2FS_NOATIME_FL, FS_NOATIME_FL }, >> { F2FS_INDEX_FL, FS_INDEX_FL }, >> { F2FS_DIRSYNC_FL, FS_DIRSYNC_FL }, >> + { F2FS_NOCOW_FL, FS_NOCOW_FL }, >> { F2FS_PROJINHERIT_FL, FS_PROJINHERIT_FL }, >> }; >> >> @@ -1715,7 +1716,8 @@ static const struct { >> FS_NODUMP_FL | \ >> FS_NOATIME_FL | \ >> FS_DIRSYNC_FL | \ >> - FS_PROJINHERIT_FL) >> + FS_PROJINHERIT_FL | \ >> + FS_NOCOW_FL) >> >> /* Convert f2fs on-disk i_flags to FS_IOC_{GET,SET}FLAGS flags */ >> static inline u32 f2fs_iflags_to_fsflags(u32 iflags) >> @@ -1753,8 +1755,6 @@ static int f2fs_ioc_getflags(struct file *filp, unsigned long arg) >> fsflags |= FS_ENCRYPT_FL; >> if (f2fs_has_inline_data(inode) || f2fs_has_inline_dentry(inode)) >> fsflags |= FS_INLINE_DATA_FL; >> - if (is_inode_flag_set(inode, FI_PIN_FILE)) >> - fsflags |= FS_NOCOW_FL; >> >> fsflags &= F2FS_GETTABLE_FS_FL; >> >> @@ -1794,6 +1794,22 @@ static int f2fs_ioc_setflags(struct file *filp, unsigned long arg) >> if (ret) >> goto out; >> >> + if ((fsflags ^ old_fsflags) & FS_NOCOW_FL) { >> + if (!S_ISREG(inode->i_mode)) { >> + ret = -EINVAL; >> + goto out; >> + } >> + >> + if (f2fs_should_update_outplace(inode, NULL)) { >> + ret = -EINVAL; >> + goto out; >> + } >> + >> + ret = f2fs_convert_inline_inode(inode); >> + if (ret) >> + goto out; >> + } >> + >> ret = f2fs_setflags_common(inode, iflags, >> f2fs_fsflags_to_iflags(F2FS_SETTABLE_FS_FL)); >> out: >> -- >> 2.18.0.rc1 > . > _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel