From: Chao Yu <yuchao0@huawei.com>
To: Zhang Xiaoxu <zhangxiaoxu5@huawei.com>, <jaegeuk@kernel.org>,
<chao@kernel.org>
Cc: linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH] f2fs: Make f2fs_verify_pages static
Date: Wed, 15 Jan 2020 17:59:38 +0800 [thread overview]
Message-ID: <dcdba6c2-7ad1-86ae-c5d8-7ad0ee8ea3b2@huawei.com> (raw)
In-Reply-To: <20200115015424.41496-1-zhangxiaoxu5@huawei.com>
Hi Xiaoxu,
On 2020/1/15 9:54, Zhang Xiaoxu wrote:
> Fix sparse warning:
>
> fs/f2fs/data.c:187:6: warning:
> symbol 'f2fs_verify_pages' was not declared. Should it be static?
Thanks for your patch.
It will be better to merge this patch into original patch which is
still on dev status, let us know if you have any other concern. :)
Thanks,
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zhang Xiaoxu <zhangxiaoxu5@huawei.com>
> ---
> fs/f2fs/data.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
> index 2576d7dd047d..b27b72107911 100644
> --- a/fs/f2fs/data.c
> +++ b/fs/f2fs/data.c
> @@ -184,7 +184,7 @@ static void f2fs_decompress_work(struct bio_post_read_ctx *ctx)
> }
>
> #ifdef CONFIG_F2FS_FS_COMPRESSION
> -void f2fs_verify_pages(struct page **rpages, unsigned int cluster_size)
> +static void f2fs_verify_pages(struct page **rpages, unsigned int cluster_size)
> {
> f2fs_decompress_end_io(rpages, cluster_size, false, true);
> }
>
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2020-01-15 10:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-15 1:54 [f2fs-dev] [PATCH] f2fs: Make f2fs_verify_pages static Zhang Xiaoxu
2020-01-15 9:59 ` Chao Yu [this message]
2020-01-15 21:40 ` Jaegeuk Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dcdba6c2-7ad1-86ae-c5d8-7ad0ee8ea3b2@huawei.com \
--to=yuchao0@huawei.com \
--cc=chao@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=zhangxiaoxu5@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).