From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9046CC433FF for ; Mon, 12 Aug 2019 12:25:47 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5D2F221744; Mon, 12 Aug 2019 12:25:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sourceforge.net header.i=@sourceforge.net header.b="PySkAC7n"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sf.net header.i=@sf.net header.b="RwT9K97a" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5D2F221744 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1hx9OU-00062A-Tv; Mon, 12 Aug 2019 12:25:46 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1hx9OT-00061x-TK for linux-f2fs-devel@lists.sourceforge.net; Mon, 12 Aug 2019 12:25:45 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:CC:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=v9h8zDmXRL44PP4nNb5ec9pUhUy19aNCbVN0jo3tJOA=; b=PySkAC7nMrifsEy6DrK0H4KkME DF6qIjJTNiFzgepV+Z9I7yDNIKVFg2BQyFcqj07K9MHRRBXJ1hG4PpJybrN09+QgpoiVA7z4ohmff EF9YThUVmsHCOI208voKye81HEZmw0y/zz9Xs0HchOPZONGgxlzxVzCmhYSXn6Y27tJ4=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:From:References:CC:To:Subject:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=v9h8zDmXRL44PP4nNb5ec9pUhUy19aNCbVN0jo3tJOA=; b=RwT9K97abOGDCZWfn9deUMOXdO iRHsT2kokdUTRs7fRltQihUPEe1BjzxlkGtPcuCZ+o2rsbzUo1vIN8DN8cFu+FUpL70s5VCp3Vil/ mkWQKYnz1j00mb09NULafe0SRDJg1RDfPFfCRzpnhRDLvW7umlgFrZ0WDyc4KKkJcj7o=; Received: from szxga04-in.huawei.com ([45.249.212.190] helo=huawei.com) by sfi-mx-4.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) id 1hx9OR-000eH1-Tn for linux-f2fs-devel@lists.sourceforge.net; Mon, 12 Aug 2019 12:25:45 +0000 Received: from DGGEMS411-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 270DCE2238499EAB75AB; Mon, 12 Aug 2019 20:25:37 +0800 (CST) Received: from [10.134.22.195] (10.134.22.195) by smtp.huawei.com (10.3.19.211) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 12 Aug 2019 20:25:32 +0800 To: Eric Biggers , References: <20190811213557.1970-1-ebiggers@kernel.org> <20190811213557.1970-4-ebiggers@kernel.org> From: Chao Yu Message-ID: Date: Mon, 12 Aug 2019 20:25:33 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190811213557.1970-4-ebiggers@kernel.org> Content-Language: en-US X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected X-Headers-End: 1hx9OR-000eH1-Tn Subject: Re: [f2fs-dev] [PATCH 3/6] f2fs: skip truncate when verity in progress in ->write_begin() X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net Hi Eric, On 2019/8/12 5:35, Eric Biggers wrote: > From: Eric Biggers > > When an error (e.g. ENOSPC) occurs during f2fs_write_begin() when called > from f2fs_write_merkle_tree_block(), skip truncating the file. i_size > is not meaningful in this case, and the truncation is handled by > f2fs_end_enable_verity() instead. > > Fixes: 60d7bf0f790f ("f2fs: add fs-verity support") > Signed-off-by: Eric Biggers > --- > fs/f2fs/data.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c > index 3f525f8a3a5fa..00b03fb87bd9b 100644 > --- a/fs/f2fs/data.c > +++ b/fs/f2fs/data.c > @@ -2476,7 +2476,7 @@ static void f2fs_write_failed(struct address_space *mapping, loff_t to) > struct inode *inode = mapping->host; > loff_t i_size = i_size_read(inode); > > - if (to > i_size) { Maybe adding one single line comment to mention that it's redundant/unnecessary truncation here is better, if I didn't misunderstand this. Thanks, > + if (to > i_size && !f2fs_verity_in_progress(inode)) { > down_write(&F2FS_I(inode)->i_gc_rwsem[WRITE]); > down_write(&F2FS_I(inode)->i_mmap_sem); > > _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel