From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98932C432C0 for ; Wed, 4 Dec 2019 01:58:29 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5DEF0206E4; Wed, 4 Dec 2019 01:58:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sourceforge.net header.i=@sourceforge.net header.b="DGy2Eyzv"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sf.net header.i=@sf.net header.b="U66qqqIB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5DEF0206E4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1icJvx-000163-0L; Wed, 04 Dec 2019 01:58:29 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1icJvw-00015r-3s for linux-f2fs-devel@lists.sourceforge.net; Wed, 04 Dec 2019 01:58:28 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:CC:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=X6NetRQr16/OTQLUeqWgGP13TR6GyyKlpAuet2TNOko=; b=DGy2EyzvW7g+Kico+shSkQzgoV pme6mCWgZh0OV1C35nhY1n4TBlFVYgv9tEhaTrg0p9zIEISoZ4hXFmHJu2EOl7xOehalZnaGWQ1Lk iN7uLoFaS75RrHWAqsP87bgC0DvvaUYOzP8kZarOi9whWWVw9QeJIHeyeej6HNnfzXQE=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:From:References:CC:To:Subject:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=X6NetRQr16/OTQLUeqWgGP13TR6GyyKlpAuet2TNOko=; b=U66qqqIBhxC7o00NVdbjbQnuZG AK9yIK/XHDyUBJRSFT4u+ja/ARdNanbYsWcHT1rY/E514vouwrmCUxY5qonIyk54iQIrZTgcRN4vS AjLLWrR54xvnDWlj5A+Pv+LC0FweoczQ1RddRgwAXL0NncCrcUI8HrXEu+xVMorLf7r0=; Received: from szxga04-in.huawei.com ([45.249.212.190] helo=huawei.com) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1icJvs-003LyR-MU for linux-f2fs-devel@lists.sourceforge.net; Wed, 04 Dec 2019 01:58:28 +0000 Received: from DGGEMS412-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 499B4609D25F907D533A; Wed, 4 Dec 2019 09:58:14 +0800 (CST) Received: from [10.134.22.195] (10.134.22.195) by smtp.huawei.com (10.3.19.212) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 4 Dec 2019 09:58:11 +0800 To: Shin'ichiro Kawasaki , Jaegeuk Kim , References: <20191202094043.892258-1-shinichiro.kawasaki@wdc.com> <20191202094043.892258-2-shinichiro.kawasaki@wdc.com> From: Chao Yu Message-ID: Date: Wed, 4 Dec 2019 09:58:11 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20191202094043.892258-2-shinichiro.kawasaki@wdc.com> Content-Language: en-US X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected X-Headers-End: 1icJvs-003LyR-MU Subject: Re: [f2fs-dev] [PATCH v4 1/2] f2fs: Check write pointer consistency of open zones X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Damien Le Moal Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 2019/12/2 17:40, Shin'ichiro Kawasaki wrote: > On sudden f2fs shutdown, write pointers of zoned block devices can go > further but f2fs meta data keeps current segments at positions before the > write operations. After remounting the f2fs, this inconsistency causes > write operations not at write pointers and "Unaligned write command" > error is reported. > > To avoid the error, compare current segments with write pointers of open > zones the current segments point to, during mount operation. If the write > pointer position is not aligned with the current segment position, assign > a new zone to the current segment. Also check the newly assigned zone has > write pointer at zone start. If not, reset write pointer of the zone. > > Perform the consistency check during fsync recovery. Not to lose the > fsync data, do the check after fsync data gets restored and before > checkpoint commit which flushes data at current segment positions. Not to > cause conflict with kworker's dirfy data/node flush, do the fix within > SBI_POR_DOING protection. > > Signed-off-by: Shin'ichiro Kawasaki Reviewed-by: Chao Yu Thanks, _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel