Re: [f2fs-dev] [PATCH] f2fs: use kmem_cache pool during xattr lookups

[Chao Yu <yuchao0@huawei.com>]

Hi Ju Hyung,

On 2019/7/29 15:48, Ju Hyung Park wrote:
> Hi Chao and Jaegeuk,
> 
> I have no idea how that patch got merged.
> 
> We(me and Yaro) were supposed to work on doing some finishing touches
> to the patch before sending it to upstream.
> 
> I'll personally check with Yaro.
> 
> Jaegeuk, please remove the patch.
> That patch has numerous issues, biggest one being hardcoded size(SZ_256).
> 
> Also, I need to figure out how to allocate kmem cache per mounts.

That would need a per sbi kmem cache, I guess it's reasonable and worth when we
mount multiple f2fs partitions with different inline xattr size.

However, IIRC, inline_xattr_size can be changed after remount, so how can we
handle different inline xattr size in one mount... that's also a problem.

BTW, in old patch I found kvfree() should not be replaced as f2fs_kzalloc() can
use vmalloc to allocate memroy.

-	kvfree(txattr_addr);
+	if (!inline_size)
+		kfree(txattr_addr);

Thanks,

> 
> Thanks.
> 
> On Mon, Jul 29, 2019 at 4:28 PM Chao Yu <yuchao0@huawei.com> wrote:
>>
>> Hi Jaegeuk, Ju Hyung, Yaroslav,
>>
>> I can see "f2fs: xattr: reserve cache for xattr allocations" has been merged in
>> dev-test branch, however, it doesn't exist in f2fs mailing list, so I can not
>> comment on it.... Can anyone send it to the list?
>>
>> Thanks,
> .
> 


_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel