From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C17BC2D0D2 for ; Mon, 23 Dec 2019 03:37:05 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5EE54206D3 for ; Mon, 23 Dec 2019 03:37:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sourceforge.net header.i=@sourceforge.net header.b="YqpJUAH7"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sf.net header.i=@sf.net header.b="I5Zd/HJu" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5EE54206D3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1ijEWm-0002Gq-Sb; Mon, 23 Dec 2019 03:37:04 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ijEWl-0002Gj-G9 for linux-f2fs-devel@lists.sourceforge.net; Mon, 23 Dec 2019 03:37:03 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:CC:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=MU+AQZfbaV98SMqfnASMQPf+jdPqkoWNSIwxN8CI4Co=; b=YqpJUAH7KgFGUUEcezOwRZGbiv PlX0NlkpUvaAaUVKxW1dF5V39HFThv5WqV9ULlRskui+1YAGRkkpHfMSzZm8zI2XnPCCGlrrX9CNW 5qGV8u/qW983k1ymUSHR93ASwHwRhdolsGJDYk78SWc0sK3JQCi9h2ROjiD6YQbiXKIY=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:From:References:CC:To:Subject:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=MU+AQZfbaV98SMqfnASMQPf+jdPqkoWNSIwxN8CI4Co=; b=I5Zd/HJuaG92G0LHQpVaaedsoD JuIPDZbVGFDX6TDv8GbBdDFlatZVU27dx5CbOPvi8SdKGd8SxxeLR/LBpMPu+rKmKVp5SdajnauV/ ZU9NtlIg8ckDaz9yYM0GgiAyHlsfgFbNHpEDk3777Ccc2fFoAn30YkCAfJFhEpeH3DpI=; Received: from szxga06-in.huawei.com ([45.249.212.32] helo=huawei.com) by sfi-mx-4.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1ijEWk-00Cskl-22 for linux-f2fs-devel@lists.sourceforge.net; Mon, 23 Dec 2019 03:37:03 +0000 Received: from DGGEMS406-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 9596178A61233CC983FF; Mon, 23 Dec 2019 11:36:52 +0800 (CST) Received: from [10.134.22.195] (10.134.22.195) by smtp.huawei.com (10.3.19.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 23 Dec 2019 11:36:50 +0800 To: Geert Uytterhoeven References: <20191216062806.112361-1-yuchao0@huawei.com> From: Chao Yu Message-ID: Date: Mon, 23 Dec 2019 11:36:51 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected X-Headers-End: 1ijEWk-00Cskl-22 Subject: Re: [f2fs-dev] [RFC PATCH v5] f2fs: support data compression X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jaegeuk Kim , Linux Kernel Mailing List , linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 2019/12/19 17:53, Geert Uytterhoeven wrote: > On Mon, Dec 16, 2019 at 7:29 AM Chao Yu wrote: >> This patch tries to support compression in f2fs. > >> +static int f2fs_write_raw_pages(struct compress_ctx *cc, >> + int *submitted, >> + struct writeback_control *wbc, >> + enum iostat_type io_type, >> + bool compressed) >> +{ >> + int i, _submitted; >> + int ret, err = 0; >> + >> + for (i = 0; i < cc->cluster_size; i++) { >> + if (!cc->rpages[i]) >> + continue; >> +retry_write: >> + BUG_ON(!PageLocked(cc->rpages[i])); >> + >> + ret = f2fs_write_single_data_page(cc->rpages[i], &_submitted, >> + NULL, NULL, wbc, io_type); >> + if (ret) { >> + if (ret == AOP_WRITEPAGE_ACTIVATE) { >> + unlock_page(cc->rpages[i]); >> + ret = 0; >> + } else if (ret == -EAGAIN) { >> + ret = 0; >> + cond_resched(); >> + congestion_wait(BLK_RW_ASYNC, HZ/50); > > On some platforms, HZ can be less than 50. > What happens if congestion_wait() is called with a zero timeout? Thanks for the report, will fix in a separated patch. Thanks, > >> + lock_page(cc->rpages[i]); >> + clear_page_dirty_for_io(cc->rpages[i]); >> + goto retry_write; >> + } >> + err = ret; >> + goto out_fail; >> + } >> + >> + *submitted += _submitted; >> + } >> + return 0; >> + >> +out_fail: >> + /* TODO: revoke partially updated block addresses */ >> + BUG_ON(compressed); >> + >> + for (++i; i < cc->cluster_size; i++) { >> + if (!cc->rpages[i]) >> + continue; >> + redirty_page_for_writepage(wbc, cc->rpages[i]); >> + unlock_page(cc->rpages[i]); >> + } >> + return err; >> +} > > Gr{oetje,eeting}s, > > Geert > _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel