From: Chao Yu <chao@kernel.org>
To: Eric Biggers <ebiggers@kernel.org>, linux-fscrypt@vger.kernel.org
Cc: linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
Matthew Wilcox <willy@infradead.org>,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH v2 1/2] fscrypt: stop using PG_error to track error status
Date: Tue, 6 Sep 2022 23:09:17 +0800 [thread overview]
Message-ID: <faa8d9e8-f601-ebff-68f7-4e12862391de@kernel.org> (raw)
In-Reply-To: <20220815235052.86545-2-ebiggers@kernel.org>
On 2022/8/16 7:50, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
>
> As a step towards freeing the PG_error flag for other uses, change ext4
> and f2fs to stop using PG_error to track decryption errors. Instead, if
> a decryption error occurs, just mark the whole bio as failed. The
> coarser granularity isn't really a problem since it isn't any worse than
> what the block layer provides, and errors from a multi-page readahead
> aren't reported to applications unless a single-page read fails too.
>
> Signed-off-by: Eric Biggers <ebiggers@google.com>
> ---
> fs/crypto/bio.c | 16 ++++++++++------
> fs/ext4/readpage.c | 8 +++++---
> fs/f2fs/data.c | 18 ++++++++++--------
> include/linux/fscrypt.h | 5 +++--
> 4 files changed, 28 insertions(+), 19 deletions(-)
For f2fs part,
Reviewed-by: Chao Yu <chao@kernel.org>
Thanks,
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2022-09-06 15:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-15 23:50 [f2fs-dev] [PATCH v2 0/2] ext4, f2fs: stop using PG_error for fscrypt and fsverity Eric Biggers
2022-08-15 23:50 ` [f2fs-dev] [PATCH v2 1/2] fscrypt: stop using PG_error to track error status Eric Biggers
2022-09-06 15:09 ` Chao Yu [this message]
2022-08-15 23:50 ` [f2fs-dev] [PATCH v2 2/2] fsverity: " Eric Biggers
2022-09-06 15:43 ` Chao Yu
2022-10-28 17:48 ` Eric Biggers
2022-08-22 18:27 ` [f2fs-dev] [PATCH v2 0/2] ext4, f2fs: stop using PG_error for fscrypt and fsverity Eric Biggers
2022-08-22 19:21 ` Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=faa8d9e8-f601-ebff-68f7-4e12862391de@kernel.org \
--to=chao@kernel.org \
--cc=ebiggers@kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fscrypt@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).