From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78D33C4332D for ; Thu, 19 Mar 2020 16:04:00 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 490EA20658 for ; Thu, 19 Mar 2020 16:04:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sourceforge.net header.i=@sourceforge.net header.b="asuUN9/b"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sf.net header.i=@sf.net header.b="gALpWR4J" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 490EA20658 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1jExeJ-0003A9-8m; Thu, 19 Mar 2020 16:03:59 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jExeH-0003A1-Ad for linux-f2fs-devel@lists.sourceforge.net; Thu, 19 Mar 2020 16:03:57 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Type:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=poIlJdpkXhB/hme1jWsYxSLJuOWKbOpJ3N/fCT6nUe0=; b=asuUN9/bB+J/Bflim9JoAc6nwP 7D1n6FkzLSit+NZPR5aijqBcmEEWMtOtSyDeoXgYY5SE0ocAGHn9jxjrbdEzcnsDNhBeeWCItnyJ/ IHsKqG4Svrq2YSjG2CtLXRqdkZ/BR8VV5nPGXjc1uksM3wyp/uXuHNuOcauY82EgVmGY=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Type:MIME-Version:References:In-Reply-To:Subject:Cc:To:From: Message-ID:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=poIlJdpkXhB/hme1jWsYxSLJuOWKbOpJ3N/fCT6nUe0=; b=gALpWR4J0ptFGm7NrAdwyvz6zr wUB4qC2VfjzsBNajcvbhj8Z6x0KqJ07jNGDoIhUSUC7VZKUBrP7yO290BIJsqY/43V4vxrp54TQss PZ5UZkkgYQbPQSXFIc5JaWWe6y7F59JzYR5NWK4XpL6lRODrGNdUAEJSCMMYEvWIqhjY=; Received: from mx2.suse.de ([195.135.220.15]) by sfi-mx-4.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1jExeF-000NZ3-04 for linux-f2fs-devel@lists.sourceforge.net; Thu, 19 Mar 2020 16:03:57 +0000 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id ED285ABBE; Thu, 19 Mar 2020 15:48:33 +0000 (UTC) Date: Thu, 19 Mar 2020 16:48:33 +0100 Message-ID: From: Takashi Iwai To: Chao Yu In-Reply-To: <0a18cc80-92cb-a61c-a525-1266c7e3c2b1@huawei.com> References: <20200311093353.25008-1-tiwai@suse.de> <0a18cc80-92cb-a61c-a525-1266c7e3c2b1@huawei.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") X-Headers-End: 1jExeF-000NZ3-04 Subject: Re: [f2fs-dev] [PATCH] f2fs: Use scnprintf() for avoiding potential buffer overflow X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Takashi Iwai , Jaegeuk Kim , linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On Thu, 12 Mar 2020 02:08:03 +0100, Chao Yu wrote: > > On 2020/3/11 17:33, Takashi Iwai wrote: > > Since snprintf() returns the would-be-output size instead of the > > actual output size, the succeeding calls may go beyond the given > > buffer limit. Fix it by replacing with scnprintf(). > > > > Signed-off-by: Takashi Iwai > > Reviewed-by: Chao Yu Could you guys apply the patch through your tree, or should I take it? thanks, Takashi _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel