From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3DC9C43603 for ; Wed, 18 Dec 2019 21:25:46 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 975232176D; Wed, 18 Dec 2019 21:25:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sourceforge.net header.i=@sourceforge.net header.b="cp/PoVUs"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sf.net header.i=@sf.net header.b="hdburCYb"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="mMpmzkws" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 975232176D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oracle.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1ihgpF-00024f-JF; Wed, 18 Dec 2019 21:25:45 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ihgpE-00024Y-1g for linux-f2fs-devel@lists.sourceforge.net; Wed, 18 Dec 2019 21:25:44 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Type:MIME-Version:Message-ID:In-Reply-To: Date:References:From:Subject:Cc:To:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=o0Ec6O81R9S/s1aFgVFSRf2acsKPiDwr5VOnJ+jfnv8=; b=cp/PoVUsoCe71R8aAoZ5rlX9sK +YB2zjBkjiCVjlO/Jz9zooqAHJqv2pH97yK4HJlePODXIiSMhnO+JpD5RaTz+aIXtoJPh+FV9hUXW l7iMEzLsS07IDp8g3CxiAnucTf5Dv4qrniJr2ESxSvQUFgC7XFOyx9ekmXF8RimLvkZk=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References:From: Subject:Cc:To:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=o0Ec6O81R9S/s1aFgVFSRf2acsKPiDwr5VOnJ+jfnv8=; b=hdburCYb9m32CUnQA7vUuJvL/N cQ2dHcjkGKgZ5f+RYCsEpJOMu5mxO49EnYEcOXtBaJVQ93TmuQXUv2UHx/WMft2xk1oChAjgq02y6 MA1R594rfGCO/qI8n4DFN6/Xvm/8acvQHXifjzxSFxTBweaE5xdzAcJlqD5TVUVIfMIE=; Received: from userp2130.oracle.com ([156.151.31.86]) by sfi-mx-4.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1ihgp9-009Dr5-VZ for linux-f2fs-devel@lists.sourceforge.net; Wed, 18 Dec 2019 21:25:43 +0000 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id xBIL9ubq024580; Wed, 18 Dec 2019 21:25:33 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : references : date : in-reply-to : message-id : mime-version : content-type; s=corp-2019-08-05; bh=o0Ec6O81R9S/s1aFgVFSRf2acsKPiDwr5VOnJ+jfnv8=; b=mMpmzkws+v31mLu/VlvZnAUKkcGHP6plUjCvB2GGXXq3LAAtECCEK/gdYL4ExBxv0S9n /jEtn3HJ7VVEUYv+EXkztASzutP5ltutquVsTZHg9G/Zjl9aEQNq3t4kILILagMb9AIu dq0QY9pIPV8z3Z4ITvf1c35zRzvN49mqesNdu+PVp89NlF+ouc9UkUY5GWlHFQ6Y6kQ6 w2cRE0WKJ/kpqjgxwtB/hH2Scis+xrvMPCK671uOlw8BiugMNc69vg2feShxxd2AcO4b UrarR2dgvf8NVMMoZdTs/VL5h/oiDsYwCTyAuUcnfo3gWbo4QVTQA3pmDRcFISrAWebt VA== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by userp2130.oracle.com with ESMTP id 2wvq5urcae-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 18 Dec 2019 21:25:32 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id xBILAtB4186597; Wed, 18 Dec 2019 21:25:32 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserp3030.oracle.com with ESMTP id 2wyut48eeq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 18 Dec 2019 21:25:31 +0000 Received: from abhmp0003.oracle.com (abhmp0003.oracle.com [141.146.116.9]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id xBILPVFJ003758; Wed, 18 Dec 2019 21:25:31 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 18 Dec 2019 13:25:31 -0800 To: "Darrick J. Wong" From: "Martin K. Petersen" Organization: Oracle Corporation References: <20191218145136.172774-1-satyat@google.com> <20191218145136.172774-3-satyat@google.com> <20191218212116.GA7476@magnolia> Date: Wed, 18 Dec 2019 16:25:28 -0500 In-Reply-To: <20191218212116.GA7476@magnolia> (Darrick J. Wong's message of "Wed, 18 Dec 2019 13:21:16 -0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.92 (gnu/linux) MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9475 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=981 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1911140001 definitions=main-1912180163 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9475 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1911140001 definitions=main-1912180163 X-Headers-End: 1ihgp9-009Dr5-VZ Subject: Re: [f2fs-dev] [PATCH v6 2/9] block: Add encryption context to struct bio X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-scsi@vger.kernel.org, Kim Boojin , Kuohong Wang , Barani Muthukumaran , linux-f2fs-devel@lists.sourceforge.net, linux-block@vger.kernel.org, linux-fscrypt@vger.kernel.org, linux-fsdevel@vger.kernel.org, Satya Tangirala Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net Darrick, >> +#ifdef CONFIG_BLK_INLINE_ENCRYPTION >> + struct bio_crypt_ctx *bi_crypt_context; >> +#endif > > This grows struct bio even if we aren't actively using bi_crypt_context, > and I thought Jens told us to stop making it bigger. :) Yeah. Why not use the bio integrity plumbing? It was explicitly designed to attach things to a bio and have them consumed by the device driver. -- Martin K. Petersen Oracle Linux Engineering _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel