Am 28.11.20 um 23:40 schrieb Sam Ravnborg:
> init.h define static symbols, so should only be included

s/define/defines
s/so should/so it should

> once. Drop the include from sis.h as it is not needed.
> This fixes a lot of warnings seen with a W=1 build.
> 
> v2:
>    - Update subject (Lee)
> 
> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> Cc: Thomas Winischhofer <thomas@winischhofer.net>
> Cc: Lee Jones <lee.jones@linaro.org>

Acked-by: Thomas Zimmermann <tzimmermann@suse.de>

> ---
>   drivers/video/fbdev/sis/sis.h | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/video/fbdev/sis/sis.h b/drivers/video/fbdev/sis/sis.h
> index 9f4c3093ccb3..d632f096083b 100644
> --- a/drivers/video/fbdev/sis/sis.h
> +++ b/drivers/video/fbdev/sis/sis.h
> @@ -15,7 +15,6 @@
>   
>   #include "vgatypes.h"
>   #include "vstruct.h"
> -#include "init.h"
>   
>   #define VER_MAJOR		1
>   #define VER_MINOR		8
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer