From: "Bruno Prémont" <bonbons@linux-vserver.org>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Jiri Kosina <jkosina@suse.cz>,
linux-input@vger.kernel.org, linux-usb@vger.kernel.org,
linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org,
"Rick L. Vinyard Jr." <rvinyard@cs.nmsu.edu>,
Nicu Pavel <npavel@ituner.com>, Oliver Neukum <oliver@neukum.org>,
Jaya Kumar <jayakumar.lkml@gmail.com>
Subject: Re: [PATCH v3 1/6] hid: new driver for PicoLCD device
Date: Fri, 26 Mar 2010 09:29:51 +0000 [thread overview]
Message-ID: <20100326102951.3b9ecda1@neptune.home> (raw)
In-Reply-To: <20100326065656.GC26602@core.coreip.homeip.net>
On Thu, 25 March 2010 Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote:
> On Wed, Mar 24, 2010 at 11:40:22PM +0100, Bruno Prémont wrote:
> > + for (i = 0; i < PICOLCD_KEYS; i++) {
> > + int key = ((int *)idev->keycode)[i];
>
> Keycodes are now short, not int. Also, just do:
>
> input_set_capability(idev, EV_KEY, data->keycode[i]);
>
> > + if (key < KEY_MAX && key >= 0)
> > + input_set_capability(idev, EV_KEY, key);
Oops, I was not careful enough when switching over...
Thanks for catching,
Bruno
next prev parent reply other threads:[~2010-03-26 9:29 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-24 22:37 [PATCH v3 0/6] hid: new driver for PicoLCD device Bruno Prémont
2010-03-24 22:49 ` [PATCH v3 2/6] hid: add framebuffer support to " Bruno Prémont
2010-03-27 0:22 ` [PATCH v4 " Bruno Prémont
2010-03-29 20:30 ` [PATCH v5 " Bruno Prémont
2010-03-24 22:51 ` [PATCH v3 3/6] hid: add backlight " Bruno Prémont
2010-03-24 22:54 ` [PATCH v3 4/6] hid: add lcd " Bruno Prémont
[not found] ` <20100324233707.7243b04d-hY15tx4IgV39zxVx7UNMDg@public.gmane.org>
2010-03-24 22:40 ` [PATCH v3 1/6] hid: new driver for " Bruno Prémont
2010-03-26 6:56 ` Dmitry Torokhov
2010-03-26 9:29 ` Bruno Prémont [this message]
2010-03-26 20:59 ` Jiri Kosina
2010-03-26 21:16 ` Dmitry Torokhov
2010-03-26 21:39 ` Bruno Prémont
2010-03-27 0:22 ` [PATCH v4 " Bruno Prémont
2010-03-29 9:47 ` Jiri Kosina
2010-03-29 10:16 ` Bruno Prémont
2010-03-30 8:12 ` Jiri Kosina
2010-03-30 20:32 ` [PATCH v6 0/8] " Bruno Prémont
2010-03-30 20:33 ` [PATCH v6 1/8] " Bruno Prémont
2010-04-01 16:58 ` Oliver Neukum
2010-04-25 19:29 ` [PATCH] hid: split picolcd's operation_mode sysfs attribute Bruno Prémont
2010-04-27 13:32 ` Jiri Kosina
2010-03-30 20:34 ` [PATCH v6 2/8] hid: add framebuffer support to PicoLCD device Bruno Prémont
[not found] ` <20100330223224.18fe4f3e-hY15tx4IgV39zxVx7UNMDg@public.gmane.org>
2010-03-30 20:35 ` [PATCH v6 3/8] hid: add backlight " Bruno Prémont
2010-03-30 20:36 ` [PATCH v6 4/8] hid: add lcd " Bruno Prémont
2010-03-30 20:36 ` [PATCH v6 5/8] hid: add GPO (leds) " Bruno Prémont
2010-03-30 20:38 ` [PATCH v6 6/8] hid: add experimental access to PicoLCD device's Bruno Prémont
2010-03-30 20:42 ` [PATCH v6 7/8, needs improvement] hid: add suspend/resume hooks for Bruno Prémont
2010-03-31 12:15 ` [PATCH v6 7/8, needs improvement] hid: add suspend/resume hooks Jiri Kosina
2010-03-30 20:43 ` [PATCH v6 8/8] hid: add PM support to PicoLCD device Bruno Prémont
2010-03-31 9:28 ` [PATCH v6 0/8] hid: new driver for " Jiri Kosina
2010-03-24 22:55 ` [PATCH v3 5/6] hid: add GPO (leds) support to " Bruno Prémont
2010-03-24 22:58 ` [PATCH v3 6/6] hid: add experimental access to PicoLCD device's Bruno Prémont
2010-03-29 9:44 ` Jiri Kosina
[not found] ` <alpine.LNX.2.00.1003291142400.24576-ztGlSCb7Y1iN3ZZ/Hiejyg@public.gmane.org>
2010-03-29 20:34 ` [PATCH v4 " Bruno Prémont
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100326102951.3b9ecda1@neptune.home \
--to=bonbons@linux-vserver.org \
--cc=dmitry.torokhov@gmail.com \
--cc=jayakumar.lkml@gmail.com \
--cc=jkosina@suse.cz \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=npavel@ituner.com \
--cc=oliver@neukum.org \
--cc=rvinyard@cs.nmsu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).