From: Dan Carpenter <dan.carpenter@oracle.com>
To: linux-fbdev@vger.kernel.org
Subject: Re: [PATCH 1/1] fbmem: add margin check to fb_check_caps()
Date: Tue, 07 Jul 2020 19:47:14 +0000 [thread overview]
Message-ID: <20200707194714.GA2571@kadam> (raw)
In-Reply-To: <1594149963-13801-1-git-send-email-george.kennedy@oracle.com>
On Tue, Jul 07, 2020 at 03:26:03PM -0400, George Kennedy wrote:
> A fb_ioctl() FBIOPUT_VSCREENINFO call with invalid xres setting
> or yres setting in struct fb_var_screeninfo will result in a
> KASAN: vmalloc-out-of-bounds failure in bitfill_aligned() as
> the margins are being cleared. The margins are cleared in
> chunks and if the xres setting or yres setting is a value of
> zero upto the chunk size, the failure will occur.
>
> Add a margin check to validate xres and yres settings.
>
> Signed-off-by: George Kennedy <george.kennedy@oracle.com>
> Suggested-by: Dan Carpenter <dan.carpenter@oracle.com>
Suggested-by is perhaps a bit strong. Let's change that to:
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
regards,
dan carpenter
next prev parent reply other threads:[~2020-07-07 19:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-07 19:26 [PATCH 1/1] fbmem: add margin check to fb_check_caps() George Kennedy
2020-07-07 19:47 ` Dan Carpenter [this message]
2020-09-08 11:36 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200707194714.GA2571@kadam \
--to=dan.carpenter@oracle.com \
--cc=linux-fbdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).