From: Lee Jones <lee.jones@linaro.org>
To: Daniel Thompson <daniel.thompson@linaro.org>
Cc: linux-fbdev@vger.kernel.org,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Gyungoh Yoo <jack.yoo@skyworksinc.com>,
Bryan Wu <cooloney@gmail.com>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org,
Markus Elfring <Markus.Elfring@web.de>,
dinghao.liu@zju.edu.cn, Jingoo Han <jingoohan1@gmail.com>,
Kangjie Lu <kjlu@umn.edu>
Subject: Re: [PATCH] video: backlight: sky81452-backlight: Fix reference count imbalance on error
Date: Fri, 28 Aug 2020 09:29:04 +0000 [thread overview]
Message-ID: <20200828092904.GD1826686@dell> (raw)
In-Reply-To: <20200820113817.742yvjvdy7a642ew@holly.lan>
On Thu, 20 Aug 2020, Daniel Thompson wrote:
> On Thu, Aug 20, 2020 at 08:49:16AM +0100, Lee Jones wrote:
> > On Thu, 20 Aug 2020, dinghao.liu@zju.edu.cn wrote:
> >
> > > > On Thu, 20 Aug 2020, dinghao.liu@zju.edu.cn wrote:
> > > >
> > > > > > On Wed, 19 Aug 2020, Markus Elfring wrote:
> > > > > >
> > > > > > > > When of_property_read_u32_array() returns an error code,
> > > > > > > > a pairing refcount decrement is needed to keep np's refcount balanced.
> > > > > > >
> > > > > > > Can another imperative wording be helpful for the change description?
> > > > > > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id\x18445bf405cb331117bc98427b1ba6f12418ad17#n151
> > > > > > >
> > > > > > > Would an other commit message be a bit nicer?
> > > > > > >
> > > > > > >
> > > > > > > …
> > > > > > > > +++ b/drivers/video/backlight/sky81452-backlight.c
> > > > > > > > @@ -217,6 +217,7 @@ static struct sky81452_bl_platform_data *sky81452_bl_parse_dt(
> > > > > > > > num_entry);
> > > > > > > > if (ret < 0) {
> > > > > > > > dev_err(dev, "led-sources node is invalid.\n");
> > > > > > > > + of_node_put(np);
> > > > > > > > return ERR_PTR(-EINVAL);
> > > > > > > > }
> > > > > > >
> > > > > > > I propose to add the jump target “put_node” so that a bit of common exception
> > > > > > > handling code can be better reused at the end of this function implementation.
> > > > > > >
> > > > > > > Regards,
> > > > > > > Markus
> > > > > >
> > > > > > You can safely ignore any review comments from Markus!
> > > > > >
> > > > > > However, this patch doesn't appear to be in my inbox.
> > > > > >
> > > > > > Any ideas as to why?
> > > > > >
> > > > >
> > > > > Thank you for your advice. My outbox shows that this patch
> > > > > has reached your email server successfully. Maybe this
> > > > > ended up in your junk mail file?
> > > >
> > > > This has happened recently, so I was sure to check.
> > > >
> > > > Not there either unfortunately.
> > > >
> > > > Would you be kind enough to bounce/resend please?
> > >
> > > Sure.
> >
> > Looks like you sent it *only* to me. Please keep everyone else in Cc
> > when doing that, or I can't respond to everyone.
> >
> > Anyway, besides the subject line (which I can fix easily), the patch
> > looks good to me, but Daniel T must review.
>
> I've already offered a Reviewed-by for this patch. Perhaps it landed in
> the same place as the original patch...
Patch applied, thanks.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2020-08-28 9:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <321fb03d-2307-7f60-f437-cfb99184dfd6@web.de>
2020-08-19 16:57 ` [PATCH] video: backlight: sky81452-backlight: Fix reference count imbalance on error Lee Jones
2020-08-20 3:50 ` dinghao.liu
2020-08-20 6:23 ` Lee Jones
2020-08-20 6:36 ` dinghao.liu
2020-08-20 7:49 ` Lee Jones
2020-08-20 11:38 ` Daniel Thompson
2020-08-28 9:29 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200828092904.GD1826686@dell \
--to=lee.jones@linaro.org \
--cc=Markus.Elfring@web.de \
--cc=b.zolnierkie@samsung.com \
--cc=cooloney@gmail.com \
--cc=daniel.thompson@linaro.org \
--cc=dinghao.liu@zju.edu.cn \
--cc=dri-devel@lists.freedesktop.org \
--cc=jack.yoo@skyworksinc.com \
--cc=jingoohan1@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kjlu@umn.edu \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).