From: Sam Ravnborg <sam@ravnborg.org>
To: Xiaofei Tan <tanxiaofei@huawei.com>
Cc: linux-fbdev@vger.kernel.org, arnd@arndb.de,
b.zolnierkie@samsung.com, jani.nikula@intel.com,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
linuxarm@huawei.com, laurent.pinchart@ideasonboard.com
Subject: Re: [PATCH] fbdev: mx3fb: remove unused variable 'irq'
Date: Thu, 24 Sep 2020 20:12:46 +0000 [thread overview]
Message-ID: <20200924201246.GH1223313@ravnborg.org> (raw)
In-Reply-To: <1600334360-4214-1-git-send-email-tanxiaofei@huawei.com>
On Thu, Sep 17, 2020 at 05:19:20PM +0800, Xiaofei Tan wrote:
> Remove the variable 'irq' that is set but never used.
>
> Signed-off-by: Xiaofei Tan <tanxiaofei@huawei.com>
Thanks, applied to drm-misc-next.
Sam
> ---
> drivers/video/fbdev/mx3fb.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/video/fbdev/mx3fb.c b/drivers/video/fbdev/mx3fb.c
> index 603731a..894617d 100644
> --- a/drivers/video/fbdev/mx3fb.c
> +++ b/drivers/video/fbdev/mx3fb.c
> @@ -1428,7 +1428,6 @@ static int init_fb_chan(struct mx3fb_data *mx3fb, struct idmac_channel *ichan)
> struct device *dev = mx3fb->dev;
> struct mx3fb_platform_data *mx3fb_pdata = dev_get_platdata(dev);
> const char *name = mx3fb_pdata->name;
> - unsigned int irq;
> struct fb_info *fbi;
> struct mx3fb_info *mx3fbi;
> const struct fb_videomode *mode;
> @@ -1441,7 +1440,6 @@ static int init_fb_chan(struct mx3fb_data *mx3fb, struct idmac_channel *ichan)
> }
>
> ichan->client = mx3fb;
> - irq = ichan->eof_irq;
>
> if (ichan->dma_chan.chan_id != IDMAC_SDC_0)
> return -EINVAL;
> --
> 2.8.1
prev parent reply other threads:[~2020-09-24 20:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-17 9:19 [PATCH] fbdev: mx3fb: remove unused variable 'irq' Xiaofei Tan
2020-09-24 20:12 ` Sam Ravnborg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200924201246.GH1223313@ravnborg.org \
--to=sam@ravnborg.org \
--cc=arnd@arndb.de \
--cc=b.zolnierkie@samsung.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=tanxiaofei@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).