archive mirror
 help / color / mirror / Atom feed
From: Sasha Levin <>
Cc: Tom Rix <>, Arnd Bergmann <>,
	Sam Ravnborg <>, Sasha Levin <>,,,
Subject: [PATCH AUTOSEL 4.14 10/46] video: fbdev: pvr2fb: initialize variables
Date: Mon, 26 Oct 2020 20:09:09 -0400	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

From: Tom Rix <>

[ Upstream commit 8e1ba47c60bcd325fdd097cd76054639155e5d2e ]

clang static analysis reports this repesentative error

pvr2fb.c:1049:2: warning: 1st function call argument
  is an uninitialized value [core.CallAndMessage]
        if (*cable_arg)

Problem is that cable_arg depends on the input loop to
set the cable_arg[0].  If it does not, then some random
value from the stack is used.

A similar problem exists for output_arg.

So initialize cable_arg and output_arg.

Signed-off-by: Tom Rix <>
Acked-by: Arnd Bergmann <>
Signed-off-by: Sam Ravnborg <>
Signed-off-by: Sasha Levin <>
 drivers/video/fbdev/pvr2fb.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/video/fbdev/pvr2fb.c b/drivers/video/fbdev/pvr2fb.c
index 867c5218968f7..426e79061bc88 100644
--- a/drivers/video/fbdev/pvr2fb.c
+++ b/drivers/video/fbdev/pvr2fb.c
@@ -1029,6 +1029,8 @@ static int __init pvr2fb_setup(char *options)
 	if (!options || !*options)
 		return 0;
+	cable_arg[0] = output_arg[0] = 0;
 	while ((this_opt = strsep(&options, ","))) {
 		if (!*this_opt)

           reply	other threads:[~2020-10-27  0:19 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).