From: Peilin Ye <yepeilin.cs@gmail.com>
To: Daniel Vetter <daniel@ffwll.ch>, Jiri Slaby <jirislaby@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Thomas Winischhofer <thomas@winischhofer.net>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Nicolas Pitre <nico@fluxnic.net>,
"Gustavo A . R . Silva" <gustavoars@kernel.org>,
Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
George Kennedy <george.kennedy@oracle.com>,
Nathan Chancellor <natechancellor@gmail.com>,
Peter Rosin <peda@axentia.se>,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org
Subject: Re: [PATCH v2 1/2] console: Remove dummy con_font_op() callback implementations
Date: Mon, 2 Nov 2020 05:52:28 -0500 [thread overview]
Message-ID: <20201102105228.GA1558395@PWN> (raw)
In-Reply-To: <20201102101347.GN401619@phenom.ffwll.local>
On Mon, Nov 02, 2020 at 11:13:47AM +0100, Daniel Vetter wrote:
> On Mon, Nov 02, 2020 at 10:47:55AM +0100, Jiri Slaby wrote:
> > On 02. 11. 20, 10:36, Peilin Ye wrote:
> > > `struct console_font` is a UAPI structure, thus ideally should not be
> > > used for kernel internal abstraction. Remove some dummy .con_font_set,
> > > .con_font_default and .con_font_copy `struct consw` callback
> > > implementations, to make it cleaner.
> >
> > ESEMANTIC_ERROR.
> >
> > 1) What do you refer to with the last "it"?
> >
> > 2) What's the purpose of mentioning struct console_font at all?
> >
> > 3) Could you clarify whether you checked it is safe to remove the hooks?
I see. I will try to elaborate in future patches, thank you!
> > 4) All the hooks now return ENOSYS for both consoles (and not 0). Is this
> > intentional?
> >
> > I know answers to the first 3 questions, but you need to elaborate a bit in
> > the commit log to connect those sentences. Esp. for people not dealing with
> > the code on a daily basis. Ad 4) I am not sure.
>
> Yup the behaviour change from 4) needs to be called out. I think this
> should then also be done as part of the large patch series to remove the
> dummy functions from all console drivers.
>
> I don't expect the errno change to cause trouble, and it's the more honest
> errno - changing fonts not supported is the truth. But if it is, we can
> patch that up appropriately when we get a regression report. That's kinda
> unavoidable with old crufty uapi like this one here.
>
> Also a bikeshed: Additional information like the patch changelog or
> reasons why you do something is imo best to include in the commit message
> itself. It ends up looking a bit less tidy sometimes, but often there's
> crucial information in these parts that was accidentally left out from the
> commit message.
Sure, I will try to include sufficient information for one to easily
understand what I'm trying to do with a patch. Thank you,
Peilin
next prev parent reply other threads:[~2020-11-02 10:52 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-31 7:24 [PATCH 1/2] console: Remove dummy con_font_op() callback implementations Peilin Ye
2020-10-31 7:27 ` [PATCH 2/2] fbcon: Prevent global-out-of-bounds read in fbcon_copy_font() Peilin Ye
2020-11-02 9:36 ` [PATCH v2 1/2] console: Remove dummy con_font_op() callback implementations Peilin Ye
2020-11-02 9:37 ` [PATCH v2 2/2] tty/vt: Avoid passing struct console_font_op to con_font_copy() Peilin Ye
2020-11-02 10:10 ` Daniel Vetter
2020-11-02 11:12 ` Peilin Ye
2020-11-02 11:30 ` Daniel Vetter
2020-11-02 9:47 ` [PATCH v2 1/2] console: Remove dummy con_font_op() callback implementations Jiri Slaby
2020-11-02 10:13 ` Daniel Vetter
2020-11-02 10:52 ` Peilin Ye [this message]
2020-11-06 10:50 ` [PATCH " Greg Kroah-Hartman
2020-11-10 12:49 ` Daniel Vetter
2020-11-10 13:24 ` Peilin Ye
2020-11-10 13:46 ` Daniel Vetter
2020-11-10 13:55 ` Peilin Ye
2020-11-10 14:56 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201102105228.GA1558395@PWN \
--to=yepeilin.cs@gmail.com \
--cc=b.zolnierkie@samsung.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=george.kennedy@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=gustavoars@kernel.org \
--cc=jirislaby@kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=natechancellor@gmail.com \
--cc=nico@fluxnic.net \
--cc=peda@axentia.se \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=thomas@winischhofer.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).