From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A691C2D0A3 for ; Mon, 9 Nov 2020 07:31:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B10222067D for ; Mon, 9 Nov 2020 07:31:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729192AbgKIHbb (ORCPT ); Mon, 9 Nov 2020 02:31:31 -0500 Received: from asavdk4.altibox.net ([109.247.116.15]:52268 "EHLO asavdk4.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728038AbgKIHbb (ORCPT ); Mon, 9 Nov 2020 02:31:31 -0500 Received: from ravnborg.org (unknown [188.228.123.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk4.altibox.net (Postfix) with ESMTPS id 1D1D780537; Mon, 9 Nov 2020 08:31:29 +0100 (CET) Date: Mon, 9 Nov 2020 08:31:27 +0100 From: Sam Ravnborg To: Alex Shi Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] video: fbdev: riva: remove some unused varibles Message-ID: <20201109073127.GC1715181@ravnborg.org> References: <1604822519-65607-1-git-send-email-alex.shi@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1604822519-65607-1-git-send-email-alex.shi@linux.alibaba.com> X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=VafZwmh9 c=1 sm=1 tr=0 a=S6zTFyMACwkrwXSdXUNehg==:117 a=S6zTFyMACwkrwXSdXUNehg==:17 a=IkcTkHD0fZMA:10 a=SRrdq9N9AAAA:8 a=pGLkceISAAAA:8 a=VwQbUJbxAAAA:8 a=e5mUnYsNAAAA:8 a=K4B7_0IVxdEOLhH2ft8A:9 a=QEXdDO2ut3YA:10 a=AjGcO6oz07-iQ99wixmX:22 a=Vxmtnl_E_bksehYqCbjh:22 Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Hi Alex, On Sun, Nov 08, 2020 at 04:01:59PM +0800, Alex Shi wrote: > Couple of variables are actually useless, remove them to save some gcc > warning: > drivers/video/fbdev/riva/riva_hw.c:250:21: warning: variable ‘mlwm’ set > but not used [-Wunused-but-set-variable] > drivers/video/fbdev/riva/riva_hw.c:665:15: warning: variable ‘vraw’ set > but not used [-Wunused-but-set-variable] > drivers/video/fbdev/riva/riva_hw.c:665:9: warning: variable ‘craw’ set > but not used [-Wunused-but-set-variable] > drivers/video/fbdev/riva/riva_hw.c:659:73: warning: variable ‘align’ set > but not used [-Wunused-but-set-variable] > drivers/video/fbdev/riva/riva_hw.c:659:50: warning: variable > ‘color_key_enable’ set but not used [-Wunused-but-set-variable] > > Signed-off-by: Alex Shi > Cc: Antonino Daplas > Cc: linux-fbdev@vger.kernel.org > Cc: dri-devel@lists.freedesktop.org > Cc: linux-kernel@vger.kernel.org Thanks, applied to drm-misc-next. The fix will appear in -next in a week or so. Sam