From: Daniel Vetter <daniel@ffwll.ch> To: Peilin Ye <yepeilin.cs@gmail.com> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Jiri Slaby <jirislaby@kernel.org>, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org Subject: Re: [PATCH v3 0/5] console: Miscellaneous clean-ups, do not use FNTCHARCNT() in fbcon.c Date: Fri, 13 Nov 2020 22:16:33 +0100 Message-ID: <20201113211633.GY401619@phenom.ffwll.local> (raw) In-Reply-To: <cover.1605169912.git.yepeilin.cs@gmail.com> On Thu, Nov 12, 2020 at 07:02:21AM -0500, Peilin Ye wrote: > Hi all, > > This is a collection of some miscellaneous clean-ups for fbcon and some > console drivers. Since v2, I rebased them on linux-next, added some > Reviewed-by: tags from Daniel and Greg, and rewrote the commit messages as > suggested by Jiri. See [1] for v2 links. > > It does the following: > > - Garbage collect KD_FONT_OP_COPY callbacks since we disabled it > recently. Mark it as obsolete. > - Delete dummy con_font_op() callbacks. (Reviewed by Greg) > > - Add a charcount field to our new font descriptor, `struct font_desc`. > (Reviewed by Daniel) > - Do not use a hard-coded 256 for built-in font charcount in > console/sticore.c, use the new charcount field of `struct font_desc` > instead. (Reviewed by Daniel) > - Similarly, in fbcon.c, avoid using the magic negative-indexing macro, > FNTCHARCNT(). Set `vc->vc_font.charcount` properly and always use that > instead. > > Daniel, hopefully [5/5] removes FNTCHARCNT() for ever, but I have not > tested it sufficiently yet. I remember you mentioned elsewhere that > "fbtest.c" is insufficient for framebuffer testing, then how should we > test it? The first 4 patches should be fine. > > Please reference commit messages for more information. Thank you! > > [1] v2 links: > > 2/5: https://lore.kernel.org/lkml/c5563eeea36aae7bd72ea2e985bc610d585ece40.1604306433.git.yepeilin.cs@gmail.com/ > 3/5: https://lore.kernel.org/lkml/20201028060533.1206307-1-yepeilin.cs@gmail.com/ > 4/5: https://lore.kernel.org/lkml/c38042bbf5c9777c84900d56c09f3c156b32af48.1603788512.git.yepeilin.cs@gmail.com/ > 5/5: https://lore.kernel.org/lkml/20201028155139.1220549-1-yepeilin.cs@gmail.com/ > > Peilin Ye (5): > console: Delete unused con_font_copy() callback implementations > console: Delete dummy con_font_set() and con_font_default() callback implementations > Fonts: Add charcount field to font_desc > parisc/sticore: Avoid hard-coding built-in font charcount > fbcon: Avoid using FNTCHARCNT() and hard-coded built-in font charcount Patches all look good to me, if Greg is ok with me applying the entire pile to drm-misc-next I'll do that next week. Thanks, Daniel > > drivers/usb/misc/sisusbvga/sisusb_con.c | 21 -------- > drivers/video/console/dummycon.c | 20 -------- > drivers/video/console/sticore.c | 8 +-- > drivers/video/fbdev/core/fbcon.c | 68 ++++++++----------------- > drivers/video/fbdev/core/fbcon_rotate.c | 3 +- > drivers/video/fbdev/core/tileblit.c | 4 +- > include/linux/console.h | 1 - > include/linux/font.h | 1 + > include/uapi/linux/kd.h | 2 +- > lib/fonts/font_10x18.c | 1 + > lib/fonts/font_6x10.c | 1 + > lib/fonts/font_6x11.c | 1 + > lib/fonts/font_6x8.c | 1 + > lib/fonts/font_7x14.c | 1 + > lib/fonts/font_8x16.c | 1 + > lib/fonts/font_8x8.c | 1 + > lib/fonts/font_acorn_8x8.c | 1 + > lib/fonts/font_mini_4x6.c | 1 + > lib/fonts/font_pearl_8x8.c | 1 + > lib/fonts/font_sun12x22.c | 1 + > lib/fonts/font_sun8x16.c | 1 + > lib/fonts/font_ter16x32.c | 1 + > 22 files changed, 42 insertions(+), 99 deletions(-) > > -- > 2.25.1 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch
next prev parent reply index Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-11-12 12:02 Peilin Ye 2020-11-12 12:04 ` [PATCH 1/5] console: Delete unused con_font_copy() callback implementations Peilin Ye 2020-11-12 12:11 ` [PATCH v3 2/5] console: Delete dummy con_font_set() and con_font_default() " Peilin Ye 2020-11-12 12:13 ` [PATCH v3 3/5] Fonts: Add charcount field to font_desc Peilin Ye 2020-11-12 12:14 ` [PATCH v3 4/5] parisc/sticore: Avoid hard-coding built-in font charcount Peilin Ye 2020-11-12 12:15 ` [PATCH v3 RFC 5/5] fbcon: Avoid using FNTCHARCNT() and hard-coded " Peilin Ye 2020-11-13 21:16 ` Daniel Vetter [this message] 2020-11-13 22:47 ` [PATCH v3 0/5] console: Miscellaneous clean-ups, do not use FNTCHARCNT() in fbcon.c Greg Kroah-Hartman 2020-11-14 8:10 ` Peilin Ye 2020-11-14 12:18 ` Greg Kroah-Hartman 2020-11-14 12:22 ` Greg Kroah-Hartman 2020-11-14 12:47 ` Peilin Ye 2020-11-16 10:09 ` Daniel Vetter 2020-11-17 6:21 ` Peilin Ye 2020-11-19 8:32 ` Peilin Ye 2020-11-19 15:10 ` Daniel Vetter 2020-11-20 8:37 ` Peilin Ye 2020-11-16 15:33 ` Daniel Vetter
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20201113211633.GY401619@phenom.ffwll.local \ --to=daniel@ffwll.ch \ --cc=daniel.vetter@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=gregkh@linuxfoundation.org \ --cc=jirislaby@kernel.org \ --cc=linux-fbdev@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=yepeilin.cs@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Linux-fbdev Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/linux-fbdev/0 linux-fbdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 linux-fbdev linux-fbdev/ https://lore.kernel.org/linux-fbdev \ linux-fbdev@vger.kernel.org public-inbox-index linux-fbdev Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.linux-fbdev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git