Linux-fbdev Archive on
 help / color / Atom feed
From: Randy Dunlap <>
Cc: Randy Dunlap <>,
	"David S. Miller" <>,,
	Tomi Valkeinen <>,,,
	Daniel Vetter <>,
	David Airlie <>,
	Bartlomiej Zolnierkiewicz <>,
	Geert Uytterhoeven <>
Subject: [PATCH v2] fbdev: aty: SPARC64 requires FB_ATY_CT
Date: Thu, 26 Nov 2020 19:17:52 -0800
Message-ID: <> (raw)

It looks like SPARC64 requires FB_ATY_CT to build without errors,
so have FB_ATY select FB_ATY_CT if both SPARC64 and PCI are enabled
instead of using "default y if SPARC64 && PCI", which is not strong
enough to prevent build errors.

As it currently is, FB_ATY_CT can be disabled, resulting in build

ERROR: modpost: "aty_postdividers" [drivers/video/fbdev/aty/atyfb.ko] undefined!
ERROR: modpost: "aty_ld_pll_ct" [drivers/video/fbdev/aty/atyfb.ko] undefined!

Fixes: f7018c213502 ("video: move fbdev to drivers/video/fbdev")
Signed-off-by: Randy Dunlap <>
Cc: "David S. Miller" <>
Cc: Tomi Valkeinen <>
Cc: Daniel Vetter <>
Cc: David Airlie <>
Cc: Bartlomiej Zolnierkiewicz <>
Cc: Geert Uytterhoeven <>
v2: use select (suggested by Geert)

 drivers/video/fbdev/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-next-20201124.orig/drivers/video/fbdev/Kconfig
+++ linux-next-20201124/drivers/video/fbdev/Kconfig
@@ -1269,6 +1269,7 @@ config FB_ATY
 	select FB_MACMODES if PPC
+	select FB_ATY_CT if SPARC64 && PCI
 	  This driver supports graphics boards with the ATI Mach64 chips.
 	  Say Y if you have such a graphics board.
@@ -1279,7 +1280,6 @@ config FB_ATY
 config FB_ATY_CT
 	bool "Mach64 CT/VT/GT/LT (incl. 3D RAGE) support"
 	depends on PCI && FB_ATY
-	default y if SPARC64 && PCI
 	  Say Y here to support use of ATI's 64-bit Rage boards (or other
 	  boards based on the Mach64 CT, VT, GT, and LT chipsets) as a

             reply index

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-27  3:17 Randy Dunlap [this message]
2020-11-27  9:15 ` Geert Uytterhoeven
2020-11-27 15:14   ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-fbdev Archive on

Archives are clonable:
	git clone --mirror linux-fbdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-fbdev linux-fbdev/ \
	public-inbox-index linux-fbdev

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone