From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AAA6FC2D0E4 for ; Fri, 27 Nov 2020 15:14:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 50A8422244 for ; Fri, 27 Nov 2020 15:14:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="iNafPJ5y" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730422AbgK0POo (ORCPT ); Fri, 27 Nov 2020 10:14:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40340 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729113AbgK0POn (ORCPT ); Fri, 27 Nov 2020 10:14:43 -0500 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C2C73C0613D1 for ; Fri, 27 Nov 2020 07:14:41 -0800 (PST) Received: by mail-wr1-x443.google.com with SMTP id m6so5920714wrg.7 for ; Fri, 27 Nov 2020 07:14:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=ZMzwoE0Dd6fGdbZptz4gO2+Eta2edZWtpfnfREQIYBk=; b=iNafPJ5ywOWSDkzoa418mygS+Pu6j0+b0FZhr6dG9lb3JOScnAd3oHUlc0LVjAmD3g exwlJ3BhHTSl3vuBryhe7Kgc56fC1N5rj6jJWeqihvbS3H0kM3HY57LQzY/0PqTshM70 wHuQWaqK5Fxc12etXg9s39a4GbCEOsotO/7GU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=ZMzwoE0Dd6fGdbZptz4gO2+Eta2edZWtpfnfREQIYBk=; b=dslThzOCD/P69D/iLwYrY36Su8zu7kaFvSmctmk5eN1kkwW3T8QJuVpd2cOueuGJ7Y N7gUcWY8zb/X+1mW+wZXko0z+r3bI8/iia/WebIFqBZsHngEeD39d0QifQnIgFEmGh8q yK6ll2yhQYsPES3x5UL4p3KVxCqxCKvla6kYJDDbu5dSHJCfRKcLWPVkbmBj4F1T0VA3 /F+tLL+SuHQ5bt4dF+t0ZI7Wy/oZTmFmmtK+xQcq2a+cAkWqXMt4UF/Z3nygH79PV8l3 4fEZBnzq/U2TnlSw1OskLEZqDfc/EVdDk2ttByDls831N0gD8JsSklPwgdpXl7glJv11 kJrw== X-Gm-Message-State: AOAM531CvHttqKWyPrtlqBAkCrx1Q1xn4HVnDcbI7CwdEoay/Om71jei uzHtndOSnJsH24B0BSdk1fUoOQ== X-Google-Smtp-Source: ABdhPJzeFZUg0q2fzZp1cBShV/TYpSR++GJRHPfRmFTBFUpON/ZCauJL86rwWuavStjri4mOLdoRew== X-Received: by 2002:adf:e444:: with SMTP id t4mr11341858wrm.152.1606490080594; Fri, 27 Nov 2020 07:14:40 -0800 (PST) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id j13sm8370481wrp.70.2020.11.27.07.14.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Nov 2020 07:14:39 -0800 (PST) Date: Fri, 27 Nov 2020 16:14:37 +0100 From: Daniel Vetter To: Geert Uytterhoeven Cc: Randy Dunlap , Linux Kernel Mailing List , "David S. Miller" , sparclinux , Tomi Valkeinen , DRI Development , Linux Fbdev development list , Daniel Vetter , David Airlie , Bartlomiej Zolnierkiewicz Subject: Re: [PATCH v2] fbdev: aty: SPARC64 requires FB_ATY_CT Message-ID: <20201127151437.GH401619@phenom.ffwll.local> Mail-Followup-To: Geert Uytterhoeven , Randy Dunlap , Linux Kernel Mailing List , "David S. Miller" , sparclinux , Tomi Valkeinen , DRI Development , Linux Fbdev development list , David Airlie , Bartlomiej Zolnierkiewicz References: <20201127031752.10371-1-rdunlap@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Operating-System: Linux phenom 5.7.0-1-amd64 Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Archived-At: List-Archive: List-Post: On Fri, Nov 27, 2020 at 10:15:49AM +0100, Geert Uytterhoeven wrote: > On Fri, Nov 27, 2020 at 4:18 AM Randy Dunlap wrote: > > It looks like SPARC64 requires FB_ATY_CT to build without errors, > > so have FB_ATY select FB_ATY_CT if both SPARC64 and PCI are enabled > > instead of using "default y if SPARC64 && PCI", which is not strong > > enough to prevent build errors. > > > > As it currently is, FB_ATY_CT can be disabled, resulting in build > > errors: > > > > ERROR: modpost: "aty_postdividers" [drivers/video/fbdev/aty/atyfb.ko] undefined! > > ERROR: modpost: "aty_ld_pll_ct" [drivers/video/fbdev/aty/atyfb.ko] undefined! > > > > Fixes: f7018c213502 ("video: move fbdev to drivers/video/fbdev") > > Signed-off-by: Randy Dunlap > > Reviewed-by: Geert Uytterhoeven Applied to drm-misc-next, thanks for the patch&review. -Daniel > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch