Re: [PATCH v1 02/28] video: fbcon: Use pr_debug() in fbcon

From: Sam Ravnborg <sam@ravnborg.org>
To: Joe Perches <joe@perches.com>
Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
	Lee Jones <lee.jones@linaro.org>, Aditya Pakki <pakki001@umn.edu>,
	Alexander Klimov <grandmaster@al2klimov.de>,
	Alex Dewar <alex.dewar90@gmail.com>,
	Antonino Daplas <adaplas@gmail.com>,
	Arnd Bergmann <arnd@arndb.de>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Daniel Vetter <daniel.vetter@ffwll.ch>,
	Evgeny Novikov <novikov@ispras.ru>,
	Ferenc Bakonyi <fero@drama.obuda.kando.hu>,
	Florian Tobias Schandinat <FlorianSchandinat@gmx.de>,
	George Kennedy <george.kennedy@oracle.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Gustavo Silva <gustavoars@kernel.org>,
	Jani Nikula <jani.nikula@intel.com>,
	Jason Yan <yanaijie@huawei.com>,
	Jingoo Han <jingoohan1@gmail.com>,
	Jiri Slaby <jirislaby@kernel.org>,
	Kristoffer Ericson <kristoffer.ericson@gmail.com>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	linux-nvidia@lists.surfsouth.com,
	Michal Januszewski <spock@gentoo.org>,
	Mike Rapoport <rppt@kernel.org>,
	Nathan Chancellor <natechancellor@gmail.com>,
	Peilin Ye <yepeilin.cs@gmail.com>, Peter Rosin <peda@axentia.se>,
	Qilong Zhang <zhangqilong3@huawei.com>,
	Randy Dunlap <rdunlap@infradead.org>,
	Saeed Mirzamohammadi <saeed.mirzamohammadi@oracle.com>,
	Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
	Thomas Winischhofer <thomas@winischhofer.net>,
	Thomas Zimemrmann <tzimmermann@suse.de>,
	Vaibhav Gupta <vaibhavgupta40@gmail.com>,
	Xiaofei Tan <tanxiaofei@huawei.com>
Subject: Re: [PATCH v1 02/28] video: fbcon: Use pr_debug() in fbcon
Date: Fri, 27 Nov 2020 23:36:15 +0100	[thread overview]
Message-ID: <20201127223615.GA872093@ravnborg.org> (raw)
In-Reply-To: <f8b2737702e295b9f780b98f27faac759ffff7ae.camel@perches.com>

Hi Joe.

On Fri, Nov 27, 2020 at 01:16:41PM -0800, Joe Perches wrote:
> On Fri, 2020-11-27 at 20:57 +0100, Sam Ravnborg wrote:
> > Replacing DPRINTK() statements with pr_debug fixes
> > W=1 warnings.
> > And moves to a more standard logging setup at the same time.
> []
> > diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/core/fbcon.c
> []
> > @@ -1015,9 +1007,9 @@ static const char *fbcon_startup(void)
> >  	rows /= vc->vc_font.height;
> >  	vc_resize(vc, cols, rows);
> >  
> > 
> > -	DPRINTK("mode:   %s\n", info->fix.id);
> > -	DPRINTK("visual: %d\n", info->fix.visual);
> > -	DPRINTK("res:    %dx%d-%d\n", info->var.xres,
> > +	pr_debug("mode:   %s\n", info->fix.id);
> > +	pr_debug("visual: %d\n", info->fix.visual);
> > +	pr_debug("res:    %dx%d-%d\n", info->var.xres,
> >  		info->var.yres,
> >  		info->var.bits_per_pixel);
> 
> It'd be nicer to reindent the subsequent lines too.
> 
> > @@ -3299,7 +3291,7 @@ static void fbcon_exit(void)
> >  
> > 
> >  		if (info->queue.func)
> >  			pending = cancel_work_sync(&info->queue);
> > -		DPRINTK("fbcon: %s pending work\n", (pending ? "canceled" :
> > +		pr_debug("fbcon: %s pending work\n", (pending ? "canceled" :
> >  			"no"));
> 
> perhaps:
> 
> 		pr_debug("fbcon: %s pending work\n", pending ? "canceled" : "no");
> 
Good suggestions, I will update accordingly in v2 or when applying in
case someone acks/r-b's the patches.

	Sam