From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B6EAC3E8C5 for ; Sun, 29 Nov 2020 11:19:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EAA5B20771 for ; Sun, 29 Nov 2020 11:19:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726220AbgK2LTb (ORCPT ); Sun, 29 Nov 2020 06:19:31 -0500 Received: from asavdk3.altibox.net ([109.247.116.14]:50520 "EHLO asavdk3.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726869AbgK2LTb (ORCPT ); Sun, 29 Nov 2020 06:19:31 -0500 Received: from ravnborg.org (unknown [188.228.123.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id 4A88220026; Sun, 29 Nov 2020 12:18:37 +0100 (CET) Date: Sun, 29 Nov 2020 12:18:36 +0100 From: Sam Ravnborg To: Tetsuo Handa Cc: Thomas Zimmermann , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Lee Jones , Aditya Pakki , Alexander Klimov , Alex Dewar , Antonino Daplas , Arnd Bergmann , Bartlomiej Zolnierkiewicz , Benjamin Herrenschmidt , Daniel Vetter , Evgeny Novikov , Florian Tobias Schandinat , George Kennedy , Greg Kroah-Hartman , Gustavo Silva , Jani Nikula , Jason Yan , Jingoo Han , Jiri Slaby , Joe Perches , Kristoffer Ericson , Laurent Pinchart , Mike Rapoport , Nathan Chancellor , Peilin Ye , Peter Rosin , Qilong Zhang , Randy Dunlap , Saeed Mirzamohammadi , Thomas Winischhofer , Vaibhav Gupta , Xiaofei Tan Subject: Re: [PATCH v2 02/28] video: fbcon: Fix warnings by using pr_debug() in fbcon Message-ID: <20201129111836.GA1094053@ravnborg.org> References: <20201128224114.1033617-1-sam@ravnborg.org> <20201128224114.1033617-3-sam@ravnborg.org> <9fbdaff8-18af-223d-6cec-4b44aeb94fec@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=Ibmpp1ia c=1 sm=1 tr=0 a=S6zTFyMACwkrwXSdXUNehg==:117 a=S6zTFyMACwkrwXSdXUNehg==:17 a=8nJEP1OIZ-IA:10 a=-vdMUv8mziTCCqIVOngA:9 a=wPNLvfGTeEIA:10 Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Hi Tetsuo, On Sun, Nov 29, 2020 at 07:28:08PM +0900, Tetsuo Handa wrote: > On 2020/11/29 19:03, Thomas Zimmermann wrote: > > Am 28.11.20 um 23:40 schrieb Sam Ravnborg: > >> Replacing DPRINTK() statements with pr_debug fixes set but not used > >> warnings.  And moves to a more standard logging setup at the same time. > > > > I guess this was added for quick debugging during development. Anyway, I never liked these kinds of hacks. > > > > Acked-by: Thomas Zimmermann > > > > But replacing printk(KERN_DEBUG) with pr_debug() prevents __func__ from being printed > when FBCONDEBUG is defined. Is such change what the author of this module expects? When someone goes and enable DEBUG for fbcon they are also able to recognize the logging, so the printing of the function name is redundant in this case. There is likely limited to no use for these few logging entries, but if they should be dropped then I expect Peilin Ye to do so as he is the only one doing active maintenance of fbcon lately. Sam