From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6784C3E8C5 for ; Sun, 29 Nov 2020 21:46:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6B0E12078D for ; Sun, 29 Nov 2020 21:46:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726293AbgK2VqI (ORCPT ); Sun, 29 Nov 2020 16:46:08 -0500 Received: from asavdk3.altibox.net ([109.247.116.14]:39548 "EHLO asavdk3.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725950AbgK2VqH (ORCPT ); Sun, 29 Nov 2020 16:46:07 -0500 Received: from ravnborg.org (unknown [188.228.123.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id 23BE720031; Sun, 29 Nov 2020 22:45:19 +0100 (CET) Date: Sun, 29 Nov 2020 22:45:17 +0100 From: Sam Ravnborg To: Thomas Zimmermann Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Lee Jones , Vaibhav Gupta , Tetsuo Handa , Laurent Pinchart , Jiri Slaby , Arnd Bergmann , Florian Tobias Schandinat , Evgeny Novikov , Saeed Mirzamohammadi , Daniel Vetter , Thomas Winischhofer , Bartlomiej Zolnierkiewicz , Jani Nikula , Aditya Pakki , Xiaofei Tan , Nathan Chancellor , Alex Dewar , Jason Yan , Greg Kroah-Hartman , Qilong Zhang , Randy Dunlap , Gustavo Silva , Peter Rosin , George Kennedy , Kristoffer Ericson , Alexander Klimov , Jingoo Han , Joe Perches , Peilin Ye , Mike Rapoport Subject: Re: [PATCH v2 02/28] video: fbcon: Fix warnings by using pr_debug() in fbcon Message-ID: <20201129214517.GC1162850@ravnborg.org> References: <20201128224114.1033617-1-sam@ravnborg.org> <20201128224114.1033617-3-sam@ravnborg.org> <9fbdaff8-18af-223d-6cec-4b44aeb94fec@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9fbdaff8-18af-223d-6cec-4b44aeb94fec@suse.de> X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=Ibmpp1ia c=1 sm=1 tr=0 a=S6zTFyMACwkrwXSdXUNehg==:117 a=S6zTFyMACwkrwXSdXUNehg==:17 a=kj9zAlcOel0A:10 a=7gkXJVJtAAAA:8 a=IJv9LcIfAAAA:8 a=ag1SF4gXAAAA:8 a=hD80L64hAAAA:8 a=VwQbUJbxAAAA:8 a=pGLkceISAAAA:8 a=yPCof4ZbAAAA:8 a=3hxhl-9mIZOli96NArIA:9 a=CjuIK1q_8ugA:10 a=E9Po1WZjFZOl8hwRPBS3:22 a=cmr4hm9N53k6aw-X_--Q:22 a=Yupwre4RP9_Eg_Bd0iYG:22 a=AjGcO6oz07-iQ99wixmX:22 Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org On Sun, Nov 29, 2020 at 11:03:25AM +0100, Thomas Zimmermann wrote: > > > Am 28.11.20 um 23:40 schrieb Sam Ravnborg: > > Replacing DPRINTK() statements with pr_debug fixes set but not used > > warnings. And moves to a more standard logging setup at the same time. > > > > v2: > > - Fix indent (Joe) > > > > Signed-off-by: Sam Ravnborg > > Cc: Joe Perches > > Cc: Greg Kroah-Hartman > > Cc: Daniel Vetter > > Cc: Bartlomiej Zolnierkiewicz > > Cc: Sam Ravnborg > > Cc: Jiri Slaby > > Cc: Peilin Ye > > Cc: Tetsuo Handa > > Cc: George Kennedy > > Cc: Nathan Chancellor > > Cc: Peter Rosin > > --- > > drivers/video/fbdev/core/fbcon.c | 25 ++++++++----------------- > > 1 file changed, 8 insertions(+), 17 deletions(-) > > > > diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/core/fbcon.c > > index bf61598bf1c3..44a5cd2f54cc 100644 > > --- a/drivers/video/fbdev/core/fbcon.c > > +++ b/drivers/video/fbdev/core/fbcon.c > > @@ -56,8 +56,6 @@ > > * more details. > > */ > > -#undef FBCONDEBUG > > - > > I guess this was added for quick debugging during development. Anyway, I > never liked these kinds of hacks. > > Acked-by: Thomas Zimmermann Thanks, applied to drm-misc-next. Sam