From: carlis <zhangxuezhi3@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: devel@driverdev.osuosl.org, linux-fbdev@vger.kernel.org,
mh12gx2825@gmail.com, oliver.graute@kococonnector.com,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
sbrivio@redhat.com, colin.king@canonical.com,
zhangxuezhi1@yulong.com
Subject: Re: [PATCH v10] staging: fbtft: add tearing signal detect
Date: Wed, 27 Jan 2021 22:17:08 +0800 [thread overview]
Message-ID: <20210127221708.00002568@gmail.com> (raw)
In-Reply-To: <YBF08Xf7qaZx3YZ1@kroah.com>
On Wed, 27 Jan 2021 15:13:05 +0100
Greg KH <gregkh@linuxfoundation.org> wrote:
> On Wed, Jan 27, 2021 at 10:08:09PM +0800, carlis wrote:
> > On Wed, 27 Jan 2021 14:51:55 +0100
> > Greg KH <gregkh@linuxfoundation.org> wrote:
> >
> > > On Wed, Jan 27, 2021 at 09:42:52PM +0800, Carlis wrote:
> > > > From: zhangxuezhi <zhangxuezhi1@yulong.com>
> > > >
> > > > For st7789v ic,when we need continuous full screen refresh, it
> > > > is best to wait for the TE signal arrive to avoid screen tearing
> > > >
> > > > Signed-off-by: zhangxuezhi <zhangxuezhi1@yulong.com>
> > >
> > > Please slow down and wait at least a day between patch
> > > submissions, there is no rush here.
> > >
> > > And also, ALWAYS run scripts/checkpatch.pl on your submissions, so
> > > that you don't have a maintainer asking you about basic problems,
> > > like are in this current patch :(
> > >
> > > thanks,
> > >
> > > greg k-h
> >
> > hi,
> > This is my first patch contribution to Linux, so some of the rules
> > are not very clear .In addition, I can confirm that before sending
> > patch, I check it with checkPatch.py every time.Thank you very much
> > for your help
>
> Please read Documentation/SubmittingPatches which has a link to the
> checklist and other documentation you should read.
>
> And I doubt you are running checkpatch on your submission, as there is
> obvious coding style issues in it. If so, please provide the output
> as it must be broken :(
>
> thanks,
>
> greg k-h
hi, the patch v11 checkpatch.pl output is below:
carlis@bf-rmsz-10:~/work/linux-kernel/linux$ ./scripts/checkpatch.pl
0001-staging-fbtft-add-tearing-signal-detect.patch total: 0 errors, 0
warnings, 0 checks, 176 lines checked
0001-staging-fbtft-add-tearing-signal-detect.patch has no obvious style
problems and is ready for submission.
regards
zhangxuezhi
next prev parent reply other threads:[~2021-01-27 14:20 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-27 13:42 [PATCH v10] staging: fbtft: add tearing signal detect Carlis
2021-01-27 13:51 ` Greg KH
2021-01-27 14:08 ` carlis
2021-01-27 14:13 ` Greg KH
2021-01-27 14:17 ` carlis [this message]
2021-01-27 14:25 ` Greg KH
2021-01-27 14:49 ` Dan Carpenter
2021-01-27 15:02 ` Greg KH
2021-01-28 1:12 ` carlis
2021-01-27 17:42 ` Joe Perches
2021-01-27 18:21 ` Joe Perches
2021-01-27 22:32 ` Kari Argillander
2021-01-28 1:42 ` carlis
2021-01-28 6:52 ` Kari Argillander
2021-01-28 9:24 ` carlis
2021-01-28 9:42 ` Geert Uytterhoeven
2021-01-28 9:59 ` Kari Argillander
2021-01-28 11:03 ` carlis
2021-01-28 11:15 ` Geert Uytterhoeven
2021-01-28 11:42 ` carlis
2021-01-28 15:13 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210127221708.00002568@gmail.com \
--to=zhangxuezhi3@gmail.com \
--cc=colin.king@canonical.com \
--cc=devel@driverdev.osuosl.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mh12gx2825@gmail.com \
--cc=oliver.graute@kococonnector.com \
--cc=sbrivio@redhat.com \
--cc=zhangxuezhi1@yulong.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).