From: kernel test robot <lkp@intel.com>
To: Mayank Suman <mayanksuman@live.com>,
gregkh@linuxfoundation.org, sfr@canb.auug.org.au,
dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
linux-kernel-mentees@lists.linuxfoundation.org
Cc: kbuild-all@lists.01.org, clang-built-linux@googlegroups.com
Subject: Re: [PATCH] staging: fbtft replaced udelay with usleep_range
Date: Fri, 5 Feb 2021 20:33:56 +0800 [thread overview]
Message-ID: <202102052010.6AbTIFWW-lkp@intel.com> (raw)
In-Reply-To: <PS1PR04MB29341C7117657B1F312444FBD6B29@PS1PR04MB2934.apcprd04.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 4766 bytes --]
Hi Mayank,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on staging/staging-testing]
url: https://github.com/0day-ci/linux/commits/Mayank-Suman/staging-fbtft-replaced-udelay-with-usleep_range/20210205-171807
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git 06b0c0dce88e2aa2f01343db0f26d214d7f264a0
config: arm64-randconfig-r025-20210205 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project c9439ca36342fb6013187d0a69aef92736951476)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm64 cross compiling tool for clang build
# apt-get install binutils-aarch64-linux-gnu
# https://github.com/0day-ci/linux/commit/4a777af1cc91dc603b6b92fe06fd94081dc2891e
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Mayank-Suman/staging-fbtft-replaced-udelay-with-usleep_range/20210205-171807
git checkout 4a777af1cc91dc603b6b92fe06fd94081dc2891e
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
>> drivers/staging/fbtft/fb_ra8875.c:220:18: error: too few arguments to function call, expected 2, have 1
usleep_range(100);
~~~~~~~~~~~~ ^
include/linux/delay.h:61:6: note: 'usleep_range' declared here
void usleep_range(unsigned long min, unsigned long max);
^
drivers/staging/fbtft/fb_ra8875.c:241:18: error: too few arguments to function call, expected 2, have 1
usleep_range(100);
~~~~~~~~~~~~ ^
include/linux/delay.h:61:6: note: 'usleep_range' declared here
void usleep_range(unsigned long min, unsigned long max);
^
2 errors generated.
--
>> drivers/staging/fbtft/fb_tinylcd.c:44:18: error: too few arguments to function call, expected 2, have 1
usleep_range(250);
~~~~~~~~~~~~ ^
include/linux/delay.h:61:6: note: 'usleep_range' declared here
void usleep_range(unsigned long min, unsigned long max);
^
1 error generated.
--
>> drivers/staging/fbtft/fb_watterott.c:87:19: error: too few arguments to function call, expected 2, have 1
usleep_range(300);
~~~~~~~~~~~~ ^
include/linux/delay.h:61:6: note: 'usleep_range' declared here
void usleep_range(unsigned long min, unsigned long max);
^
drivers/staging/fbtft/fb_watterott.c:127:19: error: too few arguments to function call, expected 2, have 1
usleep_range(700);
~~~~~~~~~~~~ ^
include/linux/delay.h:61:6: note: 'usleep_range' declared here
void usleep_range(unsigned long min, unsigned long max);
^
2 errors generated.
vim +220 drivers/staging/fbtft/fb_ra8875.c
189
190 static void write_reg8_bus8(struct fbtft_par *par, int len, ...)
191 {
192 va_list args;
193 int i, ret;
194 u8 *buf = par->buf;
195
196 /* slow down spi-speed for writing registers */
197 par->fbtftops.write = write_spi;
198
199 if (unlikely(par->debug & DEBUG_WRITE_REGISTER)) {
200 va_start(args, len);
201 for (i = 0; i < len; i++)
202 buf[i] = (u8)va_arg(args, unsigned int);
203 va_end(args);
204 fbtft_par_dbg_hex(DEBUG_WRITE_REGISTER, par, par->info->device,
205 u8, buf, len, "%s: ", __func__);
206 }
207
208 va_start(args, len);
209 *buf++ = 0x80;
210 *buf = (u8)va_arg(args, unsigned int);
211 ret = par->fbtftops.write(par, par->buf, 2);
212 if (ret < 0) {
213 va_end(args);
214 dev_err(par->info->device, "write() failed and returned %dn",
215 ret);
216 return;
217 }
218 len--;
219
> 220 usleep_range(100);
221
222 if (len) {
223 buf = (u8 *)par->buf;
224 *buf++ = 0x00;
225 i = len;
226 while (i--)
227 *buf++ = (u8)va_arg(args, unsigned int);
228
229 ret = par->fbtftops.write(par, par->buf, len + 1);
230 if (ret < 0) {
231 va_end(args);
232 dev_err(par->info->device,
233 "write() failed and returned %dn", ret);
234 return;
235 }
236 }
237 va_end(args);
238
239 /* restore user spi-speed */
240 par->fbtftops.write = fbtft_write_spi;
241 usleep_range(100);
242 }
243
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 33407 bytes --]
prev parent reply other threads:[~2021-02-05 12:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-05 9:11 [PATCH] staging: fbtft replaced udelay with usleep_range Mayank Suman
2021-02-05 9:32 ` Greg KH
2021-02-05 11:42 ` kernel test robot
2021-02-05 12:33 ` kernel test robot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202102052010.6AbTIFWW-lkp@intel.com \
--to=lkp@intel.com \
--cc=clang-built-linux@googlegroups.com \
--cc=devel@driverdev.osuosl.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=kbuild-all@lists.01.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mayanksuman@live.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).