From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A080C433E0 for ; Wed, 10 Feb 2021 16:13:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 678F564E76 for ; Wed, 10 Feb 2021 16:13:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232112AbhBJQNr (ORCPT ); Wed, 10 Feb 2021 11:13:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35690 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232009AbhBJQNo (ORCPT ); Wed, 10 Feb 2021 11:13:44 -0500 Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [IPv6:2a00:1450:4864:20::32b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 373B6C06174A for ; Wed, 10 Feb 2021 08:13:03 -0800 (PST) Received: by mail-wm1-x32b.google.com with SMTP id y134so2303720wmd.3 for ; Wed, 10 Feb 2021 08:13:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=9EqkICeAqFea9hutcJE8LTJk6fkCLGfHmOvQQmMvAJM=; b=Hh49I+GceO/gmkekotuymhn3rjlU3YIypVisjoLOygTP1mgYBpzmbiY1B+Z5kDHv1H X+1p+H/pZbOPlldO65mL33J/nmB6ms47MC+u60d9S34oT4MiRfwDpZZWh/qETmt/Om/y olUsvQGKt/zp/HREvWDezf3EVhY9WQSBDq//vrYo+RtlXuw1teA/flfEzF4rT2UCYUo6 WEyPCuv9rP7JAXB7hd4Zk5CXQfiPo2bj7YDV4C/V4SfKbO6gG7O8nWSxiVamK32i6r03 Vi1DcAM4Whf1JnAWKjVWawTmQnF73oyA7TPneeQ1mIDpdIwY/evQfcTuEdgRAkLg3tZr f/6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=9EqkICeAqFea9hutcJE8LTJk6fkCLGfHmOvQQmMvAJM=; b=i7fO/JwM+krwQwRemJeAtAd79LDhd34Ngc82UcBbCje2XlCOALZLJHkmIBvG/Npe5B Jm9tasqsROFSG2z3Qsp8D+0hASzMcpt+EIuo/vhGmaXpa3y0JOLgH2adcVT2WDauNtlQ bHNUgwiw6bEMlDSLV0KiPFsqexlA0HE4qhoLMyafgouJbqfncrQW6SYsLVMAISxunE/O AjJ17Kn58LcZq3kbipFBtnROaOqbbGEZlwmdLheGAKtImiAHosKBYDEDMnm0rSPCDWny iIORRTyIbjpXC1TCIuCz45g1CQ3H9XdmkUeKQn/X+as5KY1D32oy/49PHkqU9k97dKXI l5hA== X-Gm-Message-State: AOAM531R93dgGNqAC9qgrxJT3iqwqdOscpnMiQZNmEba2csMdE7BZ0iF EPLGf/TaXINkGDojjfz8uxZDMg== X-Google-Smtp-Source: ABdhPJxwjN9tnOjYE29ii/KagRZk+egL7JyD+GF9hT3oJWkCY7DOqROK+nqMjm3eItHTGs95G9LYOA== X-Received: by 2002:a05:600c:216:: with SMTP id 22mr3432179wmi.111.1612973581930; Wed, 10 Feb 2021 08:13:01 -0800 (PST) Received: from x1 ([91.110.221.237]) by smtp.gmail.com with ESMTPSA id x9sm3275333wmb.14.2021.02.10.08.12.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Feb 2021 08:13:00 -0800 (PST) Date: Wed, 10 Feb 2021 16:12:58 +0000 From: Lee Jones To: Julia Lawall , Daniel Thompson , linux-kernel@vger.kernel.org, Pengutronix Kernel Team , Jingoo Han , Sascha Hauer , kernel-janitors@vger.kernel.org, Michal Simek , dri-devel@lists.freedesktop.org, Bjorn Andersson , Andy Gross , NXP Linux Team , linux-fbdev@vger.kernel.org, linux-arm-msm@vger.kernel.org, Shawn Guo , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] video: use getter/setter functions Message-ID: <20210210161258.GA124276@x1> References: <20210209211325.1261842-1-Julia.Lawall@inria.fr> <20210210082341.GH220368@dell> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org On Wed, 10 Feb 2021, Daniel Vetter wrote: > On Wed, Feb 10, 2021 at 08:23:41AM +0000, Lee Jones wrote: > > On Tue, 09 Feb 2021, Julia Lawall wrote: > > > > > Use getter and setter functions, for platform_device structures and a > > > spi_device structure. > > > > > > Signed-off-by: Julia Lawall > > > > > > --- > > > drivers/video/backlight/qcom-wled.c | 2 +- > > > > This patch is fine. > > > > Could you please split it out and submit it separately though please. > > Or just apply the entire patch through backlight tree, there's nothing > going on in fbdev anyway I think. > > Acked-by: Daniel Vetter I can do that. Is that an fbdev Ack? > > > drivers/video/fbdev/amifb.c | 4 ++-- > > > drivers/video/fbdev/da8xx-fb.c | 4 ++-- > > > drivers/video/fbdev/imxfb.c | 2 +- > > > drivers/video/fbdev/omap2/omapfb/displays/panel-lgphilips-lb035q02.c | 6 +++--- > > > drivers/video/fbdev/omap2/omapfb/dss/dpi.c | 4 ++-- > > > drivers/video/fbdev/omap2/omapfb/dss/dsi.c | 4 ++-- > > > drivers/video/fbdev/omap2/omapfb/dss/hdmi4.c | 2 +- > > > drivers/video/fbdev/omap2/omapfb/dss/hdmi5.c | 2 +- > > > drivers/video/fbdev/xilinxfb.c | 2 +- > > > 10 files changed, 16 insertions(+), 16 deletions(-) > > > > ...] > > > > > diff --git a/drivers/video/backlight/qcom-wled.c b/drivers/video/backlight/qcom-wled.c > > > index 3bc7800eb0a9..091f07e7c145 100644 > > > --- a/drivers/video/backlight/qcom-wled.c > > > +++ b/drivers/video/backlight/qcom-wled.c > > > @@ -1692,7 +1692,7 @@ static int wled_probe(struct platform_device *pdev) > > > > > > static int wled_remove(struct platform_device *pdev) > > > { > > > - struct wled *wled = dev_get_drvdata(&pdev->dev); > > > + struct wled *wled = platform_get_drvdata(pdev); > > > > > > mutex_destroy(&wled->lock); > > > cancel_delayed_work_sync(&wled->ovp_work); > > > > For my own reference (apply this as-is to your sign-off block): > > > > Acked-for-Backlight-by: Lee Jones > > > -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog