From: Kumar Kartikeya Dwivedi <memxor@gmail.com>
To: Alex Elder <elder@ieee.org>
Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org, Ian Abbott <abbotti@mev.co.uk>,
H Hartley Sweeten <hsweeten@visionengravers.com>,
Ioana Radulescu <ruxandra.radulescu@nxp.com>,
Ioana Ciornei <ioana.ciornei@nxp.com>,
Johan Hovold <johan@kernel.org>, Alex Elder <elder@kernel.org>,
Vaibhav Agarwal <vaibhav.sr@gmail.com>,
Mark Greer <mgreer@animalcreek.com>,
Rui Miguel Silva <rmfrfs@gmail.com>,
Viresh Kumar <vireshk@kernel.org>,
Marc Dietrich <marvin24@gmx.de>,
Jens Frederich <jfrederich@gmail.com>,
Daniel Drake <dsd@laptop.org>,
Jon Nettleton <jon.nettleton@gmail.com>,
Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Teddy Wang <teddy.wang@siliconmotion.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Andrew Morton <akpm@linux-foundation.org>,
Florian Fainelli <f.fainelli@gmail.com>,
Al Viro <viro@zeniv.linux.org.uk>,
William Cohen <wcohen@redhat.com>,
Mike Rapoport <rppt@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Robert Richter <rric@kernel.org>,
greybus-dev@lists.linaro.org, ac100@lists.launchpad.net,
linux-tegra@vger.kernel.org, linux-fbdev@vger.kernel.org
Subject: Re: [PATCH 02/13] staging: greybus: Switch from strlcpy to strscpy
Date: Tue, 16 Feb 2021 21:18:00 +0530 [thread overview]
Message-ID: <20210216154800.jg24ahfj52t6qgbd@apollo> (raw)
In-Reply-To: <b565bdae-10a9-9b6c-ae60-dcee88f7dedd@ieee.org>
On Tue, Feb 16, 2021 at 08:24:59PM IST, Alex Elder wrote:
> This is a good change. But while you're at it, I would
> appreciate if you would convert a few spots to use
> sizeof(dest) rather than a fixed constant. I will
> point them out below.
>
> If this is the *only* request for a change on your
> series, please tell me that and I can sign off on
So far, this has been the only request.
> this without you implementing my suggestion. But
> if you post a version 2, please do what I describe.
>
I will incorporate these if I end up sending a v2.
Alternatively, would a separate patch with your suggestions applied on top of
this be acceptable, if I don't?
--
Kartikeya
next prev parent reply other threads:[~2021-02-16 15:49 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-31 17:28 [PATCH 00/13] Convert all users of strlcpy to strscpy Kumar Kartikeya Dwivedi
2021-01-31 17:28 ` [PATCH 01/13] staging: comedi: Switch from " Kumar Kartikeya Dwivedi
2021-01-31 17:28 ` [PATCH 02/13] staging: greybus: " Kumar Kartikeya Dwivedi
2021-02-16 14:54 ` Alex Elder
2021-02-16 15:48 ` Kumar Kartikeya Dwivedi [this message]
2021-02-16 15:49 ` Alex Elder
2021-01-31 17:28 ` [PATCH 03/13] staging: fsl-dpaa2: " Kumar Kartikeya Dwivedi
2021-01-31 17:28 ` [PATCH 04/13] staging: most: " Kumar Kartikeya Dwivedi
2021-01-31 17:28 ` [PATCH 05/13] staging: nvec: " Kumar Kartikeya Dwivedi
2021-01-31 17:28 ` [PATCH 06/13] staging: octeon: " Kumar Kartikeya Dwivedi
2021-02-16 14:36 ` Robert Richter
2021-01-31 17:28 ` [PATCH 07/13] staging: olpc_dcon: " Kumar Kartikeya Dwivedi
2021-01-31 17:28 ` [PATCH 08/13] staging: rtl8188eu: " Kumar Kartikeya Dwivedi
2021-01-31 17:28 ` [PATCH 09/13] staging: rtl8192e: " Kumar Kartikeya Dwivedi
2021-01-31 17:28 ` [PATCH 10/13] staging: rtl8192u: " Kumar Kartikeya Dwivedi
2021-01-31 17:28 ` [PATCH 11/13] staging: rtl8712: " Kumar Kartikeya Dwivedi
2021-01-31 17:28 ` [PATCH 12/13] staging: sm750fb: " Kumar Kartikeya Dwivedi
2021-01-31 17:28 ` [PATCH 13/13] staging: wimax: " Kumar Kartikeya Dwivedi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210216154800.jg24ahfj52t6qgbd@apollo \
--to=memxor@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=abbotti@mev.co.uk \
--cc=ac100@lists.launchpad.net \
--cc=akpm@linux-foundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=dsd@laptop.org \
--cc=elder@ieee.org \
--cc=elder@kernel.org \
--cc=f.fainelli@gmail.com \
--cc=florian.c.schilhabel@googlemail.com \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=hsweeten@visionengravers.com \
--cc=ioana.ciornei@nxp.com \
--cc=jfrederich@gmail.com \
--cc=johan@kernel.org \
--cc=jon.nettleton@gmail.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=marvin24@gmx.de \
--cc=mgreer@animalcreek.com \
--cc=rmfrfs@gmail.com \
--cc=rppt@kernel.org \
--cc=rric@kernel.org \
--cc=ruxandra.radulescu@nxp.com \
--cc=sfr@canb.auug.org.au \
--cc=sudipm.mukherjee@gmail.com \
--cc=teddy.wang@siliconmotion.com \
--cc=tglx@linutronix.de \
--cc=vaibhav.sr@gmail.com \
--cc=vireshk@kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=wcohen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).