From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E8EEC433DB for ; Fri, 26 Feb 2021 17:10:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5753964EE7 for ; Fri, 26 Feb 2021 17:10:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229618AbhBZRKK (ORCPT ); Fri, 26 Feb 2021 12:10:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57668 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230049AbhBZRKB (ORCPT ); Fri, 26 Feb 2021 12:10:01 -0500 Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DBA3FC06174A for ; Fri, 26 Feb 2021 09:09:08 -0800 (PST) Received: by mail-wm1-x32c.google.com with SMTP id p3so8002463wmc.2 for ; Fri, 26 Feb 2021 09:09:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=oPmNNtgVI1eH+eqDytkra/zaGpGkiEOuBv8E+PK1q2E=; b=L7hDueq6FbCIPz8Y3pcSNYtyDe8eNaCraw1jcrjoeS23ebZwbWTe2IvnUl3GTrNLmq dp/21SOTMaADDXil2WuhCsxvlC5Bd8t6Q0CQjJBwgdkDx6CfVANpZLQhHs7HuFp/tUKp ugk+lZE1L3c+edikdt8ARj5u40FArM+iVyHpBjX8Uv1EsQ60LVXZpBDQQ8fdHQnKZfNz cTjpmuu4CpOZKv6UhEPfmTf1zEiyzlIUG2JkbTKRtqrdRvBv5kIBCgG2Genf1uTGFD+J sm4ouIPR9uM8KYMJ6DojeiG7g8mio0pX6cOcHUcdrBSc1xVMNbSKwqDTO5CEYpuya8rP U7mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=oPmNNtgVI1eH+eqDytkra/zaGpGkiEOuBv8E+PK1q2E=; b=unJUfJmhpSH2jDZXqXXpO7YrHRyDTRq3/K6r1Kj0CsboHNP/+r3QQJtdoOw+1bYOWy lY1pk0VXeQ/2O5ZYZslJ91ca+ovM1TaBQaIW2SWUgsv2T0IBtMBeeVnz5EQB4Y/DzTBl 5JN3mAQwvAlwXe9rI31pHttkviizavk6yvfLAVsZYqfYIdV7WWtGpd7L0BL5G9jBXTM1 VtxGXF9nkt86kRIfF9OT/7p0n/k0wJvYT2QykiBusUtKri5RvqJ9GblHoonGhvdbqIvi /ffqdRbdJLzfpYBdy8HJlJePFJyk54BydazgBa5CKGSitTDh7x3VrFwHHLDv+aojC1O9 9pTQ== X-Gm-Message-State: AOAM5323CXR1duP/NvbcwRkdd6Ig+kii+gIQf1OMJwCfsvhz/5TEhB+p snikmb5n6CXI9rwiGCLRKKRF7i4TRzqfYkVL X-Google-Smtp-Source: ABdhPJy+3JLr8vLHWKe27u3nSTX1ODTzNCh6BSKvpoFvfptBEwnzyGPmA8wyoRhYBiUAbOt8tHcXWw== X-Received: by 2002:a1c:5584:: with SMTP id j126mr3925587wmb.153.1614359347431; Fri, 26 Feb 2021 09:09:07 -0800 (PST) Received: from maple.lan (cpc141216-aztw34-2-0-cust174.18-1.cable.virginm.net. [80.7.220.175]) by smtp.gmail.com with ESMTPSA id m9sm19290337wml.3.2021.02.26.09.09.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Feb 2021 09:09:06 -0800 (PST) Date: Fri, 26 Feb 2021 17:09:04 +0000 From: Daniel Thompson To: Kiran Gunda Cc: bjorn.andersson@linaro.org, jingoohan1@gmail.com, lee.jones@linaro.org, b.zolnierkie@samsung.com, dri-devel@lists.freedesktop.org, jacek.anaszewski@gmail.com, pavel@ucw.cz, robh+dt@kernel.org, mark.rutland@arm.com, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Andy Gross , linux-arm-msm@vger.kernel.org, linux-fbdev@vger.kernel.org, phone-devel@vger.kernel.org Subject: Re: [PATCH V2 1/2] backlight: qcom-wled: Fix FSC update issue for WLED5 Message-ID: <20210226170904.u5ysz6kg4tqbh3us@maple.lan> References: <1614341544-5306-1-git-send-email-kgunda@codeaurora.org> <1614341544-5306-2-git-send-email-kgunda@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1614341544-5306-2-git-send-email-kgunda@codeaurora.org> Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org On Fri, Feb 26, 2021 at 05:42:23PM +0530, Kiran Gunda wrote: > Currently, for WLED5, the FSC (Full scale current) setting is not > updated properly due to driver toggling the wrong register after > an FSC update. > > On WLED5 we should only toggle the MOD_SYNC bit after a brightness > update. For an FSC update we need to toggle the SYNC bits instead. > > Fix it by adopting the common wled3_sync_toggle() for WLED5 and > introducing new code to the brightness update path to compensate. > > Signed-off-by: Kiran Gunda Reviewed-by: Daniel Thompson Daniel. > --- > drivers/video/backlight/qcom-wled.c | 25 +++++++++++++++++++------ > 1 file changed, 19 insertions(+), 6 deletions(-) > > diff --git a/drivers/video/backlight/qcom-wled.c b/drivers/video/backlight/qcom-wled.c > index 3bc7800..aef52b9 100644 > --- a/drivers/video/backlight/qcom-wled.c > +++ b/drivers/video/backlight/qcom-wled.c > @@ -348,7 +348,7 @@ static int wled3_sync_toggle(struct wled *wled) > return rc; > } > > -static int wled5_sync_toggle(struct wled *wled) > +static int wled5_mod_sync_toggle(struct wled *wled) > { > int rc; > u8 val; > @@ -445,10 +445,23 @@ static int wled_update_status(struct backlight_device *bl) > goto unlock_mutex; > } > > - rc = wled->wled_sync_toggle(wled); > - if (rc < 0) { > - dev_err(wled->dev, "wled sync failed rc:%d\n", rc); > - goto unlock_mutex; > + if (wled->version < 5) { > + rc = wled->wled_sync_toggle(wled); > + if (rc < 0) { > + dev_err(wled->dev, "wled sync failed rc:%d\n", rc); > + goto unlock_mutex; > + } > + } else { > + /* > + * For WLED5 toggling the MOD_SYNC_BIT updates the > + * brightness > + */ > + rc = wled5_mod_sync_toggle(wled); > + if (rc < 0) { > + dev_err(wled->dev, "wled mod sync failed rc:%d\n", > + rc); > + goto unlock_mutex; > + } > } > } > > @@ -1459,7 +1472,7 @@ static int wled_configure(struct wled *wled) > size = ARRAY_SIZE(wled5_opts); > *cfg = wled5_config_defaults; > wled->wled_set_brightness = wled5_set_brightness; > - wled->wled_sync_toggle = wled5_sync_toggle; > + wled->wled_sync_toggle = wled3_sync_toggle; > wled->wled_cabc_config = wled5_cabc_config; > wled->wled_ovp_delay = wled5_ovp_delay; > wled->wled_auto_detection_required = > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project >