archive mirror
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <>
Cc: Greg Kroah-Hartman <>,,
	Geert Uytterhoeven <>,
	Randy Dunlap <>,
	"David S. Miller" <>,,
	Tomi Valkeinen <>,,,
	Daniel Vetter <>,
	David Airlie <>,
	Bartlomiej Zolnierkiewicz <>,
	Geert Uytterhoeven <>,
	Sasha Levin <>
Subject: [PATCH 5.4 070/340] fbdev: aty: SPARC64 requires FB_ATY_CT
Date: Mon,  1 Mar 2021 17:10:14 +0100	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

From: Randy Dunlap <>

[ Upstream commit c6c90c70db4d9a0989111d6b994d545659410f7a ]

It looks like SPARC64 requires FB_ATY_CT to build without errors,
so have FB_ATY select FB_ATY_CT if both SPARC64 and PCI are enabled
instead of using "default y if SPARC64 && PCI", which is not strong
enough to prevent build errors.

As it currently is, FB_ATY_CT can be disabled, resulting in build

ERROR: modpost: "aty_postdividers" [drivers/video/fbdev/aty/atyfb.ko] undefined!
ERROR: modpost: "aty_ld_pll_ct" [drivers/video/fbdev/aty/atyfb.ko] undefined!

Reviewed-by: Geert Uytterhoeven <>
Fixes: f7018c213502 ("video: move fbdev to drivers/video/fbdev")
Signed-off-by: Randy Dunlap <>
Cc: "David S. Miller" <>
Cc: Tomi Valkeinen <>
Cc: Daniel Vetter <>
Cc: David Airlie <>
Cc: Bartlomiej Zolnierkiewicz <>
Cc: Geert Uytterhoeven <>
Signed-off-by: Daniel Vetter <>
Signed-off-by: Sasha Levin <>
 drivers/video/fbdev/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig
index 1e70e838530ee..a7e5f12687b70 100644
--- a/drivers/video/fbdev/Kconfig
+++ b/drivers/video/fbdev/Kconfig
@@ -1269,6 +1269,7 @@ config FB_ATY
 	select FB_MACMODES if PPC
+	select FB_ATY_CT if SPARC64 && PCI
 	  This driver supports graphics boards with the ATI Mach64 chips.
 	  Say Y if you have such a graphics board.
@@ -1279,7 +1280,6 @@ config FB_ATY
 config FB_ATY_CT
 	bool "Mach64 CT/VT/GT/LT (incl. 3D RAGE) support"
 	depends on PCI && FB_ATY
-	default y if SPARC64 && PCI
 	  Say Y here to support use of ATI's 64-bit Rage boards (or other
 	  boards based on the Mach64 CT, VT, GT, and LT chipsets) as a

           reply	other threads:[~2021-03-01 17:35 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH 5.4 070/340] fbdev: aty: SPARC64 requires FB_ATY_CT' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).