From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HK_RANDOM_FROM,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1C9AC433B4 for ; Fri, 16 Apr 2021 07:28:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A8E7361027 for ; Fri, 16 Apr 2021 07:28:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239137AbhDPH2Z (ORCPT ); Fri, 16 Apr 2021 03:28:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34258 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231666AbhDPH2Z (ORCPT ); Fri, 16 Apr 2021 03:28:25 -0400 Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [IPv6:2a00:1450:4864:20::632]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A2C0FC061574; Fri, 16 Apr 2021 00:27:59 -0700 (PDT) Received: by mail-ej1-x632.google.com with SMTP id l4so40641523ejc.10; Fri, 16 Apr 2021 00:27:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=uIAH1plO3MN4SRUjVKd4kP8g31/+FxJs1fOzDsYlCbo=; b=N6uGgQO8+cLVzD/QgDSA5V7zSmM9UIFDjyJzz2OmlxctfAJ1lC8JM/97knIOwmw0K9 r0vWmDeEsfxNSRtooUNDvJdOqIi/VDZQfXZJJvSgF6sq9H7cGZGCxjjCFS7gOSn5mIs/ W/NGSe/Mqvdm5gp1xlkb6mZqg9jRK6TP5WD4d9xO79DJgtdQHKujPzuvmBsfiYn9+N0Q t7CvW3g2kqIqRNiA952nUUEuFrSHCmSGxfTQqyxx0Dd8Txy6tyaRZlY7QEB3gxUb8cAF 2uRbVoDhe+yVdFhaVbzgmUhjQRZCKQuJWWTkZumJO5AMpTjz6xM4fydiAFSOzQx118vq 7SQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=uIAH1plO3MN4SRUjVKd4kP8g31/+FxJs1fOzDsYlCbo=; b=FSltQiaQQ8zO41idzEEafBbHySib5yQr+UB4Xtv583EAcNfjqEL2eJkxKrY0WAJh3O HiGjMQ+UZxGAswryah1a3hU3O/YZOq0FIIduSp0v+Y9foCz8efWPatH9UcrlyYT+afXh lrAmaXzfFkCsqbssgvdw5L8QKOjsPMKPDJmsmqsD+bjyrQp+Q7OTvdLVbqTkRhlK+Wma PFBukK8qLql7sO/gLMYOTVQZz6nlCNrr8Oj26b4hZ2Z6RVkfjH8orPVtZZmLSoVd2/W5 EBfIZ18n27wzmba1nSm18Hr1oeQb2XXNGKmEjfr/BUIwlWqn2lXMolb3mP3feBmnu5Ht 1mtA== X-Gm-Message-State: AOAM531BVQ1L8+2PuDNiFAGmPb914B2giSOL9MEPAxbk7Za4jN6TcGWj QWlDOtgPJVFn/jErYuVcf3mL63lqNRA= X-Google-Smtp-Source: ABdhPJwpTyTaQDc+EbhpxL8tFd56oLWRh0t8z7AnP8xqKqmpD6luDMq0WqTz/Ca/WfMV75lvMvKyQw== X-Received: by 2002:a17:907:3f08:: with SMTP id hq8mr7264695ejc.90.1618558078374; Fri, 16 Apr 2021 00:27:58 -0700 (PDT) Received: from agape.jhs ([5.171.81.105]) by smtp.gmail.com with ESMTPSA id bh14sm3577410ejb.104.2021.04.16.00.27.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Apr 2021 00:27:57 -0700 (PDT) Date: Fri, 16 Apr 2021 09:27:51 +0200 From: Fabio Aiuto To: Lee Jones Cc: linux-kernel@vger.kernel.org, ac100@lists.launchpad.net, "Alexander A. Klimov" , Allen Pais , Anders Blomdell , Andrea Merello , Andres Klode , Andrey Shvetsov , Arve =?utf-8?B?SGrDuG5uZXbDpWc=?= , Christian Brauner , Comedi , "David A. Schleef" , dri-devel@lists.freedesktop.org, Florian Schilhabel , Forest Bond , Greg Kroah-Hartman , Herman.Bruyninckx@mech.kuleuven.ac.be, H Hartley Sweeten , Hridya Valsaraju , Ian Abbott , Ilya Petrov , Jacob Feder , Jerry chuang , Joel Fernandes , "John B. Wyatt IV" , Jonathan Cameron , "J.P. Mellor" , karthik alapati , Kees Cook , Kernel Team , Klaas.Gadeyne@mech.kuleuven.ac.be, Larry Finger , Lars-Peter Clausen , linux-fbdev@vger.kernel.org, linux-iio@vger.kernel.org, linux-pwm@vger.kernel.org, linux-staging@lists.linux.dev, linux-tegra@vger.kernel.org, Marc Dietrich , Marco Cesati , Martijn Coenen , Michael Hennerich , Michael Straube , Mori Hess , =?utf-8?B?TsOtY29sYXMgRi4gUi4gQS4=?= Prado , Peter Hurley , Philipp Zabel , Pierre-Hugues Husson , Robert Love , Romain Perier , Ross Schmidt , "Spencer E. Olson" , Stanley@BB.SD3, Sudip Mukherjee , Sumera Priyadarsini , Suren Baghdasaryan , Teddy Wang , Thierry Reding , Thomas Gleixner , Todd Kjos , Truxton Fulton , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Wim.Meeussen@mech.kuleuven.ac.be, Zhansaya Bagdauletkyzy Subject: Re: [PATCH 00/57] Rid W=1 warnings from Staging Message-ID: <20210416072749.GA1394@agape.jhs> References: <20210414181129.1628598-1-lee.jones@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210414181129.1628598-1-lee.jones@linaro.org> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org On Wed, Apr 14, 2021 at 07:10:32PM +0100, Lee Jones wrote: > This set is part of a larger effort attempting to clean-up W=1 > kernel builds, which are currently overwhelmingly riddled with > niggly little warnings. > > Lee Jones (57): > staging: r8192U_core: Remove two unused variables 'ret' and > 'reset_status' > staging: android: ashmem: Supply description for 'new_range' > staging: comedi_8254: Fix descriptions for 'i8254' and 'iobase' > staging: r8192U_core: Do not use kernel-doc formatting for !kernel-doc > headers > staging: r819xU_phy: Remove some local variables from the stack > staging: r819xU_cmdpkt: Remove functionless method > 'cmpk_handle_query_config_rx' > staging: wlan-ng: cfg80211: Move large struct onto the heap > staging: rtw_ioctl_set: Move 'channel_table' to the only place it's > used > staging: rtl8188eu: core: rtw_ieee80211: Fix incorrectly documented > function > staging: rtl8723bs: core: rtw_mlme: Remove a bunch of unused variables > staging: rtl8723bs: core: rtw_mlme_ext: Deal with a bunch of unused > variables > staging: rtl8712: rtl871x_mp_ioctl: Remove a bunch of unused tables > staging: rtl8723bs: core: rtw_recv: Mark debug variable as > __maybe_unused > staging: rtl8188eu: core: rtw_security: Fix some formatting and > misdocumentation > staging: rtl8723bs: core: rtw_security: Demote non-conformant > kernel-doc header > staging: rtl8723bs: core: rtw_sta_mgt: Remove unused variable 'psta' > staging: rtl8723bs: core: rtw_sta_mgt: Return error value directly > staging: octeon: ethernet-tx: Fix formatting issue in function header > staging: rtl8723bs: core: rtw_wlan_util: Remove unused variable > 'start_seq' > staging: rtl8712: rtl871x_mp_ioctl: Move a large data struct onto the > heap > staging: iio: frequency: ad9834: Provide missing description for > 'devid' > staging: nvec: Fix a bunch of kernel-doc issues > staging: ks7010: ks_hostif: Remove a bunch of unused variables > staging: fwserial: Demote a whole host of kernel-doc abuses > staging: sm750fb: sm750_accel: Provide description for 'accel' and fix > function naming > staging: most: net: Fix some kernel-doc formatting issues > staging: vt6655: upc: Suppress set but not used warning in macro > staging: rtl8192u: ieee80211_softmac: Move a large data struct onto > the heap > staging: most: dim2: Provide missing descriptions and fix doc-rot > staging: rtl8723bs: core: rtw_ieee80211: Remove seemingly pointless > copy > staging: rtl8723bs: core: rtw_mlme: 'retry' is only used if REJOIN is > set > staging: rtl8723bs: core: rtw_mlme_ext: 'evt_seq' is only used if > CHECK_EVENT_SEQ is set > staging: most: i2c: Fix a little doc-rot > staging: most: dim2: hal: Fix one kernel-doc header and demote two > non-conforming ones > staging: most: dim2: hal: Demote non-conformant kernel-doc headers > staging: axis-fifo: axis-fifo: Fix some formatting issues > staging: rtl8188eu: os_dep: ioctl_linux: Move 2 large data buffers > into the heap > staging: fbtft: fb_ili9320: Remove unused variable 'ret' > staging: rtl8723bs: core: rtw_ieee80211: Fix incorrectly named > function > staging: rtl8723bs: hal: odm_NoiseMonitor: Remove unused variable and > dead code > staging: rtl8188eu: os_dep: mon: Demote non-conforming kernel-doc > headers > staging: rtl8188eu: os_dep: rtw_android: Demote kernel-doc abuse > staging: rtl8723bs: hal: rtl8723b_hal_init: Remove unused variable and > dead code > staging: rtl8723bs: hal: rtl8723b_phycfg: Fix a bunch of misnamed > functions > staging: rtl8723bs: hal: sdio_halinit: 'start' is only used if debug > is enabled > staging: rtl8723bs: hal: sdio_ops: Mark used 'err' as __maybe_unused > and remove another > staging: rtl8723bs: os_dep: ioctl_cfg80211: 'ack' is used when debug > is enabled > staging: comedi: drivers: jr3_pci: Remove set but unused variable > 'min_full_scale' > staging: comedi: drivers: ni_tio: Fix slightly broken kernel-doc and > demote others > staging: comedi: drivers: ni_routes: Demote non-conforming kernel-doc > headers > staging: axis-fifo: axis-fifo: Fix function naming in the > documentation > staging: rtl8723bs: hal: odm_NoiseMonitor: Remove unused variable > 'func_start' > staging: rtl8723bs: core: rtw_mlme_ext: Move very large data buffer > onto the heap > staging: rtl8723bs: hal: rtl8723b_hal_init: Mark a bunch of debug > variables as __maybe_unused > staging: comedi: drivers: ni_mio_common: Move 'range_ni_E_ao_ext' to > where it is used > staging: comedi: drivers: comedi_isadma: Fix misspelling of > 'dma_chan1' > staging: rtl8723bs: hal: sdio_halinit: Remove unused variable 'ret' > > drivers/staging/android/ashmem.c | 1 + > drivers/staging/axis-fifo/axis-fifo.c | 18 +-- > drivers/staging/comedi/drivers/comedi_8254.c | 3 +- > .../staging/comedi/drivers/comedi_isadma.c | 2 +- > drivers/staging/comedi/drivers/jr3_pci.c | 3 +- > .../staging/comedi/drivers/ni_mio_common.c | 9 -- > drivers/staging/comedi/drivers/ni_routes.c | 6 +- > drivers/staging/comedi/drivers/ni_stc.h | 9 +- > drivers/staging/comedi/drivers/ni_tio.c | 12 +- > drivers/staging/fbtft/fb_ili9320.c | 3 +- > drivers/staging/fwserial/fwserial.c | 46 +++---- > drivers/staging/iio/frequency/ad9834.c | 5 +- > drivers/staging/ks7010/ks_hostif.c | 14 +- > drivers/staging/most/dim2/dim2.c | 23 ++-- > drivers/staging/most/dim2/hal.c | 10 +- > drivers/staging/most/i2c/i2c.c | 12 +- > drivers/staging/most/net/net.c | 6 +- > drivers/staging/nvec/nvec.c | 7 +- > drivers/staging/octeon/ethernet-tx.c | 1 - > drivers/staging/qlge/qlge_main.c | 4 +- > .../staging/rtl8188eu/core/rtw_ieee80211.c | 2 +- > .../staging/rtl8188eu/core/rtw_ioctl_set.c | 8 ++ > drivers/staging/rtl8188eu/core/rtw_security.c | 10 +- > .../staging/rtl8188eu/include/rtw_mlme_ext.h | 8 -- > .../staging/rtl8188eu/os_dep/ioctl_linux.c | 12 +- > drivers/staging/rtl8188eu/os_dep/mon.c | 6 +- > .../staging/rtl8188eu/os_dep/rtw_android.c | 2 +- > .../rtl8192u/ieee80211/ieee80211_softmac.c | 9 +- > drivers/staging/rtl8192u/r8192U_core.c | 11 +- > drivers/staging/rtl8192u/r819xU_cmdpkt.c | 41 ------ > drivers/staging/rtl8192u/r819xU_phy.c | 48 +++++-- > drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 29 ++-- > drivers/staging/rtl8712/rtl871x_mp_ioctl.h | 127 ------------------ > .../staging/rtl8723bs/core/rtw_ieee80211.c | 6 +- > drivers/staging/rtl8723bs/core/rtw_mlme.c | 17 +-- > drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 19 +-- > drivers/staging/rtl8723bs/core/rtw_recv.c | 2 +- > drivers/staging/rtl8723bs/core/rtw_security.c | 2 +- > drivers/staging/rtl8723bs/core/rtw_sta_mgt.c | 10 +- > .../staging/rtl8723bs/core/rtw_wlan_util.c | 4 +- > .../staging/rtl8723bs/hal/odm_NoiseMonitor.c | 9 +- > .../staging/rtl8723bs/hal/rtl8723b_hal_init.c | 21 +-- > .../staging/rtl8723bs/hal/rtl8723b_phycfg.c | 10 +- > drivers/staging/rtl8723bs/hal/sdio_halinit.c | 8 +- > drivers/staging/rtl8723bs/hal/sdio_ops.c | 7 +- > .../staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 2 +- > drivers/staging/sm750fb/sm750_accel.c | 4 +- > drivers/staging/vt6655/upc.h | 2 +- > drivers/staging/wlan-ng/cfg80211.c | 30 +++-- > 49 files changed, 256 insertions(+), 404 deletions(-) > > Cc: ac100@lists.launchpad.net > Cc: "Alexander A. Klimov" > Cc: Allen Pais > Cc: Anders Blomdell > Cc: Andrea Merello > Cc: Andres Klode > Cc: Andrey Shvetsov > Cc: "Arve Hjønnevåg" > Cc: Christian Brauner > Cc: Comedi > Cc: "David A. Schleef" > Cc: dri-devel@lists.freedesktop.org > Cc: Fabio Aiuto > Cc: Florian Schilhabel > Cc: Forest Bond > Cc: Greg Kroah-Hartman > Cc: Herman.Bruyninckx@mech.kuleuven.ac.be > Cc: H Hartley Sweeten > Cc: Hridya Valsaraju > Cc: Ian Abbott > Cc: Ilya Petrov > Cc: Jacob Feder > Cc: Jerry chuang > Cc: Joel Fernandes > Cc: "John B. Wyatt IV" > Cc: Jonathan Cameron > Cc: "J.P. Mellor" > Cc: karthik alapati > Cc: Kees Cook > Cc: Kernel Team > Cc: Klaas.Gadeyne@mech.kuleuven.ac.be > Cc: Larry Finger > Cc: Lars-Peter Clausen > Cc: Lee Jones > Cc: linux-fbdev@vger.kernel.org > Cc: linux-iio@vger.kernel.org > Cc: linux-pwm@vger.kernel.org > Cc: linux-staging@lists.linux.dev > Cc: linux-tegra@vger.kernel.org > Cc: Marc Dietrich > Cc: Marco Cesati > Cc: Martijn Coenen > Cc: Michael Hennerich > Cc: Michael Straube > Cc: Mori Hess > Cc: "Nícolas F. R. A. Prado" > Cc: Peter Hurley > Cc: Philipp Zabel > Cc: Pierre-Hugues Husson > Cc: Robert Love > Cc: Romain Perier > Cc: Ross Schmidt > Cc: "Spencer E. Olson" > Cc: Stanley@BB.SD3 > Cc: Sudip Mukherjee > Cc: Sumera Priyadarsini > Cc: Suren Baghdasaryan > Cc: Teddy Wang > Cc: Thierry Reding > Cc: Thomas Gleixner > Cc: Todd Kjos > Cc: Truxton Fulton > Cc: "Uwe Kleine-König" > Cc: Wim.Meeussen@mech.kuleuven.ac.be > Cc: WLAN FAE > Cc: Zhansaya Bagdauletkyzy > -- > 2.27.0 > Hi, what about splitting this series in smaller per driver series? thank you, fabio