From: Lee Jones <email@example.com> To: ChiYuan Huang <firstname.lastname@example.org> Cc: email@example.com, Mark Brown <firstname.lastname@example.org>, Daniel Thompson <email@example.com>, firstname.lastname@example.org, email@example.com, firstname.lastname@example.org, email@example.com, lkml <firstname.lastname@example.org>, ChiYuan Huang <email@example.com> Subject: Re: [PATCH v6 1/4] mfd: rt4831: Adds support for Richtek RT4831 Date: Mon, 19 Apr 2021 08:22:29 +0100 [thread overview] Message-ID: <20210419072229.GA4869@dell> (raw) In-Reply-To: <CADiBU3-d3_L8RTeYCirnfjJdG=ea6UVenAi8O8GO_LvOaB7OdA@mail.gmail.com> On Mon, 19 Apr 2021, ChiYuan Huang wrote: > Hi, Linux mfd reviewers: > It's been three weeks not to get any response from you. > Is there something wrong about this mfd patch? > If yes, please feel free to let me know. Couple of things: First, if you think a patch had fallen through the gaps, which does happen sometimes, it is generally considered acceptable to submit a [RESEND] ~2 weeks after the initial submission. FYI: This was such a patch. It was not on, or had fallen off of my radar for some reason. Secondly, we are really late in the release cycle. -rc8 has just been released. Quite a few maintainers slow down at ~-rc6. Particularly for new drivers. No need to resubmit this driver this time. It is now on my to-review list and I will tend to it shortly. Thanks for your patience. > cy_huang <firstname.lastname@example.org> 於 2021年3月28日 週日 下午11:24寫道： > > > > From: ChiYuan Huang <email@example.com> > > > > This adds support Richtek RT4831 core. It includes four channel WLED driver > > and Display Bias Voltage outputs. > > > > Signed-off-by: ChiYuan Huang <firstname.lastname@example.org> > > --- > > The RT4831 regulator patches are already on main stream, and can be referred to > > 9351ab8b0cb6 regulator: rt4831: Adds support for Richtek RT4831 DSV regulator > > 934b05e81862 regulator: rt4831: Adds DT binding document for Richtek RT4831 DSV regulator > > > > since v6 > > - Respin the date from 2020 to 2021. > > - Rmove the shutdown routine. > > - Change the macro OF_MFD_CELL to MFD_CELL_OF. > > > > > > since v5 > > - Rename file name from rt4831-core.c to rt4831.c > > - Change RICHTEK_VID to RICHTEK_VENDOR_ID. > > - Change gpio_desc nameing from 'enable' to 'enable_gpio' in probe. > > - Change variable 'val' to the meaningful name 'chip_id'. > > - Refine the error log when vendor id is not matched. > > - Remove of_match_ptr. > > > > since v2 > > - Refine Kconfig descriptions. > > - Add copyright. > > - Refine error logs in probe. > > - Refine comment lines in remove and shutdown. > > --- > > drivers/mfd/Kconfig | 10 +++++ > > drivers/mfd/Makefile | 1 + > > drivers/mfd/rt4831.c | 115 +++++++++++++++++++++++++++++++++++++++++++++++++++ > > 3 files changed, 126 insertions(+) > > create mode 100644 drivers/mfd/rt4831.c -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2021-04-19 7:22 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-03-28 15:24 cy_huang 2021-03-28 15:24 ` [PATCH v6 2/4] backlight: rt4831: Adds DT binding document for Richtek RT4831 backlight cy_huang 2021-03-29 10:28 ` Daniel Thompson 2021-03-28 15:24 ` [PATCH v6 3/4] mfd: rt4831: Adds DT binding document for Richtek RT4831 cy_huang 2021-03-28 15:24 ` [PATCH v6 4/4] backlight: rt4831: Adds support for Richtek RT4831 backlight cy_huang 2021-03-29 10:26 ` Daniel Thompson 2021-03-29 13:46 ` ChiYuan Huang 2021-04-19 5:57 ` [PATCH v6 1/4] mfd: rt4831: Adds support for Richtek RT4831 ChiYuan Huang 2021-04-19 7:22 ` Lee Jones [this message] 2021-04-19 7:23 ` Lee Jones 2021-04-19 7:24 ` Lee Jones 2021-04-19 9:55 ` ChiYuan Huang 2021-04-23 0:58 ` ChiYuan Huang 2021-04-23 8:27 ` Lee Jones
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210419072229.GA4869@dell \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH v6 1/4] mfd: rt4831: Adds support for Richtek RT4831' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).