From: Guenter Roeck <linux@roeck-us.net>
To: Nathan Chancellor <nathan@kernel.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
Nick Desaulniers <ndesaulniers@google.com>,
dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] fbmem: Correct position of '__maybe_unused' in proc_fb_seq_ops
Date: Wed, 5 May 2021 20:03:43 -0700 [thread overview]
Message-ID: <20210506030343.GA741106@roeck-us.net> (raw)
In-Reply-To: <20210505182808.3855516-1-nathan@kernel.org>
On Wed, May 05, 2021 at 11:28:08AM -0700, Nathan Chancellor wrote:
> Clang warns:
>
> drivers/video/fbdev/core/fbmem.c:736:21: warning: attribute
> declaration must precede definition [-Wignored-attributes]
> static const struct __maybe_unused seq_operations proc_fb_seq_ops = {
> ^
> ./include/linux/compiler_attributes.h:273:56: note: expanded from macro
> '__maybe_unused'
> #define __maybe_unused __attribute__((__unused__))
> ^
> ./include/linux/seq_file.h:31:8: note: previous definition is here
> struct seq_operations {
> ^
> 1 warning generated.
>
> The attribute should not split the type 'struct seq_operations'. Move it
> before the struct keyword so that it works properly and there is no more
> warning.
>
Oops, sorry.
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Guenter
> Fixes: b9d79e4ca4ff ("fbmem: Mark proc_fb_seq_ops as __maybe_unused")
> Link: https://github.com/ClangBuiltLinux/linux/issues/1371
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Nathan Chancellor <nathan@kernel.org>
> ---
> drivers/video/fbdev/core/fbmem.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/core/fbmem.c b/drivers/video/fbdev/core/fbmem.c
> index 52c606c0f8a2..84c484f37b4a 100644
> --- a/drivers/video/fbdev/core/fbmem.c
> +++ b/drivers/video/fbdev/core/fbmem.c
> @@ -733,7 +733,7 @@ static int fb_seq_show(struct seq_file *m, void *v)
> return 0;
> }
>
> -static const struct __maybe_unused seq_operations proc_fb_seq_ops = {
> +static const __maybe_unused struct seq_operations proc_fb_seq_ops = {
> .start = fb_seq_start,
> .next = fb_seq_next,
> .stop = fb_seq_stop,
>
> base-commit: b9d79e4ca4ff23543d6b33c736ba07c1f0a9dcb1
> --
> 2.31.1.362.g311531c9de
>
prev parent reply other threads:[~2021-05-06 3:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-05 18:28 [PATCH] fbmem: Correct position of '__maybe_unused' in proc_fb_seq_ops Nathan Chancellor
2021-05-06 3:03 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210506030343.GA741106@roeck-us.net \
--to=linux@roeck-us.net \
--cc=clang-built-linux@googlegroups.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).